When `Tabs` are nested within each other, the highlight can get
misaligned. This prevents that by ensuring the affected
`.tab-highlight` is a direct child of the targeted `Tabs`.
* fix(item-sliding): fix item-sliding RTL
fix a bug that options disappear on RTL
* wrong class
* revert back ts changes
* create scss fixes
* correct order of rule set
* Right is right and left is left
unless we use start or end for rtl and ltr right should be placed right
and so does left.
* using multi-dir and ltr mixins
* Currect order on RTL using ltr and rtl specific mixins
* dupplicate the comment to disable PropertySpelling
* feat(svg-background-image): support flipped on rtl
* feat(svg-background-image): add rtl for needed icons
* revert(svg-background-image): no need to flip clear
* fix(svg-background-image): translate to place
* fix(svg-background-image): add support for line and polygon
* fix(menu): rtl fix for menu
* disable PropertySpelling in scss-lint for this special case
* Revert "disable PropertySpelling in scss-lint for this special case"
This reverts commit 87c3302fc2.
* remove scss changes because of the conflict
* Fix left (default) menu position
* Revert "Fix left (default) menu position"
This reverts commit f657369540.
* trim down ifs
* remove unnecessary this
* feat(rtl): add translate3d support for directions
* feat(rtl): add transform-origin support for directions
* fix(transform): add missing origins
* fix(transform): when given a percentage, calc on rtl
* fix(transform-origin): be same as before
* fix(translate3d): no double minus
* fix(translate3d): use transform instead of cloning code
* style(scss-lint): remove empty line
* fix(merge): fix bad merge
* refactor(transform-origin): nicer logic
* style(): add eof line
* fix(transform): remove unneeded mixin
* feat(rtl): add transform mixin and str-split function
* Merge remote-tracking branch 'remotes/upstream/rtl-transform' into transform-rtl
# Conflicts:
# src/themes/ionic.mixins.scss
* fix(transform): fix string comparison
* fix(select): make select with no options return undefined when OK is pressed (#10435)
* refactor(select): add early check for alert inputs
fixes#10435
* feat(background-position): add background position support for rtl
* fix(background-position): fix center
* refactor(background-position): make format more robust
* fix(lint): unused import
* feat(platform): enforce direction value
* style(platform): make sure not to change indentation
* refactor(platform): rename PageDirection to DocumentDirection
* refactor(item): replaced item-left with item-start
replaced item-right with item-end
* style(item): fix spacing
* fix(item): add backwards support for left/right in ng-content
* fix(item): deprecated old variables, not breaking change
* feat(rtl): padding mixin
* feat(rtl): change all padding variables to start/end
add support for old variable names
* feat(rtl): replace all padding-side with start/end
* revert(functions): remove mixins
* feat(scss): add padding-horizontal and rtl functions (thanks brandy)
* feat(padding): use padding horizontal mixin everywhere
* feat(padding): use padding horizontal mixin everywhere
* fix(lint): change properties order. tests passing
* fix(sass-functions): reorder functions to avoid warning
* fix(scss): fix variable name
* perf(rtl): add check if need rtl selector
* feat(scss): add full padding function
* feat(scss): add border-radius mixin
* fix(rtl): change border-radius to use mixin
* perf(scss): only override if has something to override
* feat(scss): add margin scss variables for sides
* feat(scss): add margin mixin
* fix(scss): fix wrong support for 2/3 args
* feat(rtl): spread margins/paddings
* feat(rtl): spread margins/paddings
* feat(position): add rtl support for absolute
* fix(rtl): add missing calls
* fix(item): old attributes deprecated support
* revert(changelog): not intended to be changed
* fix(sass-functions): and not &&
* fix(padding): merge + missing padding
* style(): remove newline
* refactor(mixins): move mixins to mixins file
* style(): fix alignment
* fix(item): right padding should not be set
* fix(): incorrect defaults
* feat(scss-lint): disable some side variables
* fix(scss): lint passes
* feat(lint): disabled text-align
* fix(): correct variable name
* fix(fab): missed a comma
* fix(rtl): rtl method incorrect for multiple selectors
* fix(rtl): toolbar bad merge
* fix(rtl): icon-only is in px not em
* fix(rtl): toggle padding
* feat(rtl): correct notation for rtl custom
* Merge branch 'breaking-item' into start-end
# Conflicts:
# src/components/checkbox/checkbox.ios.scss
# src/components/checkbox/checkbox.md.scss
# src/components/checkbox/checkbox.wp.scss
# src/components/item/item.ios.scss
# src/components/item/item.md.scss
# src/components/item/item.wp.scss
# src/components/radio/radio.ios.scss
# src/components/radio/radio.md.scss
# src/components/radio/radio.wp.scss
# src/components/toggle/toggle.ios.scss
# src/components/toggle/toggle.md.scss
# src/components/toggle/toggle.wp.scss
* feat(rtl): optimize bundle result
* feat(float): use new standard
* feat(platform): gotta have direction on html
* fix(scss): add import + change code order
* fix(lint): passes
* fix(scss): fix for deprecated usages
* fix(scss): property use #{}
* fix(rtl): change css specificity, increase bundle size for multidirectional
* fix(scss): mixin manages priority
* fix(scss): select icon
* fix(scss): correct range variable
* fix(lint): unused import
* fix(multi-dir): things that ignore PropertySpelling must be under multi-dir
* fix(multi-dir): things that ignore PropertySpelling must be under multi-dir
* fix(include-rtl): change to app-direction, to be able to set rtl only apps
* fix(rtl): remove incorrect split-pane rtl behavior
* fix(menu): start needs position on rtl
* fix(float): renamed test file, add float mixin
* fix(scss-lint): lint excluded files
* fix(scss): add missing unit
* refactor(scss): change dir to direction, as the correct property name
* fix(app-direction): replace last usage of include-rtl
Closes: #11805#11914
Short description of what this resolves:
Allows our e2e tests to run on a Windows machine
Changes proposed in this pull request:
Normalize paths using path.join()
Add typeRoots to the root tsconfig file
Change the spawnedCommand based on the OS
Fixes: #11551
* fix(select): RTL fix for searchbar
RTL fix for searchbar component
* fix bad reference
I forgot to refrence _isRTL
* use platform variable instead of method
* space indent instead of tab indent
* Remove scss changes per request
PR - #11342 - covers the scss, and is about done
item-start and item-end make more sense for RTL
* refactor(item): replaced item-left with item-start
replaced item-right with item-end
* style(item): fix spacing
* fix(item): add backwards support for left/right in ng-content
* fix(item): deprecated old variables, not breaking change
* fix(scss): fix variable name
* fix(item): old attributes deprecated support
* docs(snapshot): depends on java jdk as well
* docs(snapshot): only works on a retina mac
* docs(snapshot): move explanation out of setup
* docs(snapshot): only for mac
* implement ability to close select programmatically
* refactor(select): made changes based on PR feedback, namely assigning overlay to the overlay property at then end of the open function, applying DeMorgan's Law to a condition, and returning the overlay dismiss promise from the close function
* refactor(select): made additional changes to closing select component programmatically to resolve issue 11318
* test(datetime): add e2e test with no format provided
* test(datetime): add test to check output is a string
* test(datetime): add e2e test with no format provided
* test(datetime): add test to check output is a string
* test(datetime): add unit tests to make sure we return a string when we should
* floating label rtl fix
add rtl fix to floating label
* single block, not nesting
* fix(floating-label): wp and ios issue for rtl
problems with transform-origin with both windows and ios platform for
rtl and also wrong translate3d for rtl for windows platform
* style(floating-label): remove html, 2 space indent
remove reference of "html", just plain '[dir="rtl"]
indent 2 space instead of 4
* refactor(floating-label): remove duplicate rule
remove unnecessary duplicate rule
* fix(item): Initial version of better rtl support
for sliding items
*Note:* need tests
* Update item-options.ts
* fix(item-options): fix changes requested
- moves breakpoint mixins to the ionic.mixins file
- adds responsive attributes for text alignment, transform, and
floating elements
- adds ability to turn these off so they don’t get added to the css
file using sass variables
references #10904closes#10567
* Update documentation for ion-slide
Reading the documentation and following along left me lost as to why the .lockNextSlides() was not working, this was because it required a boolean parameter that was not reflected in the documentation. This PR adds the JSDoc @param to show that the function requires a boolean parameter. Does not include a definition for the single parameters so this may cause issue in the theme of the docs template.
* Changing order of type definition
* Adding definitions to JSdoc for slider.
The current documentation has `selected="true"` combined with `ngModel` binding, but this does not work. In fact, the demo on the page does not use `selected`. I removed this from the example code.
I also added a paragraph explaining how to set an option as selected.
Can pass one cssClass or multiple (same as out other overlays). Added a
cssClass to the basic test which adds 2 classes and styles the font
color of the content blue.
Closes#10020
* docs(issue_template): add ionic v3 for issue template
Now that v3 is officially in beta, this is needed for bug reports
* docs(pull_request_template): add ionic v3 for pull request template
* fix(datetime): emit ioncancel event on backdrop click for datetime component
* fix(datetime): emit ioncancel event on backdrop click for datetime component - fix for all picker components instead of specifically for datetime
* trying Circle CI v2
* paths are fun
* seeing how long a demos build takes
* Batching Demo builds
* testing demo builds on CI2
* batches count from 0
* ok, looks good. preparing for master branch
* forgot `production=true` flag. let’s test that quick.
* forgot to save the file
* making sure that docs are still copied over to ionic-site in the deploy phase
* getting ready for the PR again
BREAKING CHANGES
Slides input `options` has been removed. Please use the input
properties instead.
Slide event `ionWillChange` has been removed, please use
`ionSlideWillChange` instead.
Slide event `ionDidChange` has been removed, please use
`ionSlideDidChange` instead.
Slide event `ionDrag` has been removed, please use `ionSlideDrag`
instead.
Slides `getSlider()` method has been removed, please use the instance
of ion-slides.
BREAKING CHANGES:
The following selectors to style the text color of the native text
elements have been removed:
```
h1[color], h2[color], h3[color], h4[color], h5[color], h6[color],
a[color]:not([ion-button]):not([ion-item]):not([ion-fab]), p[color],
span[color], b[color], i[color], strong[color], em[color],
small[color], sub[color], sup[color]
```
These have been throwing a deprecation warning since rc.3 but still
working. They are officially gone and therefore these elements will not
get the color unless the `ion-text` attribute is added. Please see the
documentation.
also return empty array so that if the exact folder isn’t matched it
won’t continue to filter and run tests. For example, if you pass
`--f=toolbar/color` it will error because that doesn't exist, but still
tries to run `toolbar/colors`.
- If the e2e test doesn’t exist then throw an error
- Don’t log anything if no tests are being built
- Add concurrency arg to change the number of tests being ran at once
* fix(slides): simulate touch events for query params
Slide fail to swipe when platform via query params.
This lets touch events be simulated is ionicPlatform is set.
Closes#10577
* style(remove debug log):
* feat(infinite): add scroll in opposite direction
fixes
* test(infinite-scroll): opposite direction e2e test
* fix(infinite-scroll): keep scroll position
* feat(content): scroll down on load
* fix(infinite-scroll): scroll the content down on load
* Requested changes
This allows to use `$event.waitFor(request())` inside template within `infinite` event. So that, user components do not depend on InifiniteScroll inside javascript.
* feat(split-panel): split panel support for ion-nav and ion-menu
Revert some changes
adds support split-panel support for tabs
Removes .orig
removes e2e.ts
Removes unneeded changes in menu.ts
improves stuff
* fix(split-panel): resize is called when menu wraps a ion-nav
* test(split-panel): improves split-panel/basic test
* feat(split-panel): ionChange is an ng2 @Output()
* fix(split-panel): fix tabs as side content
* fix(menu): forzedClose works as expected
* feat(split-panel): split-panel works with several menus
* chore(split-panel): renames to split-pane
* refactor(split-pane): splitPane can be injected
* fix(split-pane): it is a directive
* fix(slides): integration with split-panel
* Make gulp validate happy
* Fix incorrect .radio-inner width/height calculation
* Add additional fix to the .radio-inner width/height calculation of the android radio button icon
* chore(angular): update to latest stable angular
* chore(deps): update app-scripts
* chore(deps): sw-toolbox
* chore(deps): bump to 1.1.1 app-scripts
* chore(deps): abc order sw-toolbox
* chore(deps): update to angular 2.4.8
* chore(build): pass appNgModule path to app-scripts, make run AoT instead of Prod when using --debug
pass appNgModule path to app-scripts, make run AoT instead of Prod when using --debug
* chore(platform): resize works correctly
* chore(platform): height correct after resize
* test(platform): add new dimensions unit tests
* chore(platform): works with keyboard too
* chore(platform): store values
* chore(platform): change const to var
* test(refresher): add nav based refresher e2e test
* test(refresher): tweak test to repro issue
* fix(content): check for scroll element
* chore(content): double check for a scroll element
* feat(alert): add sass variables for checkbox and radio button text color
* style(alert): remove extra spaces
* Replace initial value with `initial` instead of `null`
* Remove submodule
* fix ios variable usage
* style(alert wp): remove whitespace
* chore(release): add inquirer to prompt for release
* chore(release): wip get release working again and test
also adds nightly back in
* chore(release): WIP remove commented code
Adds the disabled attribute to the parent input/textarea, also fixes
where disabled textareas were focusable regardless of where disabled
was set
fixes#10155
@@ -5,23 +5,29 @@ Thanks for your interest in contributing to the Ionic Framework! :tada:
## Contributing Etiquette
Please see our [Contributor Code of Conduct](https://github.com/driftyco/ionic/blob/master/CODE_OF_CONDUCT.md) for information on our rules of conduct.
Please see our [Contributor Code of Conduct](https://github.com/ionic-team/ionic/blob/master/CODE_OF_CONDUCT.md) for information on our rules of conduct.
## Creating an Issue
If you have a question about using the framework, please ask on the [Ionic Forum](http://forum.ionicframework.com/) or in the [Ionic Worldwide Slack](http://ionicworldwide.herokuapp.com/) group.
*If you have a question about using the framework, please ask on the [Ionic Forum](http://forum.ionicframework.com/) or in the [Ionic Worldwide Slack](http://ionicworldwide.herokuapp.com/) group.
If you think you have found a bug, or have a new feature idea, please start by making sure it hasn't already been [reported](https://github.com/driftyco/ionic/issues?utf8=%E2%9C%93&q=is%3Aissue). You can search through existing issues to see if there is a similar one reported. Include closed issues as it may have been closed with a solution.
* It is required that you clearly describe the steps necessary to reproduce the issue you are running into. Although we would love to help our users as much as possible, diagnosing issues without clear reproduction steps is extremely time-consuming and simply not sustainable.
Next, [create a new issue](https://github.com/driftyco/ionic/issues/new) that thoroughly explains the problem. Please fill out the populated issue form before submitting the issue.
* The issue list of this repository is exclusively for bug reports and feature requests. Non-conforming issues will be closed immediately.
* Issues with no clear steps to reproduce will not be triaged. If an issue is labeled with "needs reply" and receives no further replies from the author of the issue for more than 5 days, it will be closed.
* If you think you have found a bug, or have a new feature idea, please start by making sure it hasn't already been [reported](https://github.com/ionic-team/ionic/issues?utf8=%E2%9C%93&q=is%3Aissue). You can search through existing issues to see if there is a similar one reported. Include closed issues as it may have been closed with a solution.
* Next, [create a new issue](https://github.com/ionic-team/ionic/issues/new) that thoroughly explains the problem. Please fill out the populated issue form before submitting the issue.
## Creating a Pull Request
We appreciate you taking the time to contribute! Before submitting a pull request, we ask that you please [create an issue](#creating-an-issue) that explains the bug or feature request and let us know that you plan on creating a pull request for it. If an issue already exists, please comment on that issue letting us know you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.
*We appreciate you taking the time to contribute! Before submitting a pull request, we ask that you please [create an issue](#creating-an-issue) that explains the bug or feature request and let us know that you plan on creating a pull request for it. If an issue already exists, please comment on that issue letting us know you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.
Looking for an issue to fix? Make sure to look through our issues with the [help wanted](https://github.com/driftyco/ionic/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) label!
*Looking for an issue to fix? Make sure to look through our issues with the [help wanted](https://github.com/ionic-team/ionic/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) label!
### Setup
@@ -79,9 +85,9 @@ Looking for an issue to fix? Make sure to look through our issues with the [help
```
where `@name` is the Class name, `@description` is the description displayed on the documentation page, `@see` links to any related pages, and `@demo` links to the API demo located in the `demos` folder.
2. In order to run API documentation locally, you will need to clone the `ionic-site` repo as a sibling to the `ionic` repo and then run it: https://github.com/driftyco/ionic-site#local-build
2. In order to run API documentation locally, you will need to clone the `ionic-site` repo as a sibling to the `ionic` repo and then run it: https://github.com/ionic-team/ionic-site#local-build
3. Then, run `gulp docs` in the `ionic` repo every time you make a change and the site will update.
4. If the change affects the component documentation, create an issue on the `ionic-site` repo: https://github.com/driftyco/ionic-site/issues
4. If the change affects the component documentation, create an issue on the `ionic-site` repo: https://github.com/ionic-team/ionic-site/issues
#### Adding Demos
@@ -100,12 +106,12 @@ Looking for an issue to fix? Make sure to look through our issues with the [help
```
3. Run `gulp watch.demos` to watch for changes to the demo
4. Navigate to `http://localhost:8000/dist/demos/` and then to your component's demo to view it.
5. If the change affects the component demos, create an issue on the `ionic-site` repo: https://github.com/driftyco/ionic-site/issues
5. If the change affects the component demos, create an issue on the `ionic-site` repo: https://github.com/ionic-team/ionic-site/issues
## Commit Message Format
We have very precise rules over how our git commit messages should be formatted. This leads to readable messages that are easy to follow when looking through the project history. We also use the git commit messages to generate our [changelog](https://github.com/driftyco/ionic/blob/master/CHANGELOG.md). (Ok you got us, it's basically Angular's commit message format).
We have very precise rules over how our git commit messages should be formatted. This leads to readable messages that are easy to follow when looking through the project history. We also use the git commit messages to generate our [changelog](https://github.com/ionic-team/ionic/blob/master/CHANGELOG.md). (Ok you got us, it's basically Angular's commit message format).
`type(scope): subject`
@@ -137,4 +143,4 @@ The subject contains succinct description of the change:
## License
By contributing your code to the driftyco/ionic GitHub Repository, you agree to license your contribution under the MIT license.
By contributing your code to the ionic-team/ionic GitHub Repository, you agree to license your contribution under the MIT license.
[ ] **1.x** (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] **2.x**
[ ] **3.x**
**I'm submitting a ...** (check one with "x")
[ ] bug report
@@ -16,9 +17,9 @@
**Steps to reproduce:**
<!-- If you are able to illustrate the bug or feature request with an example, please provide steps to reproduce and if possible a demo using one of the following templates:
For Ionic 1 issues - http://plnkr.co/edit/Xo1QyAUx35ny1Xf9ODHx?p=preview
For Ionic V1 issues - http://plnkr.co/edit/Xo1QyAUx35ny1Xf9ODHx?p=preview
For Ionic 2 issues - http://plnkr.co/edit/z0DzVL?p=preview
For Ionic issues - http://plnkr.co/edit/cpeRJs?p=preview
Ionic 2 is the next generation of [Ionic](http://ionicframework.com/), the open-source mobile app development SDK that makes it easy to build top quality native and progressive web apps with web technologies.
[Ionic](https://ionicframework.com/) is the open-source mobile app development framework that makes it easy to
build top quality native and progressive web apps with web technologies.
Ionic 2 is based on the new [2.x version of Angular](https://angular.io/), and comes with many significant performance, usability, and feature improvements.
Ionic is based on [Angular](https://angular.io/) and comes with many significant performance, usability, and
feature improvements over the past versions.
See the [Building apps with Ionic 2](http://adamdbradley.github.io/building-with-ionic2) slides for a quick overview of Ionic 2.
See the [Building Apps with Ionic](https://adamdbradley.github.io/building-with-ionic2) slides for a quick
overview or watch our [Crash Course](https://youtu.be/O2WiI9QrS5s) video for a quick walkthrough on how to get
started using Ionic.
### Getting Started with Ionic 2
### Getting Started
To use Ionic 2 today, visit the [Ionic 2 Docs](http://ionicframework.com/docs/v2/). We would love any feedback you have or to know when you encounter issues, by filing an issue report on this repo.
Start a new project by following our quick [Getting Started guide](https://ionicframework.com/getting-started/).
We would love to hear from you! If you have any feedback or run into issues using our framework, please file
an [issue](https://github.com/ionic-team/ionic/issues/new) on this repository.
### Contributing to Ionic 2
### Contributing
See [CONTRIBUTING.md](https://github.com/driftyco/ionic/blob/master/.github/CONTRIBUTING.md)
Thanks for your interest in contributing! Read up on our guidelines for
and then look through our issues with a [help wanted](https://github.com/ionic-team/ionic/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22)
label.
### Ionic 2 Examples
### Examples
The [Ionic Conference App](https://github.com/driftyco/ionic-conference-app) is a full featured Ionic 2 app. It is the perfect starting point for learning and building your own app.
The [Ionic Conference App](https://github.com/ionic-team/ionic-conference-app) is a full featured Ionic app.
It is the perfect starting point for learning and building your own app.
### Ionic 1.x
### Ionic V1
The source code for Ionic 1.x has been moved to [driftyco/ionic-v1](https://github.com/driftyco/ionic-v1). Please file issues and pull requests related to Ionic 1.x at that repo. 1.x issues and PRs on this repo will be closed.
The source code for Ionic V1 has been moved to [ionic-team/ionic-v1](https://github.com/ionic-team/ionic-v1).
Please open any issues and pull requests related to Ionic V1 on that repository.
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.