javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

add unit tests

Browse Source
This commit is contained in:
Brian Soumakian
2017-04-30 15:24:09 -07:00
parent bc4a1cab66
commit 19a3b6616e
2 changed files with 127 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/util/module-loader.ts
View File

@ -74,23 +74,25 @@ export interface LoadedModule {
/**
* @hidden
*/
export function setupPreloadingImplementation(config: Config, deepLinkConfig: DeepLinkConfig, moduleLoader: ModuleLoader) {
export function setupPreloadingImplementation(config: Config, deepLinkConfig: DeepLinkConfig, moduleLoader: ModuleLoader): Promise<any> {
if (config.getBoolean('preloadModules') && deepLinkConfig && deepLinkConfig.links) {
const linksToLoad = deepLinkConfig.links.filter(link => !!link.loadChildren && link.priority !== 'off');
const linksToLoad = deepLinkConfig.links.filter(link => !!link.loadChildren && link.priority !== 'off');
// Load the high priority modules first
const highPriorityPromises = linksToLoad.filter(link => link.priority === 'high')
// Load the high priority modules first
const highPriorityPromises = linksToLoad.filter(link => link.priority === 'high')
.map(link => moduleLoader.load(link.loadChildren));
return Promise.all(highPriorityPromises).then(() => {
// Load the low priority modules after the high priority are done
const lowPriorityPromises = linksToLoad.filter(link => link.priority === 'low')
.map(link => moduleLoader.load(link.loadChildren));
Promise.all(highPriorityPromises).then(() => {
// Load the low priority modules after the high priority are done
const lowPriorityPromises = linksToLoad.filter(link => link.priority === 'low')
.map(link => moduleLoader.load(link.loadChildren));
return Promise.all(lowPriorityPromises);
}).catch(err => {
console.error(err.message);
});
}
return Promise.all(lowPriorityPromises);
}).catch(err => {
console.error(err.message);
});
} else {
return Promise.resolve();
}
}
/**

113
src/util/test/module-loader.spec.ts
View File

@ -1,6 +1,8 @@
import { ModuleLoader, LAZY_LOADED_TOKEN } from '../module-loader';
import { mockModuleLoader, mockNgModuleLoader } from '../mock-providers';
import { ModuleLoader, LAZY_LOADED_TOKEN, setupPreloadingImplementation } from '../module-loader';
import { mockModuleLoader, mockNgModuleLoader, mockConfig } from '../mock-providers';
import { NgModuleLoader } from '../ng-module-loader';
import { Config } from '../../config/config';
import { DeepLinkConfig } from '../../navigation/nav-util';
describe('module-loader', () => {
@ -115,12 +117,119 @@ describe('module-loader', () => {
});
describe('setupPreloadingImplementation', () => {
it('should return a promise', (done: Function) => {
let promise = setupPreloadingImplementation(config, null, moduleLoader);
promise.then((response) => {
done();
}).catch((err: Error) => {
fail(err);
done(err);
});
});
it('should not call ModuleLoader when preloading disabled', (done: Function) => {
spyOn(moduleLoader, 'load').and.returnValue(Promise.resolve());
config.set('preloadModules', false);
const deepLinkConfig: DeepLinkConfig = {
links: []
};
let promise = setupPreloadingImplementation(config, deepLinkConfig, moduleLoader);
promise.then((response) => {
expect(moduleLoader.load).not.toHaveBeenCalled();
done();
}).catch((err: Error) => {
fail(err);
done(err);
});
});
it('should not call ModuleLoader when deepLinkConfig missing', (done: Function) => {
spyOn(moduleLoader, 'load').and.returnValue(Promise.resolve());
config.set('preloadModules', true);
let promise = setupPreloadingImplementation(config, null, moduleLoader);
promise.then((response) => {
expect(moduleLoader.load).not.toHaveBeenCalled();
done();
}).catch((err: Error) => {
fail(err);
done(err);
});
});
it('should not call ModuleLoader when no low or high priority links', (done: Function) => {
spyOn(moduleLoader, 'load').and.returnValue(Promise.resolve());
config.set('preloadModules', true);
const deepLinkConfig: DeepLinkConfig = {
links: [{
loadChildren: 'offString',
priority: 'off'
}]
};
let promise = setupPreloadingImplementation(config, deepLinkConfig, moduleLoader);
promise.then((response) => {
expect(moduleLoader.load).not.toHaveBeenCalled();
done();
}).catch((err: Error) => {
fail(err);
done(err);
});
});
it('should call ModuleLoader when has low priority links', (done: Function) => {
spyOn(moduleLoader, 'load').and.returnValue(Promise.resolve());
config.set('preloadModules', true);
const deepLinkConfig: DeepLinkConfig = {
links: [{
loadChildren: 'lowString',
priority: 'low'
}]
};
let promise = setupPreloadingImplementation(config, deepLinkConfig, moduleLoader);
promise.then((response) => {
expect(moduleLoader.load).toHaveBeenCalledWith('lowString');
done();
}).catch((err: Error) => {
fail(err);
done(err);
});
});
it('should call ModuleLoader when has high priority links', (done: Function) => {
spyOn(moduleLoader, 'load').and.returnValue(Promise.resolve());
config.set('preloadModules', true);
const deepLinkConfig: DeepLinkConfig = {
links: [{
loadChildren: 'highString',
priority: 'high'
}]
};
let promise = setupPreloadingImplementation(config, deepLinkConfig, moduleLoader);
promise.then((response) => {
expect(moduleLoader.load).toHaveBeenCalledWith('highString');
done();
}).catch((err: Error) => {
fail(err);
done(err);
});
});
});
var moduleLoader: ModuleLoader;
var ngModuleLoader: NgModuleLoader;
var config: Config;
beforeEach(() => {
ngModuleLoader = mockNgModuleLoader();
moduleLoader = mockModuleLoader(ngModuleLoader);
config = mockConfig();
});
});