javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tabs): invalid component comparison (#11084)

Browse Source 
getComponent() returns a ViewController, so we must reference the
component property when checking against the active component
This commit is contained in:
Brian Soumakian
2017-04-17 09:46:11 -07:00
committed by Justin Willis
parent 786de79ad9
commit e423e082b6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/tabs/tabs.ts
View File

@@ -511,7 +511,7 @@ export class Tabs extends Ion implements AfterViewInit, RootNode {
});
} else {
getComponent(this._linker, tab.root).then(viewController => {
if (viewController !== active.component) {
if (viewController.component !== active.component) {
// Otherwise, if the page we're on is not our real root
// reset it to our default root type
return tab.setRoot(tab.root);