opensource/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2026-03-13 08:09:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

All: Fixes #12545: Handle missing script assets in HTML export (#14442)

Browse Source
This commit is contained in:
Kanishka..
2026-02-25 03:47:46 +05:30
committed by GitHub
parent c63eac19c9
commit cb12e4efb0
2 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
packages/htmlpack/index.test.ts
View File

@@ -1,4 +1,4 @@
import { exists, mkdir, readFile, remove } from 'fs-extra';
import { exists, mkdir, readFile, remove, writeFile } from 'fs-extra';
import { join } from 'path';
import htmlpack from '.';
@@ -32,4 +32,25 @@ describe('htmlpack/index', () => {
</body>
</html>`);
});
test('should not throw when a script asset is missing', async () => {
const inputFile = join(outputDirectory, 'input.html');
const outputFile = join(outputDirectory, 'output.html');
const inputHtml = `
<html>
<head>
<script type="application/javascript" src="missing-script.js"></script>
</head>
<body>
<p>Test</p>
</body>
</html>`;
await writeFile(inputFile, inputHtml, 'utf8');
await htmlpack(inputFile, outputFile);
const outputContent = await readFile(outputFile, 'utf8');
expect(outputContent).toContain('<p>Test</p>');
});
});

1
packages/htmlpack/packToString.ts
View File

@@ -132,6 +132,7 @@ const packToString = async (baseDir: string, inputFileText: string, fs: FileApi)
if (!src) return null;
const scriptFilePath = `${baseDir}/${src}`;
if (!await fs.exists(scriptFilePath)) return null;
let content = await fs.readFileText(scriptFilePath);
// There's no simple way to insert arbitrary content in <script> tags.