ci(lint): ensure linted results are pushed for build to pass (#25196)

This commit is contained in:
Liam DeBeasi
2022-04-26 22:43:20 +05:45
committed by GitHub
parent 70d278414e
commit b259ca6a1f
7 changed files with 11 additions and 14 deletions

View File

@ -18,3 +18,10 @@ runs:
run: npm run lint
shell: bash
working-directory: ./core
# Lint changes should be pushed
# to the branch before the branch
# is merge eligible.
- name: Check Lint Results
run: git diff --exit-code
shell: bash
working-directory: ./core

View File

@ -4,7 +4,6 @@ import { Component, Element, Host, Prop, h } from '@stencil/core';
import { getIonMode } from '../../global/ionic-global';
import { findIonContent, getScrollElement, printIonContentErrorMsg } from '../../utils/content';
import { handleFooterFade } from './footer.utils';
/**

View File

@ -4,7 +4,6 @@ import { Component, Element, Event, Host, Method, Prop, State, Watch, h, readTas
import { getIonMode } from '../../global/ionic-global';
import { findClosestIonContent, getScrollElement, printIonContentErrorMsg } from '../../utils/content';
@Component({
tag: 'ion-infinite-scroll',
styleUrl: 'infinite-scroll.scss',

View File

@ -10,9 +10,9 @@ export interface ModalOptions<T extends ComponentRef = ComponentRef> {
delegate?: FrameworkDelegate;
animated?: boolean;
/**
* If `true`, the modal can be swiped to dismiss. Only applies in iOS mode.
* @deprecated - To prevent modals from dismissing, use canDismiss instead.
*/
* If `true`, the modal can be swiped to dismiss. Only applies in iOS mode.
* @deprecated - To prevent modals from dismissing, use canDismiss instead.
*/
swipeToClose?: boolean;
canDismiss?: boolean | (() => Promise<boolean>);

View File

@ -1,7 +1,6 @@
import type { ComponentInterface, EventEmitter } from '@stencil/core';
import { Component, Element, Event, Host, Method, Prop, State, Watch, h, readTask, writeTask } from '@stencil/core';
import { getIonMode } from '../../global/ionic-global';
import type { Animation, Gesture, GestureDetail, RefresherEventDetail } from '../../interface';
import { getTimeGivenProgression } from '../../utils/animation/cubic-bezier';

View File

@ -1,7 +1,6 @@
import type { ComponentInterface, EventEmitter } from '@stencil/core';
import { Component, Element, Event, Host, Method, Prop, State, Watch, h } from '@stencil/core';
import { getIonMode } from '../../global/ionic-global';
import type { Gesture, GestureDetail, ItemReorderEventDetail } from '../../interface';
import { findClosestIonContent, getScrollElement } from '../../utils/content';

View File

@ -8,13 +8,7 @@ import type {
import { test as base } from '@playwright/test';
import { initPageEvents } from './page/event-spy';
import {
getSnapshotSettings,
goto as goToPage,
setIonViewport,
spyOnEvent,
waitForChanges,
} from './page/utils';
import { getSnapshotSettings, goto as goToPage, setIonViewport, spyOnEvent, waitForChanges } from './page/utils';
import type { E2EPage } from './playwright-declarations';
type CustomTestArgs = PlaywrightTestArgs &