javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(collectionRepeat): allow angular expressions properly

Browse Source
This commit is contained in:
Andy Joslin
2014-04-29 06:37:34 -06:00
parent 46291d6846
commit 94bcbf753b
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
js/angular/directive/collectionRepeat.js vendored
View File

@@ -46,7 +46,7 @@
* <div class="list">
* <div class="item my-item"
* collection-repeat="item in items"
* collection-item-width="100%"
* collection-item-width="'100%'"
* collection-item-height="getItemHeight(item, $index)"
* ng-style="{height: getItemHeight(item, $index)}">
* {% raw %}{{item}}{% endraw %}
@@ -80,8 +80,8 @@
* <ion-content>
* <div class="item item-avatar my-image-item"
* collection-repeat="image in images"
* collection-item-width="33%"
* collection-item-height="33%">
* collection-item-width="'33%'"
* collection-item-height="'33%'">
* <img ng-src="{{image.src}}">
* </div>
* </ion-content>
@@ -151,8 +151,8 @@ function($collectionRepeatManager, $collectionDataSource, $parse) {
} else if (!isVertical && !$attr.collectionItemWidth) {
throw new Error("collection-repeat expected attribute collection-item-width to be a an expression that returns a number.");
}
$attr.collectionItemHeight = $attr.collectionItemHeight || '100%';
$attr.collectionItemWidth = $attr.collectionItemWidth || '100%';
$attr.collectionItemHeight = $attr.collectionItemHeight || '"100%"';
$attr.collectionItemWidth = $attr.collectionItemWidth || '"100%"';
var heightParsed = $attr.collectionItemHeight ?
$parse($attr.collectionItemHeight) :