From 94bcbf753bdefd2b7ff5ac34d1eb594af5bfb02d Mon Sep 17 00:00:00 2001 From: Andy Joslin Date: Tue, 29 Apr 2014 06:37:34 -0600 Subject: [PATCH] fix(collectionRepeat): allow angular expressions properly --- js/angular/directive/collectionRepeat.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/js/angular/directive/collectionRepeat.js b/js/angular/directive/collectionRepeat.js index fc50a18c0d..9220f96e5f 100644 --- a/js/angular/directive/collectionRepeat.js +++ b/js/angular/directive/collectionRepeat.js @@ -46,7 +46,7 @@ *
*
* {% raw %}{{item}}{% endraw %} @@ -80,8 +80,8 @@ * *
+ * collection-item-width="'33%'" + * collection-item-height="'33%'"> * *
*
@@ -151,8 +151,8 @@ function($collectionRepeatManager, $collectionDataSource, $parse) { } else if (!isVertical && !$attr.collectionItemWidth) { throw new Error("collection-repeat expected attribute collection-item-width to be a an expression that returns a number."); } - $attr.collectionItemHeight = $attr.collectionItemHeight || '100%'; - $attr.collectionItemWidth = $attr.collectionItemWidth || '100%'; + $attr.collectionItemHeight = $attr.collectionItemHeight || '"100%"'; + $attr.collectionItemWidth = $attr.collectionItemWidth || '"100%"'; var heightParsed = $attr.collectionItemHeight ? $parse($attr.collectionItemHeight) :