javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

docs(icon): update docs to mention isActive being removed

Browse Source 
updates tests to no longer use is-active property
This commit is contained in:
Brandy Carney
2018-01-12 12:55:18 -05:00
parent 321ec2202d
commit 6d56d05cab
2 changed files with 32 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
BREAKING.md
View File

@@ -23,7 +23,6 @@ A list of the breaking changes introduced in Ionic Angular v4.
- [Select](#select)
- [Text/Typography](#text-typography)
- [Toolbar](#toolbar)
- [Sass](#sass)
## Dynamic Mode
@@ -278,6 +277,10 @@ If any `CSS` is being overridden for an icon it will need to change to override
}
```
### Property Removed
The `isActive` property has been removed. It only worked for `ios` icons previously. If you would like to switch between an outline and solid icon you should set it in the `name`, or `ios`/`md` attribute and then change it when needed.
## Input
The Sass variables were all renamed from having `$text-input` as the prefix to `$input`.
@@ -686,13 +689,3 @@ The properties have been renamed to the following:
| `end` | `slot="mode-end"` | Positions element to the `right` of the content in `ios` mode, and to the far right in `md` and `wp` mode. |
| `left` | `slot="start"` | Positions element to the `left` of all other elements in `LTR`, and to the `right` in `RTL`. |
| `right` | `slot="end"` | Positions element to the `right` of all other elements in `LTR`, and to the `left` in `RTL`. |
## Sass
### Deprecated Styles
Deprecated variables and styles have been removed.
- [e0a29db](https://github.com/ionic-team/ionic/commit/e0a29db)
- [07e4330](https://github.com/ionic-team/ionic/commit/07e4330)
- TODO continue to add what is removed here

47
packages/core/src/components/icon/test/basic/index.html
View File

@@ -29,10 +29,10 @@
</ion-item>
<ion-item>
<ion-icon name="home" is-active="true" slot="start"></ion-icon>
<ion-icon name="home" slot="start"></ion-icon>
<ion-label>
<code>
name="home" is-active="true"
name="home"
</code>
</ion-label>
</ion-item>
@@ -47,19 +47,10 @@
</ion-item>
<ion-item>
<ion-icon name="md-home" is-active="false" slot="start"></ion-icon>
<ion-icon name="md-home" slot="start"></ion-icon>
<ion-label>
<code>
name="md-home" is-active="false"
</code>
</ion-label>
</ion-item>
<ion-item>
<ion-icon name="ios-home" is-active="false" slot="start"></ion-icon>
<ion-label>
<code>
name="ios-home" is-active="false"
name="md-home"
</code>
</ion-label>
</ion-item>
@@ -73,6 +64,15 @@
</ion-label>
</ion-item>
<ion-item>
<ion-icon name="ios-home" slot="end"></ion-icon>
<ion-label>
<code>
name="ios-home"
</code>
</ion-label>
</ion-item>
<ion-item>
<ion-icon name="ios-star-outline" slot="start"></ion-icon>
<ion-label>
@@ -83,10 +83,10 @@
</ion-item>
<ion-item>
<ion-icon name="ios-star-outline" is-active="false" slot="start"></ion-icon>
<ion-icon name="IOS-STAR-OUTLINE" slot="end"></ion-icon>
<ion-label>
<code>
name="ios-star-outline" is-active="false"
name="IOS-STAR-OUTLINE"
</code>
</ion-label>
</ion-item>
@@ -119,19 +119,28 @@
</ion-item>
<ion-item>
<ion-icon ios="md-color-filter" md="ios-color-filter" slot="start"></ion-icon>
<ion-icon name="color-filter" slot="start"></ion-icon>
<ion-label>
<code>
ios="md-color-filter" md="ios-color-filter"
name="color-filter"
</code>
</ion-label>
</ion-item>
<ion-item>
<ion-icon ios="md-color-filter" md="ios-color-filter" is-active="false" slot="start"></ion-icon>
<ion-icon ios="ios-color-filter" md="md-color-filter" slot="start"></ion-icon>
<ion-label>
<code>
ios="md-color-filter" md="ios-color-filter" is-active="false"
ios="ios-color-filter" md="md-color-filter"
</code>
</ion-label>
</ion-item>
<ion-item>
<ion-icon ios="MD-COLOR-FILTER" md="IOS-COLOR-FILTER" slot="start"></ion-icon>
<ion-label>
<code>
ios="MD-COLOR-FILTER" md="IOS-COLOR-FILTER"
</code>
</ion-label>
</ion-item>