diff --git a/BREAKING.md b/BREAKING.md index b5c35f9e70..20c5edf1f6 100644 --- a/BREAKING.md +++ b/BREAKING.md @@ -23,7 +23,6 @@ A list of the breaking changes introduced in Ionic Angular v4. - [Select](#select) - [Text/Typography](#text-typography) - [Toolbar](#toolbar) -- [Sass](#sass) ## Dynamic Mode @@ -278,6 +277,10 @@ If any `CSS` is being overridden for an icon it will need to change to override } ``` +### Property Removed + +The `isActive` property has been removed. It only worked for `ios` icons previously. If you would like to switch between an outline and solid icon you should set it in the `name`, or `ios`/`md` attribute and then change it when needed. + ## Input The Sass variables were all renamed from having `$text-input` as the prefix to `$input`. @@ -686,13 +689,3 @@ The properties have been renamed to the following: | `end` | `slot="mode-end"` | Positions element to the `right` of the content in `ios` mode, and to the far right in `md` and `wp` mode. | | `left` | `slot="start"` | Positions element to the `left` of all other elements in `LTR`, and to the `right` in `RTL`. | | `right` | `slot="end"` | Positions element to the `right` of all other elements in `LTR`, and to the `left` in `RTL`. | - -## Sass - -### Deprecated Styles - -Deprecated variables and styles have been removed. - -- [e0a29db](https://github.com/ionic-team/ionic/commit/e0a29db) -- [07e4330](https://github.com/ionic-team/ionic/commit/07e4330) -- TODO continue to add what is removed here diff --git a/packages/core/src/components/icon/test/basic/index.html b/packages/core/src/components/icon/test/basic/index.html index f4f020b8b6..abeb5975af 100644 --- a/packages/core/src/components/icon/test/basic/index.html +++ b/packages/core/src/components/icon/test/basic/index.html @@ -29,10 +29,10 @@ - + - name="home" is-active="true" + name="home" @@ -47,19 +47,10 @@ - + - name="md-home" is-active="false" - - - - - - - - - name="ios-home" is-active="false" + name="md-home" @@ -73,6 +64,15 @@ + + + + + name="ios-home" + + + + @@ -83,10 +83,10 @@ - + - name="ios-star-outline" is-active="false" + name="IOS-STAR-OUTLINE" @@ -119,19 +119,28 @@ - + - ios="md-color-filter" md="ios-color-filter" + name="color-filter" - + - ios="md-color-filter" md="ios-color-filter" is-active="false" + ios="ios-color-filter" md="md-color-filter" + + + + + + + + + ios="MD-COLOR-FILTER" md="IOS-COLOR-FILTER"