fix(list): remove extra border in md inset list items (#25972)

fixes #25278
This commit is contained in:
Brandy Carney
2022-09-28 14:32:45 -04:00
committed by GitHub
parent 1858c87a59
commit 3eb3dd5afa
16 changed files with 62 additions and 12 deletions

View File

@@ -26,12 +26,12 @@
.list-md.list-inset ion-item:first-child {
--border-radius: #{$list-inset-md-border-radius $list-inset-md-border-radius 0 0};
--border-width: #{0 0 $item-md-border-bottom-width 0};
}
.list-md.list-inset ion-item:last-child {
--border-radius: #{0 0 $list-inset-md-border-radius, $list-inset-md-border-radius};
--border-width: 0;
--inner-border-width: 0;
}
.list-md.list-inset .item-interactive {

View File

@@ -1,10 +0,0 @@
import { newE2EPage } from '@stencil/core/testing';
test('list: inset', async () => {
const page = await newE2EPage({
url: '/src/components/list/test/inset?ionic:_testing=true',
});
const compare = await page.compareScreenshot();
expect(compare).toMatchScreenshot();
});

View File

@@ -25,7 +25,52 @@
<ion-content id="content" color="light">
<ion-list inset>
<ion-item>
<ion-label>Normal Input</ion-label>
<ion-label>Text Items</ion-label>
</ion-item>
<ion-item>
<ion-label>Text Items</ion-label>
</ion-item>
<ion-item>
<ion-label>Text Items</ion-label>
</ion-item>
</ion-list>
<ion-list inset>
<ion-list-header>
<ion-label>List Header</ion-label>
</ion-list-header>
<ion-item>
<ion-label>Text Items</ion-label>
</ion-item>
<ion-item>
<ion-label>Text Items</ion-label>
</ion-item>
<ion-item>
<ion-label>Text Items</ion-label>
</ion-item>
</ion-list>
<ion-list inset>
<ion-list-header>
<ion-label>List Header</ion-label>
</ion-list-header>
<ion-item>
<ion-label position="stacked">Stacked Inputs</ion-label>
<ion-input></ion-input>
</ion-item>
<ion-item>
<ion-label position="stacked">Stacked Inputs</ion-label>
<ion-input></ion-input>
</ion-item>
<ion-item>
<ion-label position="stacked">Stacked Inputs</ion-label>
<ion-input></ion-input>
</ion-item>
</ion-list>
<ion-list inset>
<ion-item>
<ion-label>Default Input</ion-label>
<ion-input></ion-input>
</ion-item>

View File

@@ -0,0 +1,15 @@
import { expect } from '@playwright/test';
import { test } from '@utils/test/playwright';
test.describe('list: inset', () => {
test.beforeEach(async ({ page }) => {
await page.goto('/src/components/list/test/inset');
});
test.describe('list: visual regression tests', () => {
test('should not have visual regressions', async ({ page }) => {
await page.setIonViewport();
expect(await page.screenshot()).toMatchSnapshot(`list-inset-diff-${page.getSnapshotSettings()}.png`);
});
});
});

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 242 KiB

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 85 KiB

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 158 KiB

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 242 KiB

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 87 KiB

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 160 KiB

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 209 KiB

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 71 KiB

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 138 KiB

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 210 KiB

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 72 KiB

View File

Binary file not shown.

After

Width:  |  Height:  |  Size: 136 KiB