diff --git a/core/src/components/list/list.md.scss b/core/src/components/list/list.md.scss index 83a7b96457..ccb58490a7 100644 --- a/core/src/components/list/list.md.scss +++ b/core/src/components/list/list.md.scss @@ -26,12 +26,12 @@ .list-md.list-inset ion-item:first-child { --border-radius: #{$list-inset-md-border-radius $list-inset-md-border-radius 0 0}; - --border-width: #{0 0 $item-md-border-bottom-width 0}; } .list-md.list-inset ion-item:last-child { --border-radius: #{0 0 $list-inset-md-border-radius, $list-inset-md-border-radius}; --border-width: 0; + --inner-border-width: 0; } .list-md.list-inset .item-interactive { diff --git a/core/src/components/list/test/inset/e2e.ts b/core/src/components/list/test/inset/e2e.ts deleted file mode 100644 index bfd2532c72..0000000000 --- a/core/src/components/list/test/inset/e2e.ts +++ /dev/null @@ -1,10 +0,0 @@ -import { newE2EPage } from '@stencil/core/testing'; - -test('list: inset', async () => { - const page = await newE2EPage({ - url: '/src/components/list/test/inset?ionic:_testing=true', - }); - - const compare = await page.compareScreenshot(); - expect(compare).toMatchScreenshot(); -}); diff --git a/core/src/components/list/test/inset/index.html b/core/src/components/list/test/inset/index.html index 1b8eab052d..cd9a582638 100644 --- a/core/src/components/list/test/inset/index.html +++ b/core/src/components/list/test/inset/index.html @@ -25,7 +25,52 @@ - Normal Input + Text Items + + + Text Items + + + Text Items + + + + + + List Header + + + Text Items + + + Text Items + + + Text Items + + + + + + List Header + + + Stacked Inputs + + + + Stacked Inputs + + + + Stacked Inputs + + + + + + + Default Input diff --git a/core/src/components/list/test/inset/list.e2e.ts b/core/src/components/list/test/inset/list.e2e.ts new file mode 100644 index 0000000000..c85f80d5f6 --- /dev/null +++ b/core/src/components/list/test/inset/list.e2e.ts @@ -0,0 +1,15 @@ +import { expect } from '@playwright/test'; +import { test } from '@utils/test/playwright'; + +test.describe('list: inset', () => { + test.beforeEach(async ({ page }) => { + await page.goto('/src/components/list/test/inset'); + }); + test.describe('list: visual regression tests', () => { + test('should not have visual regressions', async ({ page }) => { + await page.setIonViewport(); + + expect(await page.screenshot()).toMatchSnapshot(`list-inset-diff-${page.getSnapshotSettings()}.png`); + }); + }); +}); diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..78928fd8d4 Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..705b10f488 Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..02af745aa7 Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..073ef8dead Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..bb890c2ee3 Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..7835bf630c Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..66111f17e2 Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..b06bd6420b Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..edefb11688 Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..a6251b69de Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..8df2820117 Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..09eb4f1c32 Binary files /dev/null and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Safari-linux.png differ