javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(dark-mode): delete console logs

Browse Source
This commit is contained in:
Vasil Chimev
2019-09-30 18:36:54 +03:00
parent b32aaa80c3
commit 93fa7edd8e
7 changed files with 3 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tns-core-modules/application/application.ios.ts
View File

@@ -380,7 +380,9 @@ export function _start(entry?: string | NavigationEntry) {
}
setupRootViewCssClasses(controller, rootView);
traitCollectionColorAppearanceChanged(controller, rootView);
rootView.on(iosView.traitCollectionColorAppearanceChangedEvent, () => {
traitCollectionColorAppearanceChanged(controller, rootView);
});
iosApp.notifyAppStarted();
}
}
@@ -421,7 +423,6 @@ function getUserInterfaceStyleValue(userInterfaceStyle: number): "dark" | "light
}
}
// TODO: Rename to getRootViewController
function getViewController(rootView: View): UIViewController {
let viewController: UIViewController = rootView.viewController || rootView.ios;

4
tns-core-modules/ui/bottom-navigation/bottom-navigation.ios.ts
View File

@@ -82,11 +82,7 @@ class UITabBarControllerImpl extends UITabBarController {
public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void {
super.traitCollectionDidChange(previousTraitCollection);
const owner = this._owner.get();
// TODO:
// owner.notify({ eventName: "traitCollectionChanged", object: owner });
console.log("---> UITabBarControllerImpl.traitCollectionDidChange()");
if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) {
owner.notify({ eventName: iosView.traitCollectionColorAppearanceChangedEvent, object: owner });

4
tns-core-modules/ui/core/view/view.ios.ts
View File

@@ -1008,11 +1008,7 @@ export namespace ios {
public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void {
super.traitCollectionDidChange(previousTraitCollection);
const owner = this.owner.get();
// TODO:
// owner.notify({ eventName: "traitCollectionChanged", object: owner });
console.log("---> UILayoutViewController.traitCollectionDidChange()");
if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) {
owner.notify({ eventName: traitCollectionColorAppearanceChangedEvent, object: owner });

4
tns-core-modules/ui/frame/frame.ios.ts
View File

@@ -536,11 +536,7 @@ class UINavigationControllerImpl extends UINavigationController {
public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void {
super.traitCollectionDidChange(previousTraitCollection);
const owner = this._owner.get();
// TODO:
// owner.notify({ eventName: "traitCollectionChanged", object: owner });
console.log("---> UINavigationControllerImpl.traitCollectionDidChange()");
if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) {
owner.notify({ eventName: iosView.traitCollectionColorAppearanceChangedEvent, object: owner });

4
tns-core-modules/ui/page/page.ios.ts
View File

@@ -283,11 +283,7 @@ class UIViewControllerImpl extends UIViewController {
public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void {
super.traitCollectionDidChange(previousTraitCollection);
const owner = this._owner.get();
// TODO:
// owner.notify({ eventName: "traitCollectionChanged", object: owner });
console.log("---> UIViewControllerImpl.traitCollectionDidChange()");
if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) {
owner.notify({ eventName: iosView.traitCollectionColorAppearanceChangedEvent, object: owner });

4
tns-core-modules/ui/tab-view/tab-view.ios.ts
View File

@@ -74,11 +74,7 @@ class UITabBarControllerImpl extends UITabBarController {
public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void {
super.traitCollectionDidChange(previousTraitCollection);
const owner = this._owner.get();
// TODO:
// owner.notify({ eventName: "traitCollectionChanged", object: owner });
console.log("---> UITabBarControllerImpl.traitCollectionDidChange()");
if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) {
owner.notify({ eventName: iosView.traitCollectionColorAppearanceChangedEvent, object: owner });

4
tns-core-modules/ui/tabs/tabs.ios.ts
View File

@@ -193,11 +193,7 @@ class UIPageViewControllerImpl extends UIPageViewController {
public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void {
super.traitCollectionDidChange(previousTraitCollection);
const owner = this._owner.get();
// TODO:
// owner.notify({ eventName: "traitCollectionChanged", object: owner });
console.log("---> UIPageViewControllerImpl.traitCollectionDidChange()");
if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) {
owner.notify({ eventName: iosView.traitCollectionColorAppearanceChangedEvent, object: owner });