From 93fa7edd8efe53a118536683a51bfd020261aa3d Mon Sep 17 00:00:00 2001 From: Vasil Chimev Date: Mon, 30 Sep 2019 18:36:54 +0300 Subject: [PATCH] refactor(dark-mode): delete console logs --- tns-core-modules/application/application.ios.ts | 5 +++-- .../ui/bottom-navigation/bottom-navigation.ios.ts | 4 ---- tns-core-modules/ui/core/view/view.ios.ts | 4 ---- tns-core-modules/ui/frame/frame.ios.ts | 4 ---- tns-core-modules/ui/page/page.ios.ts | 4 ---- tns-core-modules/ui/tab-view/tab-view.ios.ts | 4 ---- tns-core-modules/ui/tabs/tabs.ios.ts | 4 ---- 7 files changed, 3 insertions(+), 26 deletions(-) diff --git a/tns-core-modules/application/application.ios.ts b/tns-core-modules/application/application.ios.ts index b42270057..9f2ea0b48 100644 --- a/tns-core-modules/application/application.ios.ts +++ b/tns-core-modules/application/application.ios.ts @@ -380,7 +380,9 @@ export function _start(entry?: string | NavigationEntry) { } setupRootViewCssClasses(controller, rootView); - traitCollectionColorAppearanceChanged(controller, rootView); + rootView.on(iosView.traitCollectionColorAppearanceChangedEvent, () => { + traitCollectionColorAppearanceChanged(controller, rootView); + }); iosApp.notifyAppStarted(); } } @@ -421,7 +423,6 @@ function getUserInterfaceStyleValue(userInterfaceStyle: number): "dark" | "light } } -// TODO: Rename to getRootViewController function getViewController(rootView: View): UIViewController { let viewController: UIViewController = rootView.viewController || rootView.ios; diff --git a/tns-core-modules/ui/bottom-navigation/bottom-navigation.ios.ts b/tns-core-modules/ui/bottom-navigation/bottom-navigation.ios.ts index 5a8445376..a118df00c 100644 --- a/tns-core-modules/ui/bottom-navigation/bottom-navigation.ios.ts +++ b/tns-core-modules/ui/bottom-navigation/bottom-navigation.ios.ts @@ -82,11 +82,7 @@ class UITabBarControllerImpl extends UITabBarController { public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void { super.traitCollectionDidChange(previousTraitCollection); - const owner = this._owner.get(); - // TODO: - // owner.notify({ eventName: "traitCollectionChanged", object: owner }); - console.log("---> UITabBarControllerImpl.traitCollectionDidChange()"); if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) { owner.notify({ eventName: iosView.traitCollectionColorAppearanceChangedEvent, object: owner }); diff --git a/tns-core-modules/ui/core/view/view.ios.ts b/tns-core-modules/ui/core/view/view.ios.ts index 6b7029456..edef8f7df 100644 --- a/tns-core-modules/ui/core/view/view.ios.ts +++ b/tns-core-modules/ui/core/view/view.ios.ts @@ -1008,11 +1008,7 @@ export namespace ios { public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void { super.traitCollectionDidChange(previousTraitCollection); - const owner = this.owner.get(); - // TODO: - // owner.notify({ eventName: "traitCollectionChanged", object: owner }); - console.log("---> UILayoutViewController.traitCollectionDidChange()"); if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) { owner.notify({ eventName: traitCollectionColorAppearanceChangedEvent, object: owner }); diff --git a/tns-core-modules/ui/frame/frame.ios.ts b/tns-core-modules/ui/frame/frame.ios.ts index 2563472bb..414f5c234 100644 --- a/tns-core-modules/ui/frame/frame.ios.ts +++ b/tns-core-modules/ui/frame/frame.ios.ts @@ -536,11 +536,7 @@ class UINavigationControllerImpl extends UINavigationController { public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void { super.traitCollectionDidChange(previousTraitCollection); - const owner = this._owner.get(); - // TODO: - // owner.notify({ eventName: "traitCollectionChanged", object: owner }); - console.log("---> UINavigationControllerImpl.traitCollectionDidChange()"); if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) { owner.notify({ eventName: iosView.traitCollectionColorAppearanceChangedEvent, object: owner }); diff --git a/tns-core-modules/ui/page/page.ios.ts b/tns-core-modules/ui/page/page.ios.ts index 8e75a15c6..9c84495e3 100644 --- a/tns-core-modules/ui/page/page.ios.ts +++ b/tns-core-modules/ui/page/page.ios.ts @@ -283,11 +283,7 @@ class UIViewControllerImpl extends UIViewController { public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void { super.traitCollectionDidChange(previousTraitCollection); - const owner = this._owner.get(); - // TODO: - // owner.notify({ eventName: "traitCollectionChanged", object: owner }); - console.log("---> UIViewControllerImpl.traitCollectionDidChange()"); if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) { owner.notify({ eventName: iosView.traitCollectionColorAppearanceChangedEvent, object: owner }); diff --git a/tns-core-modules/ui/tab-view/tab-view.ios.ts b/tns-core-modules/ui/tab-view/tab-view.ios.ts index c8e04d372..b0f1c7567 100644 --- a/tns-core-modules/ui/tab-view/tab-view.ios.ts +++ b/tns-core-modules/ui/tab-view/tab-view.ios.ts @@ -74,11 +74,7 @@ class UITabBarControllerImpl extends UITabBarController { public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void { super.traitCollectionDidChange(previousTraitCollection); - const owner = this._owner.get(); - // TODO: - // owner.notify({ eventName: "traitCollectionChanged", object: owner }); - console.log("---> UITabBarControllerImpl.traitCollectionDidChange()"); if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) { owner.notify({ eventName: iosView.traitCollectionColorAppearanceChangedEvent, object: owner }); diff --git a/tns-core-modules/ui/tabs/tabs.ios.ts b/tns-core-modules/ui/tabs/tabs.ios.ts index ee1c0501a..4d06da825 100644 --- a/tns-core-modules/ui/tabs/tabs.ios.ts +++ b/tns-core-modules/ui/tabs/tabs.ios.ts @@ -193,11 +193,7 @@ class UIPageViewControllerImpl extends UIPageViewController { public traitCollectionDidChange(previousTraitCollection: UITraitCollection): void { super.traitCollectionDidChange(previousTraitCollection); - const owner = this._owner.get(); - // TODO: - // owner.notify({ eventName: "traitCollectionChanged", object: owner }); - console.log("---> UIPageViewControllerImpl.traitCollectionDidChange()"); if (this.traitCollection.hasDifferentColorAppearanceComparedToTraitCollection(previousTraitCollection)) { owner.notify({ eventName: iosView.traitCollectionColorAppearanceChangedEvent, object: owner });