Fixes https://github.com/flutter/flutter/issues/136933
Fixes https://github.com/flutter/flutter/issues/132782
This cleans up some TODOs in the TableView and its tests after the stable release
- removes an assertion on the builder delegate bounds now that the super class handles the assertions
- refactors all of the golden file tests using PaintPattern, removing all of the golden files and enabling web testing
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.8 to 3.22.11.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.22.11 - 13 Dec 2023</h2>
<ul>
<li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li>
</ul>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.8 - 23 Nov 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
</ul>
<h2>2.22.7 - 16 Nov 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.4 - 20 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953">#1953</a></li>
<li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
<ul>
<li>All code scanning workflows should continue to succeed regardless of the warning.</li>
<li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
<li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959">this issue</a>.</li>
</ul>
</li>
</ul>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b374143c11"><code>b374143</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2034">#2034</a> from github/update-v3.22.11-64e61baea</li>
<li><a href="e2b5cc75ce"><code>e2b5cc7</code></a> Update changelog for v3.22.11</li>
<li><a href="64e61baeac"><code>64e61ba</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2006">#2006</a> from github/nickfyson/node-20</li>
<li><a href="c757f9f6de"><code>c757f9f</code></a> Apply suggestions from code review</li>
<li><a href="7898bc2041"><code>7898bc2</code></a> add pr check for node version consistency</li>
<li><a href="6b5b958063"><code>6b5b958</code></a> remove dedundant single quotes from node version strings</li>
<li><a href="ea1e72c669"><code>ea1e72c</code></a> Update .github/workflows/pr-checks.yml</li>
<li><a href="b974542e9f"><code>b974542</code></a> Merge branch 'main' into nickfyson/node-20</li>
<li><a href="b995212303"><code>b995212</code></a> Bump the actions group with 2 updates (<a href="https://redirect.github.com/github/codeql-action/issues/2024">#2024</a>)</li>
<li><a href="3c1878d8f9"><code>3c1878d</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2029">#2029</a> from github/mergeback/v2.22.10-to-main-305f6546</li>
<li>Additional commits viewable in <a href="407ffafae6...b374143c11">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
The definition of `JSArray` (and `JSPromise`) from `dart:js_interop` is changing to `JSArray<T>`, and our analyzer complains about our usage of it with default `T`s, blocking Dart SDK rolls.
This PR ignores the `always_specify_types` lint in the usages of `JSArray`, so this code passes analysis both with the current version of `dart:js_interop` and the next one.
## Issues
* Fixes https://github.com/flutter/flutter/issues/140076
* Cleanup https://github.com/flutter/flutter/issues/140095
⦠to `update-excerpts` tool
Need this tool to recognize `.java`, `.gradle`, and `.sh` files in order to complete [flutter/flutter#102679](https://github.com/flutter/flutter/issues/102679). The `README.md` for the `espresso` package contains code from `.java`, `.gradle`, and `.sh` files.
Support for `.m` files was requested by @tarrinneal.
Fixes the flaky path provider test.
Directories.listSync will sometimes not return the files in the directory (as discussed in https://github.com/flutter/flutter/issues/139378), but the files are there and (after letting it loop for quite a while and comparing to current flake) they always appear in the output of `Process.runSync('ls', ...)`.
The private `FlexHtmlElementView` widget that backs the `renderButton` method currently relies on internal web engine knowledge (a CSS selector) to work.
This PR reimplements that bit of the `FlexHtmlElementView` so it uses standard framework APIs, and removes its reliance in undocumented behavior.
## Issues
* Related to: https://github.com/flutter/engine/pull/48960
Part of fix for https://github.com/flutter/flutter/issues/138336 by bumping the Gradle version of all package example apps (plus `image_picker_android` plugin) to 7.6.3 from those that had a version below that to fix security vulnerability.
Also fixes a bug I found while using the `update-dependencies` packages tool command that caused it to not catch all of the `gradle-wrapper.properties` files when running with the `gradle` dependency + added a test for the fix.
Special-cases the handling of the error for "no registered handler" to return false, rather than throw, which better matches the behavior on other platforms.
Also updates Pigeon to 13 while I'm modifying the Pigeon definition.
Fixes https://github.com/flutter/flutter/issues/138142
The Linux implementation's method channel code was never simplified after the switch from a shared method channel to per-package method channels, so there was still cruft from the cross-platform channel API. This removes everything that's not used by the Linux native implementation, simplifying the protocol.
This also adds direct support for `launchUrl`, so we're no longer relying on the redirection from the deprecated `launch`.
Bumps androidx.fragment:fragment from 1.6.1 to 1.6.2.
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Updates examples in other packages (image_picker, camera) that use the deprecated `VideoPlayerController.network` to use the newer `VideoPlayerController.networkUrl` instead.
Fixes https://github.com/flutter/flutter/issues/127754
Fix bug with Pigeon Kotlin code generator not using the provided `errorClassName`.
fixes: https://github.com/flutter/flutter/issues/139031
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
This PR adds a new top level library `analysis.dart` that exposes
methods:
* `computeDelta`
* `computeAverage`
These were already added to DevTools in
https://github.com/flutter/devtools/pull/6918 and
https://github.com/flutter/devtools/pull/6920, respectively, but I think
it makes more sense to upstream this logic into `package:web_benchmarks`
so that other users of this package can take advantage of it.
As part of this PR, I have updated the README to give an example of how
to use the analysis features.
- Improves link targets to be more directly useful.
- Removes the unnecessary code sections showing an import, since the install tab already demonstrates that.
- Removes the no-longer-needed exemption from the excerpt requirement.
Part of https://github.com/flutter/flutter/issues/102679
The update-min-sdk command has been using explicitly ranges for the Dart
SDK, because that used to be required. Current versions of `pub` no
longer require that, and using `^` for Dart ranges is okay, so this
updates the tooling to use that format in the future.
Also removes the special casing that changed the upper bound from 3 to
4, since we have passed the point where we are generating upper bounds
less than 4 anyway.
To minimize churn, this doesn't update the existing pubspecs. We can
incrementally adopt this going forward as we roll dependencies forward.
Fixes https://github.com/flutter/flutter/issues/139806
Disables the `getExternalStorageDirectories (type: ...)` integration test in `path_provider_android` that is extremely flaky (particularly on AVDs running Android 34) to reduce the impact it has had on developer productivity.
Fixes https://github.com/flutter/flutter/issues/139378.
Some web browsers, such as Safari, may prevent URL launching if it is not triggered by a user action (e.g. a button click). Even if a user triggers a launch through a button click, if there is a delay due to awaiting a Future before the launch, the browser may still block it. This can be confusing if you don't know it. As https://github.com/flutter/flutter/issues/78524 suggested, should this be documented. Therefore, I added a few sentences to the `launchUrl`.
Please let me know if this documentation is too long or not the right place.
Fixes https://github.com/flutter/flutter/issues/78524
The previous push to this package didn't update its pub.dev score/docs [(error log)](https://pub.dev/packages/google_identity_services_web/versions/0.3.0/score/log.txt).
---
This PR attempts to re-publish the package, in the hope that it was a transient error in pub.
~~Maybe workaround for https://github.com/dart-lang/pub-dev/issues/7267~~
It's confirmed that this was a transient error in pub, this PR now just corrects the changelog of the previous change to list the correct dart/flutter versions that are required (and update the dependency definitions to match the rest of the repo)
---
[This pr](https://github.com/flutter/packages/pull/2664) added the ability to provide a list of `NavigatorObservers` to a `ShellRoute`. The equivalent was never added to `go_router_builder`, so this pr provides that functionality.
This is a workaround to [this issue](https://github.com/flutter/flutter/issues/112196) where navigator observers added to a `GoRouter` at the top level do not fire in `ShellRoutes`. With this change, you can provide `NavigatorObservers` directly to the `ShellRoute`
Fixed a typo in navigation.md:
```dart
context.go('/123, extra: 'abc');
```
to
```dart
context.go('/123', extra: 'abc');
```
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
The current link leads to an empty issues list.
- [NA] I listed at least one issue that this PR fixes in the description above.
- [NA] I added new tests to check the change I am making, or this PR is [test-exempt].
* Migrates package to use `package:web` so it can be compiled with WASM.
* **Breaking change**: Addresses API mismatches with the latest JS SDK changes.
* Adds some tests to client configuration objects.
(See CHANGELOG.md for a more thorough list of changes)
## Issues
* Fixes: https://github.com/flutter/flutter/issues/138202
* Fixes: https://github.com/flutter/flutter/issues/139167
* Part of: https://github.com/flutter/flutter/issues/139170
## Tests
* Ran unit/integration tests locally, added a couple more.
* Tested example apps with `flutter run`, both seem to work.
* Tested example apps with `--wasm`, both seem to work.
