Review Changes

This commit is contained in:
Greg Spencer
2018-08-21 08:49:41 -07:00
parent ab93a7c753
commit 4cf9b0e69c
3 changed files with 8 additions and 4 deletions

View File

@ -64,6 +64,12 @@ pub global run flutter_plugin_tools format --plugins package_name
pub global run flutter_plugin_tools analyze --plugins package_name
pub global run flutter_plugin_tools test --plugins package_name
```
* Check that the package can be published (but don't publish it until it has landed!):
```
cd packages/package_name; pub publish --dry-run
```
* `git commit -a -m "<your informative commit message>"`
* `git push origin <name_of_your_branch>`

View File

@ -1,7 +1,6 @@
# Flutter Packages
[![Build Status](https://travis-ci.org/flutter/packages.svg?branch=master)](https://travis-ci.org/flutter/packages)
[![Build Status](https://api.cirrus-ci.com/github/flutter/packages.svg)](https://cirrus-ci.com/github/flutter/packages)
[![Build Status](https://api.cirrus-ci.com/github/flutter/packages.svg)](https://cirrus-ci.com/github/flutter/packages/master)
This repo is a companion repo to the main [flutter repo](
https://github.com/flutter/flutter). It contains the source code for Flutter's

View File

@ -65,12 +65,11 @@ void main() async {
testImages[name] = await loadImage('$name.png');
}
testWidgets('Initialize the image cache', (WidgetTester tester) {
testWidgets('Initialize the image cache', (WidgetTester tester) async {
// We need to have a testWidgets test in order to initialize the image
// cache for the other tests, but they timeout if they too are testWidgets
// tests.
tester.pumpWidget(const Placeholder());
return new Future<Null>.value();
});
test('PaletteGenerator works on 1-pixel wide blue image', () async {