From 4cf9b0e69c1020795436b7b5f2a1a3b491771f2e Mon Sep 17 00:00:00 2001 From: Greg Spencer Date: Tue, 21 Aug 2018 08:49:41 -0700 Subject: [PATCH] Review Changes --- CONTRIBUTING.md | 6 ++++++ README.md | 3 +-- packages/palette_generator/test/palette_generator_test.dart | 3 +-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d841412318..c94643b08a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -64,6 +64,12 @@ pub global run flutter_plugin_tools format --plugins package_name pub global run flutter_plugin_tools analyze --plugins package_name pub global run flutter_plugin_tools test --plugins package_name ``` + * Check that the package can be published (but don't publish it until it has landed!): + +``` +cd packages/package_name; pub publish --dry-run +``` + * `git commit -a -m ""` * `git push origin ` diff --git a/README.md b/README.md index 53af8f16eb..64a5bf26a5 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,6 @@ # Flutter Packages -[![Build Status](https://travis-ci.org/flutter/packages.svg?branch=master)](https://travis-ci.org/flutter/packages) -[![Build Status](https://api.cirrus-ci.com/github/flutter/packages.svg)](https://cirrus-ci.com/github/flutter/packages) +[![Build Status](https://api.cirrus-ci.com/github/flutter/packages.svg)](https://cirrus-ci.com/github/flutter/packages/master) This repo is a companion repo to the main [flutter repo]( https://github.com/flutter/flutter). It contains the source code for Flutter's diff --git a/packages/palette_generator/test/palette_generator_test.dart b/packages/palette_generator/test/palette_generator_test.dart index c9af90240d..54d3ded22b 100644 --- a/packages/palette_generator/test/palette_generator_test.dart +++ b/packages/palette_generator/test/palette_generator_test.dart @@ -65,12 +65,11 @@ void main() async { testImages[name] = await loadImage('$name.png'); } - testWidgets('Initialize the image cache', (WidgetTester tester) { + testWidgets('Initialize the image cache', (WidgetTester tester) async { // We need to have a testWidgets test in order to initialize the image // cache for the other tests, but they timeout if they too are testWidgets // tests. tester.pumpWidget(const Placeholder()); - return new Future.value(); }); test('PaletteGenerator works on 1-pixel wide blue image', () async {