Fix compare() for subset check (S.A ⊆ T.A) (#4978)

This commit is contained in:
Niklas Hoefflin
2023-12-07 17:06:56 +01:00
committed by GitHub
parent 249ee1dc99
commit 92131de377
2 changed files with 5 additions and 11 deletions

View File

@ -50,7 +50,7 @@ public class GSet<T> {
* @return true if the current G-Set is a subset of the other, false otherwise
*/
public boolean compare(GSet<T> other) {
return elements.containsAll(other.elements);
return other.elements.containsAll(elements);
}
/**

View File

@ -32,20 +32,14 @@ class GSetTest {
void testCompare() {
GSet<String> gSet1 = new GSet<>();
GSet<String> gSet2 = new GSet<>();
gSet1.addElement("apple");
gSet1.addElement("orange");
gSet2.addElement("orange");
gSet2.addElement("banana");
assertFalse(gSet1.compare(gSet2));
GSet<String> gSet3 = new GSet<>();
gSet3.addElement("apple");
gSet3.addElement("orange");
assertTrue(gSet1.compare(gSet3));
gSet2.addElement("apple");
assertTrue(gSet1.compare(gSet2));
gSet2.addElement("banana");
assertTrue(gSet1.compare(gSet2));
}
@Test