From 92131de3774d6dc7be7662bd0a8a9c02704255d5 Mon Sep 17 00:00:00 2001 From: Niklas Hoefflin <122729995+itakurah@users.noreply.github.com> Date: Thu, 7 Dec 2023 17:06:56 +0100 Subject: [PATCH] =?UTF-8?q?Fix=20compare()=20for=20subset=20check=20(S.A?= =?UTF-8?q?=20=E2=8A=86=20T.A)=20(#4978)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../thealgorithms/datastructures/crdt/GSet.java | 2 +- .../datastructures/crdt/GSetTest.java | 14 ++++---------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/src/main/java/com/thealgorithms/datastructures/crdt/GSet.java b/src/main/java/com/thealgorithms/datastructures/crdt/GSet.java index 37873adc2..2b8959ed0 100644 --- a/src/main/java/com/thealgorithms/datastructures/crdt/GSet.java +++ b/src/main/java/com/thealgorithms/datastructures/crdt/GSet.java @@ -50,7 +50,7 @@ public class GSet { * @return true if the current G-Set is a subset of the other, false otherwise */ public boolean compare(GSet other) { - return elements.containsAll(other.elements); + return other.elements.containsAll(elements); } /** diff --git a/src/test/java/com/thealgorithms/datastructures/crdt/GSetTest.java b/src/test/java/com/thealgorithms/datastructures/crdt/GSetTest.java index 995882590..74250ede1 100644 --- a/src/test/java/com/thealgorithms/datastructures/crdt/GSetTest.java +++ b/src/test/java/com/thealgorithms/datastructures/crdt/GSetTest.java @@ -32,20 +32,14 @@ class GSetTest { void testCompare() { GSet gSet1 = new GSet<>(); GSet gSet2 = new GSet<>(); - gSet1.addElement("apple"); gSet1.addElement("orange"); - gSet2.addElement("orange"); - gSet2.addElement("banana"); - assertFalse(gSet1.compare(gSet2)); - - GSet gSet3 = new GSet<>(); - gSet3.addElement("apple"); - gSet3.addElement("orange"); - - assertTrue(gSet1.compare(gSet3)); + gSet2.addElement("apple"); + assertTrue(gSet1.compare(gSet2)); + gSet2.addElement("banana"); + assertTrue(gSet1.compare(gSet2)); } @Test