fix: add appropriate printable text for Result returned from delete_tokenized_data() (#1369)

This commit is contained in:
Hrithikesh
2023-07-04 13:10:03 +05:30
committed by GitHub
parent ee7cdef107
commit cebe993660

View File

@ -448,10 +448,10 @@ impl Vault {
if resp == "Ok" { if resp == "Ok" {
logger::info!("Card From locker deleted Successfully") logger::info!("Card From locker deleted Successfully")
} else { } else {
logger::error!("Error: Deleting Card From Locker : {}", resp) logger::error!("Error: Deleting Card From Locker : {:?}", resp)
} }
} }
Err(err) => logger::error!("Err: Deleting Card From Locker : {}", err), Err(err) => logger::error!("Err: Deleting Card From Locker : {:?}", err),
} }
} }
} }
@ -655,7 +655,9 @@ pub async fn delete_tokenized_data(
service_name: VAULT_SERVICE_NAME.to_string(), service_name: VAULT_SERVICE_NAME.to_string(),
}; };
let payload = serde_json::to_string(&payload_to_be_encrypted) let payload = serde_json::to_string(&payload_to_be_encrypted)
.map_err(|_x| errors::ApiErrorResponse::InternalServerError)?; .into_report()
.change_context(errors::ApiErrorResponse::InternalServerError)
.attach_printable("Error serializing api::DeleteTokenizeByTokenRequest")?;
let (public_key, _private_key) = get_locker_jwe_keys(&state.kms_secrets) let (public_key, _private_key) = get_locker_jwe_keys(&state.kms_secrets)
.await .await
@ -679,7 +681,8 @@ pub async fn delete_tokenized_data(
.attach_printable("Making Delete Tokenized request failed")?; .attach_printable("Making Delete Tokenized request failed")?;
let response = services::call_connector_api(state, request) let response = services::call_connector_api(state, request)
.await .await
.change_context(errors::ApiErrorResponse::InternalServerError)?; .change_context(errors::ApiErrorResponse::InternalServerError)
.attach_printable("Error while making /tokenize/delete/token call to the locker")?;
match response { match response {
Ok(r) => { Ok(r) => {
let delete_response = std::str::from_utf8(&r.response) let delete_response = std::str::from_utf8(&r.response)
@ -771,14 +774,14 @@ pub async fn start_tokenize_data_workflow(
.finish_with_status(db, format!("COMPLETED_BY_PT_{id}")) .finish_with_status(db, format!("COMPLETED_BY_PT_{id}"))
.await?; .await?;
} else { } else {
logger::error!("Error: Deleting Card From Locker : {}", resp); logger::error!("Error: Deleting Card From Locker : {:?}", resp);
retry_delete_tokenize(db, &delete_tokenize_data.pm, tokenize_tracker.to_owned()) retry_delete_tokenize(db, &delete_tokenize_data.pm, tokenize_tracker.to_owned())
.await?; .await?;
scheduler_metrics::RETRIED_DELETE_DATA_COUNT.add(&metrics::CONTEXT, 1, &[]); scheduler_metrics::RETRIED_DELETE_DATA_COUNT.add(&metrics::CONTEXT, 1, &[]);
} }
} }
Err(err) => { Err(err) => {
logger::error!("Err: Deleting Card From Locker : {}", err); logger::error!("Err: Deleting Card From Locker : {:?}", err);
retry_delete_tokenize(db, &delete_tokenize_data.pm, tokenize_tracker.to_owned()) retry_delete_tokenize(db, &delete_tokenize_data.pm, tokenize_tracker.to_owned())
.await?; .await?;
scheduler_metrics::RETRIED_DELETE_DATA_COUNT.add(&metrics::CONTEXT, 1, &[]); scheduler_metrics::RETRIED_DELETE_DATA_COUNT.add(&metrics::CONTEXT, 1, &[]);