From cebe993660c1afbbd0c442c0811f215286ccff8d Mon Sep 17 00:00:00 2001 From: Hrithikesh <61539176+hrithikesh026@users.noreply.github.com> Date: Tue, 4 Jul 2023 13:10:03 +0530 Subject: [PATCH] fix: add appropriate printable text for Result returned from delete_tokenized_data() (#1369) --- crates/router/src/core/payment_methods/vault.rs | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/crates/router/src/core/payment_methods/vault.rs b/crates/router/src/core/payment_methods/vault.rs index 3ef6e89e05..50eee658b3 100644 --- a/crates/router/src/core/payment_methods/vault.rs +++ b/crates/router/src/core/payment_methods/vault.rs @@ -448,10 +448,10 @@ impl Vault { if resp == "Ok" { logger::info!("Card From locker deleted Successfully") } else { - logger::error!("Error: Deleting Card From Locker : {}", resp) + logger::error!("Error: Deleting Card From Locker : {:?}", resp) } } - Err(err) => logger::error!("Err: Deleting Card From Locker : {}", err), + Err(err) => logger::error!("Err: Deleting Card From Locker : {:?}", err), } } } @@ -655,7 +655,9 @@ pub async fn delete_tokenized_data( service_name: VAULT_SERVICE_NAME.to_string(), }; let payload = serde_json::to_string(&payload_to_be_encrypted) - .map_err(|_x| errors::ApiErrorResponse::InternalServerError)?; + .into_report() + .change_context(errors::ApiErrorResponse::InternalServerError) + .attach_printable("Error serializing api::DeleteTokenizeByTokenRequest")?; let (public_key, _private_key) = get_locker_jwe_keys(&state.kms_secrets) .await @@ -679,7 +681,8 @@ pub async fn delete_tokenized_data( .attach_printable("Making Delete Tokenized request failed")?; let response = services::call_connector_api(state, request) .await - .change_context(errors::ApiErrorResponse::InternalServerError)?; + .change_context(errors::ApiErrorResponse::InternalServerError) + .attach_printable("Error while making /tokenize/delete/token call to the locker")?; match response { Ok(r) => { let delete_response = std::str::from_utf8(&r.response) @@ -771,14 +774,14 @@ pub async fn start_tokenize_data_workflow( .finish_with_status(db, format!("COMPLETED_BY_PT_{id}")) .await?; } else { - logger::error!("Error: Deleting Card From Locker : {}", resp); + logger::error!("Error: Deleting Card From Locker : {:?}", resp); retry_delete_tokenize(db, &delete_tokenize_data.pm, tokenize_tracker.to_owned()) .await?; scheduler_metrics::RETRIED_DELETE_DATA_COUNT.add(&metrics::CONTEXT, 1, &[]); } } Err(err) => { - logger::error!("Err: Deleting Card From Locker : {}", err); + logger::error!("Err: Deleting Card From Locker : {:?}", err); retry_delete_tokenize(db, &delete_tokenize_data.pm, tokenize_tracker.to_owned()) .await?; scheduler_metrics::RETRIED_DELETE_DATA_COUNT.add(&metrics::CONTEXT, 1, &[]);