python/mysqlclient
1
0
Fork 0
mirror of https://github.com/PyMySQL/mysqlclient.git synced 2025-08-14 18:12:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix leak of connection->converter. (#182)

Browse Source
This commit is contained in:
INADA Naoki
2017-06-16 16:58:59 +09:00
committed by GitHub
parent 354dcb59e2
commit f41e651e28
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
_mysql.c
View File

@ -495,13 +495,10 @@ static int _mysql_ResultObject_traverse(
return 0;
}
static int _mysql_ResultObject_clear(
_mysql_ResultObject *self)
static int _mysql_ResultObject_clear(_mysql_ResultObject *self)
{
Py_XDECREF(self->converter);
self->converter = NULL;
Py_XDECREF(self->conn);
self->conn = NULL;
Py_CLEAR(self->converter);
Py_CLEAR(self->conn);
return 0;
}
@ -796,8 +793,7 @@ _mysql_ConnectionObject_close(
return NULL;
}
_mysql_ConnectionObject_clear(self);
Py_INCREF(Py_None);
return Py_None;
Py_RETURN_NONE;
}
static char _mysql_ConnectionObject_affected_rows__doc__ [] =
@ -2162,6 +2158,7 @@ _mysql_ConnectionObject_dealloc(
mysql_close(&(self->connection));
self->open = 0;
}
Py_CLEAR(self->converter);
MyFree(self);
}