python/mysqlclient
1
0
Fork 0
mirror of https://github.com/PyMySQL/mysqlclient.git synced 2026-03-13 08:00:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix a reference leak in store_result and use_result if result object initialization fails. (#298)

Browse Source
This commit is contained in:
Benjamin Peterson
2018-12-04 21:31:33 -06:00
committed by INADA Naoki
parent c2e5ff7bd3
commit 41581254f8
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
MySQLdb/_mysql.c
View File

@@ -1865,8 +1865,10 @@ _mysql_ConnectionObject_store_result(
if (!kwarglist) goto error;
r = MyAlloc(_mysql_ResultObject, _mysql_ResultObject_Type);
if (!r) goto error;
if (_mysql_ResultObject_Initialize(r, arglist, kwarglist))
if (_mysql_ResultObject_Initialize(r, arglist, kwarglist)) {
Py_DECREF(r);
goto error;
}
result = (PyObject *) r;
if (!(r->result)) {
Py_DECREF(result);
@@ -1924,9 +1926,11 @@ _mysql_ConnectionObject_use_result(
if (!kwarglist) goto error;
r = MyAlloc(_mysql_ResultObject, _mysql_ResultObject_Type);
if (!r) goto error;
result = (PyObject *) r;
if (_mysql_ResultObject_Initialize(r, arglist, kwarglist))
if (_mysql_ResultObject_Initialize(r, arglist, kwarglist)) {
Py_DECREF(r);
goto error;
}
result = (PyObject *) r;
if (!(r->result)) {
Py_DECREF(result);
Py_INCREF(Py_None);