Commit Graph

9265 Commits

Author SHA1 Message Date
Yuan Chong
baee44c97b OAuth API Response with 20x status should be in normal
Hello,

I used **Yii2 authclient** to build a Github OAuth (2.0) client, and performed a POST call to create a Github repository hook. But I got this exception:

```
exception 'yii\authclient\InvalidResponseException' with message '
Request failed with code: 201, message:
{
	"url": "https://api.github.com/repos/ychongsaytc/example/hooks/1000000",
	"test_url": "https://api.github.com/repos/ychongsaytc/example/hooks/1000000/test",
	"id": 1000000,
	"name": "web",
	"active": true,
	"events": ["push"],
	"config": {
		"url": "https://example.com/payload",
		"content_type": "form",
		"secret": null
	},
	"last_response": {
		"code": null,
		"status": "unused",
		"message": null
	},
	"updated_at": "2014-09-14T03:02:55Z",
	"created_at": "2014-09-14T03:02:55Z"
}
' in /home/ubuntu/public_html/live/vendor/yiisoft/yii2-authclient/BaseOAuth.php:206
```

I think a successful API call is not always exactly return **200** status, like **Create a hook** API of Github: https://developer.github.com/v3/repos/hooks/

It will return `201 Created` if hook was successfully created.

In my opinion, is status code starts with **20** in normal scenario?

close #5011
2014-09-14 12:59:11 +02:00
Alexander Makarov
e6aad90840 Edited Russian translation of Service Locator guide 2014-09-14 13:30:40 +04:00
Alexander Makarov
7357d4db43 Edited Russian translation of Properties guide 2014-09-14 12:52:50 +04:00
Alexander Makarov
806cb1ecf1 Edited Russian translation of Configurations guide 2014-09-14 02:32:02 +04:00
Alexander Makarov
254e37042c Edited Russian translation of Components guide 2014-09-14 02:08:15 +04:00
Alexander Makarov
0675590c04 Fixed errata 2014-09-14 01:50:04 +04:00
Alexander Makarov
ece8f64196 Edited Russian translation of Behaviors 2014-09-14 01:49:04 +04:00
Qiang Xue
9bf4bcbfbb Merge pull request #5009 from tebazil/patch-1
Update structure-views.md
2014-09-13 13:02:05 -04:00
Vasiliy Baukin
9079179f50 Update structure-views.md
Above/below code reference fix
2014-09-13 16:02:48 +04:00
Qiang Xue
b9c97ff2aa Fixes #4938: When yii\db\ActiveQuery is used to build sub-queries, its WHERE clause is not correctly generated 2014-09-12 16:46:12 -04:00
Qiang Xue
91e41b0470 Fixes #5001: yii\rest\CreateAction, yii\rest\UpdateAction and yii\rest\DeleteAction should throw 500 error if the model operation returns false without validation errors 2014-09-12 13:49:34 -04:00
Qiang Xue
af4a4d9276 Merge pull request #5002 from willaustin/patch-1
Typo in concept-behaviors.md
2014-09-12 12:49:59 -04:00
William Austin
2635efd7be Typo in concept-behaviors.md
The method 'bar()' does not exist in this context. I believe it should be 'foo().'
2014-09-12 10:37:03 -06:00
Alexander Makarov
9414953f21 Merge pull request #4998 from creocoder/aliases-to-bootstrap
Additional fixes for #4993
2014-09-12 15:18:56 +04:00
Alexander Kochetov
f362f5b25b Additional fixes 2014-09-12 15:16:25 +04:00
Qiang Xue
d1bfc01f72 reverted a previous change . 2014-09-12 06:42:54 -04:00
Alexander Makarov
46af48e598 Merge pull request #4995 from mikehaertl/master
[ci skip] Update docs for CheckboxColumn::$checkboxOptions
2014-09-12 13:06:49 +04:00
Michael Härtl
e28edb3ed1 Improve docs for CheckboxColumn::$checkboxOptions 2014-09-12 11:01:00 +02:00
Alexander Makarov
2938cf727e Merge pull request #4993 from creocoder/aliases-to-bootstrap
Adv template `aliases.php` => `bootstrap.php` (common + specific for apps)
2014-09-12 12:47:23 +04:00
Alexander Makarov
24b74e2b18 Merge pull request #4992 from Skysplit/pl-messages
Update polish translation [skip ci]
2014-09-12 12:17:20 +04:00
Alexander Kochetov
5190fbfe37 aliases.php renamed to bootstrap.php (introduced to specific applications too) 2014-09-12 11:29:48 +04:00
Tomek Romik
4b940c5b41 Added "other" rules to polish translations 2014-09-12 07:12:28 +02:00
Alexander Makarov
fe71bc38af Edited Russian guide sections about caching and autoloading 2014-09-12 02:34:33 +04:00
Alexander Makarov
229b7581ee Renamed translations → translation-workflow.md 2014-09-12 00:41:58 +04:00
Alexander Makarov
d752ca1849 Updated Russian framework messages 2014-09-12 00:34:28 +04:00
Tomek Romik
dbf63a45af Update polish translation 2014-09-11 22:22:25 +02:00
Qiang Xue
6db5126515 send accept header for debug toolbar. [skip ci] 2014-09-11 12:43:52 -04:00
Qiang Xue
ee3fc7f866 Fixes #4986 2014-09-11 12:09:10 -04:00
Carsten Brandt
e4446ccf51 removed old test 2014-09-11 16:28:32 +02:00
Paul Klimov
e060f3ad96 Merge pull request #4982 from diiimonn/feature
fix authchoice.js
2014-09-11 11:07:47 +03:00
Qiang Xue
de63a46d82 Fixes #4984. 2014-09-10 21:57:02 -04:00
Qiang Xue
b604bc56ff updated UPGRADE [skip ci] 2014-09-10 21:43:33 -04:00
Carsten Brandt
9655e3bd94 CHANGELOG 2014-09-11 02:09:21 +02:00
tvdavid
cc10725c2b Add support for elasticsearch delete by query
close #4487
2014-09-11 02:04:42 +02:00
tvdavid
259b8c901f Add support for elasticsearch suggestions
close #4505
2014-09-11 01:48:25 +02:00
Carsten Brandt
3fb680964c add aggregation, stats and suggester to elasticsearch
fixes #4452, close #4452
2014-09-11 01:26:15 +02:00
Carsten Brandt
9dfca990a0 updated german translation 2014-09-10 22:11:43 +02:00
Carsten Brandt
b5af2f6ab3 fixed size format plural rule to not format number itself
This fix ensures the format configured in the formatter class is used in the message instead
of the default ICU format.

fixes #4960
2014-09-10 21:53:29 +02:00
Qiang Xue
2150fa3239 Fixes #4970: joinWith() called by a relation was ignored by yii\db\ActiveQuery 2014-09-10 15:00:15 -04:00
Stephen Seliuk
70ed5d5c01 Test for fix 2014-09-10 14:49:12 -04:00
Stephen Seliuk
35b54345b5 Handling $query->joinWith called inside of other $query->joinWith within Closure (called inside Closure). Ex.: ``php $query->joinWith( [ 'rel1' => function($query) { $query->joinWith( [ 'rel2' => function($query) { // ... } ] ); } ] ); `` 2014-09-10 14:49:11 -04:00
Qiang Xue
b835422479 Fixes #4897: Added `yii\helpers\FileHelper::mimeMagicFile 2014-09-10 14:17:16 -04:00
Alexander Makarov
353cf1b345 Merge pull request #4981 from SDKiller/patch-2
Updated phpdoc for \yii\widgets\DetailView [ckip ci]
2014-09-10 22:10:23 +04:00
Qiang Xue
44b5e8ef60 Fixes #4954: MSSQL column comments are not retrieved correctly 2014-09-10 13:44:04 -04:00
Serge Postrash
286e8efe9f Updated phpdoc for \yii\widgets\DetailView [ckip ci]
This widget usage is not only restricted with `Model` or associative array (see its `normalizeAttributes()` method)
2014-09-10 21:39:07 +04:00
dima
97b4c505ad fix authchoice.js 2014-09-10 20:36:35 +03:00
Carsten Brandt
c1d98722aa Update tutorial-i18n.md
typod
2014-09-10 19:29:30 +02:00
Qiang Xue
0e4da43838 Merge pull request #3906 from cebe/Erik-r-2359-formatter-refactored
[WIP] formatter refactored
2014-09-10 13:27:03 -04:00
Carsten Brandt
2b38d6ab33 Merge branch 'master' into Erik-r-2359-formatter-refactored
* master: (22 commits)
  Fixes #4971: Fixed hardcoded table names in `viaTable` expression in model generator
  Fixed test break.
  Fixes #4955: Replaced callbacks with events for `ActiveForm`
  Fix brackets
  Rename `\yii\web\User` component param for consistency
  Html::button() type is `button` by default
  Fix bug in Estonian translation
  Typo fixed inside \yii\rest\CreateAction
  Fixed test break.
  Fixed test case.
  note about validation rules order
  Return a fixtures cleanup in case of a failing test
  Update finnish translation
  skip fixture controller test on HHVM
  Make unit tests cleanup a DB after finish
  Fixes #4945: Added `yii\test\ArrayFixture`
  added array fixture class
  minor doc adjustment [skip ci]
  Fixes #4948. Thanks, @johan162
  Fixes #4947
  ...

Conflicts:
	framework/UPGRADE.md
2014-09-10 19:26:04 +02:00
Carsten Brandt
0723f409ab finished the first structure of the guide on formatting 2014-09-10 19:24:14 +02:00