Commit Graph

6877 Commits

Author SHA1 Message Date
armab
a324b26c7f BaseMailer: strip <style> content from TextBody fix
If ```$htmlLayout``` contains <style> tags with CSS rules,
strip_tags here: https://github.com/yiisoft/yii2/blob/master/framework/mail/BaseMailer.php#L189
won't clean those CSS rules.

Actual html: 
```html
<html>
    <head>
        <style>
            .text-secondary {color: #93959A;}
            [...]
            [Other CSS rules]
            [...]
        </style>
    </head>
    <body>
        <div>Some content</div>
    </body>
</html>
```

Will look this way in TEXT version of Email: 
```
.text-secondary {color: #93959A;}
[...]
[Other CSS rules]
[...]
Some content
```

--------------

If TEXT version of Email differs drastically from visible content of HTML version,
it can be result that some penalty points will apply to such mails: 
http://wiki.apache.org/spamassassin/Rules/MPART_ALT_DIFF_COUNT


Since it's default behaviour for both yii2-app-advanced and yii2-app-basic (where stripped from tags html used for TextBody),
I believe people will stumble in this for sure, without even knowing that their emails can be penalized.


You can reproduce it by placing CSS styles in email view or layout
and test it here: http://www.mail-tester.com/ (SpamAssassin section).
2014-05-02 17:01:03 +03:00
Alexander Makarov
d43f1c1b3c Update git-workflow.md 2014-05-02 15:55:59 +04:00
Alexander Makarov
a4c644d3a3 Fixes #3325: fixed generated markup for conditional comments
No changelog line since feature was introduced after beta
2014-05-02 15:29:26 +04:00
Alexander Makarov
009238156e Fixed slashed to match guide 2014-05-02 14:47:19 +04:00
Alexander Makarov
7f74e95320 Merge pull request #3322 from vova07/rbac-docs-fix
[skip ci] Сheck if user is authenticated in RBAC UserGroupRule.
2014-05-02 12:30:35 +04:00
vova07
2098c6243f Сheck if user is authenticated in RBAC UserGroupRule. 2014-05-02 11:11:36 +03:00
Qiang Xue
0880656be3 Fixes #3311. 2014-05-01 22:19:48 -04:00
Qiang Xue
9cdfb35fa3 Fixes #3312. 2014-05-01 22:16:40 -04:00
Qiang Xue
ad31cf6fd2 Finished configuration chapter. 2014-05-01 22:08:16 -04:00
Alexander Makarov
dacd11eaef Merge pull request #3318 from netyum/patch-1
[ci skip] Update document for BaseYii::setAlias method.
2014-05-02 01:52:54 +04:00
Yeung Song
9dcdbd5e30 update document for BaseYii::setAlias method.
update
2014-05-02 05:42:30 +08:00
Qiang Xue
b48cc01510 minor doc update. [skip ci] 2014-05-01 12:33:40 -04:00
Carsten Brandt
5d002f0889 typos
[ci skip]
2014-05-01 15:09:02 +02:00
Alexander Makarov
a5bf2834ad Fixes #3315: added new PHP features reading list to upgrading from 1.1 guide 2014-05-01 16:28:10 +04:00
Qiang Xue
ab7c5440ec typo [skip ci] 2014-04-30 21:48:39 -04:00
Qiang Xue
aa5ee3f943 updated outdated read me. 2014-04-30 21:48:02 -04:00
Qiang Xue
48c7e328c9 Finished behavior guide [skip ci] 2014-04-30 21:21:53 -04:00
Carsten Brandt
2e892c42e4 added docs about build automation tool
fixes #2852
2014-04-30 23:44:56 +02:00
Carsten Brandt
d239029df9 removed obsolete internal docs 2014-04-30 23:36:13 +02:00
Carsten Brandt
6c4046da49 defer loading of search index in api doc
fixes #3289
2014-04-30 23:18:36 +02:00
Carsten Brandt
cb8100d76f improved apidoc property detection
do not allow empty property name
fixes #3297
2014-04-30 22:04:22 +02:00
Qiang Xue
353cf8919a Merge pull request #3304 from Ragazzo/migration_command_docs_added
migration docs adjusted
2014-04-30 09:42:51 -04:00
Mark
bf28d8290b note in migration docs about additional custom options 2014-04-30 17:29:27 +04:00
Qiang Xue
5b6e79dc14 Fixes #3298: Supported configuring View::theme using a class name 2014-04-30 08:36:28 -04:00
Carsten Brandt
f1742e5b7b typo 2014-04-30 14:01:00 +02:00
Carsten Brandt
c144d8b7ba added docs about array attributes to the guide
fixes #3302
2014-04-30 13:53:05 +02:00
Alexander Makarov
6bad24365b Fixed arguments order in RBAC guide 2014-04-30 14:09:58 +04:00
Alexander Makarov
1530cdb5a7 Changed suggested naming for guide translations to use - 2014-04-30 14:00:56 +04:00
Alexander Makarov
cda44475d9 Fixed wording in upgrade guide 2014-04-30 03:55:50 +04:00
Alexander Makarov
9c9ff87182 Added docs about translation command 2014-04-30 03:55:38 +04:00
Alexander Makarov
3b29001ef5 #2677: added 1.1 port of translations command 2014-04-30 03:29:42 +04:00
Qiang Xue
7d31cba3a8 Finished event guide. [skip ci] 2014-04-29 19:03:06 -04:00
Qiang Xue
d954618796 Added support to insert an event handler at the beginning of class-level event handler queue 2014-04-29 18:31:54 -04:00
Alexander Makarov
bb145f5067 Fixes #3179: removed duplicate validation rules from User model in advanced app, removed User::create() 2014-04-30 02:16:28 +04:00
Carsten Brandt
9b69e2d1d4 Merge pull request #3293 from suralc/patch-4
Fix #3265
2014-04-29 23:53:56 +02:00
Alexander Makarov
340278b59c Fixes #3183: fixed regression after #3175 2014-04-30 01:31:11 +04:00
Qiang Xue
468e4191e0 events guide wip [skip ci] 2014-04-29 16:39:37 -04:00
suralc
1ad5c4c3fe Only valid php classes should pass validation 2014-04-29 20:28:57 +02:00
Qiang Xue
f629faf9bc minor improvement to doc. [skip ci] 2014-04-29 13:37:54 -04:00
Qiang Xue
f34fa1ed8a Merge branch 'master' of git://github.com/yiisoft/yii2 2014-04-29 13:18:57 -04:00
Qiang Xue
5b8cf206b9 guide wip [skip ci] 2014-04-29 13:18:50 -04:00
Alexander Makarov
d1558770d9 Added issue number to bootstrap/preload change 2014-04-29 20:38:03 +04:00
Alexander Makarov
b39effda2e Fixes #3238: added drawings to RBAC docs 2014-04-29 20:01:22 +04:00
Alexander Makarov
a620342315 Adjusted phpdoc, tests and changelog for StringHelper::truncate and StringHelper::truncateWords 2014-04-29 18:23:48 +04:00
Alexander Makarov
8d18d722b2 Merge branch 'stringhelper-truncate' of github.com:Alex-Code/yii2 into Alex-Code-stringhelper-truncate
Conflicts:
	framework/CHANGELOG.md
2014-04-29 18:03:44 +04:00
Alexander Makarov
5c4406b7e1 Updated links to guide pages 2014-04-29 17:44:41 +04:00
suralc
14e4e836e2 Fixed regex-escaping in crudgenerator 2014-04-29 15:26:13 +02:00
suralc
eac0922f13 Update CHANGELOG.md 2014-04-29 15:01:52 +02:00
suralc
4230f7664d Fix #3265
Adding a new additional validation rule in the gii-crud generator enforcing the expected format.
2014-04-29 14:58:57 +02:00
Qiang Xue
d63613b6e9 Merge pull request #3285 from mikehaertl/master
Fix bootstrap templates
2014-04-29 08:34:26 -04:00