23440 Commits

Author SHA1 Message Date
e9a4534cb1 Update module github.com/shirou/gopsutil to v4
Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
2024-09-03 18:20:12 +02:00
efd4971545 Merge pull request #23840 from Luap99/ci-fedora-39
Update to go 1.22
2024-09-03 14:14:50 +00:00
54b8c4fb64 packit: update fedora and epel targets
f39 doesn't container go 1.22 so we can no longer build there. epel 9
has the same issue although it is likely that go will be updated there
at one point.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-03 15:14:15 +02:00
f93fcf7dee bump go to 1.22
Many dependencies started using go 1.22 which means we have to follow in
order to update.

Disable the now depracted exportloopref linter as it was replaced by
copyloopvar as go fixed the loop copy problem in 1.22[1]

Another new chnage in go 1.22 is the for loop syntax over ints, the
intrange linter chacks for this but there a lot of loops that have to be
converted so I didn't do it here and disable th elinter for now, th eold
syntax is still fine.

[1] https://go.dev/blog/loopvar-preview

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-03 15:14:15 +02:00
d03e8ffc56 cirrus: test only on f40/rawhide
We want to update to golang 1.22 but f39 only ships 1.21. This means we
can no longer build on f39 once the update is done. Given we do not ship
podman 5.0 on f39 anyway this is not a problem.

So drop the f39 tasks but given we use them to test different db/storage
drivers we cannot just remove them. Instead we now test f40 twice with
the different db/storage drivers to ensure we keep full coverage.

It do however drop it from the container int task. I really do not see
the value there to test a different db backend as this doesn't depend on
anything in the container.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-03 15:14:15 +02:00
2ca4efb9f4 cirrus: remove CI_DESIRED_NETWORK reference
Since commit 26cd01ee51 we only test netavark and cni support was
dropped. Remove the leftover CI_DESIRED_NETWORK reference.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-03 15:14:15 +02:00
e598bcafb8 cirrus: prebuild use f40 for extra tests
This check has a condition on the distro name to only run once, however
the prior fedora version doesn't have to exists necessarily as we might
have to drop support there due the outdated golang version.
The current fedora version should alway exists so this seems safer.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-09-03 15:13:42 +02:00
b70cf8265b Merge pull request #23833 from containers/renovate/setuptools-74.x
chore(deps): update dependency setuptools to ~=74.1.0
2024-09-03 08:42:01 +00:00
c68c2974a3 chore(deps): update dependency setuptools to ~=74.1.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-02 19:09:10 +00:00
29eb8ce09e Merge pull request #23814 from ruihe774/quadlet-network-container
quadlet: support container network reusing
2024-09-02 16:23:01 +00:00
a5570decdf Merge pull request #23829 from containers/renovate/golang.org-x-exp-digest
fix(deps): update golang.org/x/exp digest to 9b4947d
2024-09-02 13:05:01 +00:00
0af0df1de7 Merge pull request #23672 from mheon/contributing_enforce_fixes
Specify format to use for referencing fixed bugs.
2024-09-02 12:59:47 +00:00
57aa4570af Merge pull request #23830 from dfr/freebsd-inspect
libpod: fix HostConfig.Devices output from 'podman inspect' on FreeBSD
2024-09-02 11:28:45 +00:00
60af13ca0f libpod: fix HostConfig.Devices output from 'podman inspect' on FreeBSD
This changes the value emitted for HostConfig.Devices from 'null' to
'[]'. The 'null' value was preventing ansible's podman module from
working correctly on FreeBSD.

Signed-off-by: Doug Rabson <dfr@rabson.org>
2024-09-02 11:21:35 +01:00
b98612227c Merge pull request #23813 from Luap99/readthedocs
docs: update read the docs changes
2024-09-02 09:36:00 +00:00
70358ecf18 fix(deps): update golang.org/x/exp digest to 9b4947d
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-01 04:09:59 +00:00
ef905ef8d0 Merge pull request #23726 from ashley-cui/machlist
machine: Add -all-providers flag to machine list
2024-08-30 16:52:31 +00:00
3a3f14db62 Merge pull request #23809 from Luap99/remove-fcos-pr-check
github: remove fcos-podman-next-build-prepush
2024-08-30 15:27:23 +00:00
d49ac106b0 Merge pull request #23807 from Honny1/fix-top-layer-not-found-storage
Vendor `c/common:8483ef6022b4`
2024-08-30 15:08:01 +00:00
c6fe5e5395 Vendor c/common:8483ef6022b4
This commit vendor pre-release version of `c/common:8483ef6022b4`.
It also adapts the code to the new `c/common/libimage` API, which
fixes an image listing race that was listing false warnings.

fixes: #23331

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
2024-08-30 16:13:54 +02:00
71fd15726d quadlet: support container network reusing
Signed-off-by: Misaki Kasumi <misakikasumi@outlook.com>
2024-08-30 21:35:21 +08:00
f48f999b86 Merge pull request #23810 from ygalblum/quadlet-build-multi-tag
Quadlet - Support multiple image tags in .build files
2024-08-30 13:29:04 +00:00
ece759a69a Merge pull request #23694 from edsantiago/safename-500
CI: parallel-safe network system test
2024-08-30 13:09:47 +00:00
f40eb5f06a docs: update read the docs changes
Read the Docs does some update by October 7, 2024 which will effect our
builds per[1]. As such apply the recommended changes from there to our
conf.py file so we do not get broken builds after that date hopefully.

[1] https://about.readthedocs.com/blog/2024/07/addons-by-default/#how-does-it-affect-my-projects

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-30 11:57:58 +02:00
0f4dd7f369 Merge pull request #23657 from containers/renovate/github.com-vbauerster-mpb-v8-8.x
fix(deps): update module github.com/vbauerster/mpb/v8 to v8.8.3
2024-08-30 09:16:02 +00:00
abea5ad4ac CI: parallel-safe network system test
- replace random_string with safename in container/network names
- add ci:parallel tags where possible.
  - where not possible, add explanations
- fix a userns leak

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-29 13:08:57 -06:00
2b14db2af3 Quadlet - Support multiple image tags in .build files
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2024-08-29 15:07:49 -04:00
f3db6b19d7 Merge pull request #23805 from Luap99/cirrus-timeouts
CI: some cirrus setup improvements/speedups
2024-08-29 18:30:35 +00:00
3bdddea8fa fix(deps): update module github.com/vbauerster/mpb/v8 to v8.8.3
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-29 17:20:01 +00:00
6a0ab6f7bc cirrus: remove _bail_if_test_can_be_skipped
Since commit 55ad0d6e0e we do the conditions in the cirrus.yml directly
so there is no longer any need for this.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-29 18:59:47 +02:00
d5c5261e6f cirrus: move renovate check into validate
The renovate config is used for the renovate bot, validating this in the
prior fedora prebuild setp is just confusing and hidden.

The problem is this image is very big so it is slow to download/extract.
To speed things up given it is only a single file we check the diff if
we even changed it.

Now one could argue this should be part of the validate Makefile target
but I given the size I do not want this run by default and I am not sure
if we should do the diff check in the Makefile.

Lastly remove -it, these is meant for interactive use and throws a
warning here because we have no actual tty attached.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-29 18:59:47 +02:00
ac18b1a0af cirrus: remove 3rd party connectivity check
This doesn't help us at all, first the list is outdated. AFAICT we no
longer connect to docker.io, registry.fedoraproject.org or
podman.cachix.org (seems to be a cache site for nix.dev?) anywhere in
our tests.

Second a simple port check is not helpful, in the most cases the
CDN's and or load balancer accept connections but return internal server
errors when the registy goes down.

This is very similar to commit 5b6de98ee8.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-29 18:59:46 +02:00
34a7d8dd10 cirrus: remove cross jobs for aarch64 and x86_64
We do build and test aarch64 and x86_64 natively so the cross job
doesn't seem to add value.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-29 18:59:46 +02:00
186f50ad7d cirrus: do not upload alt arch cross artifacts
They do not add much value to users, first of it compiles podman with
cgo disabled which means the included the podman binary is unusable
either way. The only goal of the build job is to ensure we can compile
on all arches, i.e. go build tags adn types work correctly. The upload
if these artifacts alone take over 90s so let's get rid of them to speed
up the total CI time.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-29 18:59:46 +02:00
94431c29b4 cirrus: remove ginkgo-e2e.json artifact
It is not used by anybody so we do not have to store these and can safe
some time by not having to generate it even if it is just ~500ms.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-29 18:59:46 +02:00
78be80f2cd cirrus: fix default timeouts
Two weeks ago we had a weird hang in the macos build job on the
persitent worker. The task just hang for an hour wasting time.
Most tests are fast so we do not need/want such high timeouts.

Therefore drop the default timeout to 20 minutes. The integration task
also should take under 20m so we can remove the longer timeout there as
well. Some system tests need a bit over 30m currently, timeout is set to
35m. For machine tests we use 30m on linux, 45m on windows and 35m on
macos to have some extra room there as machine tests have a much higher
run to run variance.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-29 18:59:46 +02:00
2b3052eac3 Merge pull request #23758 from edsantiago/podman-troubleshooting
Create a podman-troubleshooting man page
2024-08-29 16:54:00 +00:00
775d27fcd8 github: remove fcos-podman-next-build-prepush
It is flaking[1] from time to time on PRs and doesn't really add value
because noone is actually chaing the Containerfile. The task on main
that build a image based of main still exists as per Lokesh
podman-dekstop uses it for testing. In the near term we will get proper
builds in the podman-machine-os repo so this other workflow can
hopefully removed altogether.

[1] https://github.com/containers/podman/actions/runs/10618524888/job/29433963845?pr=23807

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-29 18:23:37 +02:00
03a413f6e5 Merge pull request #23779 from wbrefvem/wsl-volume-docs
Clarify podman machine volume mounting behavior under WSL
2024-08-28 18:25:39 +00:00
10363e1e81 Merge pull request #23766 from Luap99/http-attach
fix races in the HTTP attach API
2024-08-28 18:11:50 +00:00
63545126c2 Clarify podman machine volume mounting behavior under WSL
Signed-off-by: Will Refvem <wbrefvem@gmail.com>
2024-08-28 13:57:03 -04:00
41f945fc24 machine: Add -all-providers flag to machine list
Podman machine list now supports a new option, --all-providers, which lists all machines from all providers.

Signed-off-by: Ashley Cui <acui@redhat.com>
2024-08-28 13:40:50 -04:00
da90ad1960 Merge pull request #23772 from mheon/fix_volume_get_sqlite
Fix an improperly ignored error in SQLite
2024-08-28 16:43:50 +00:00
5d211add11 Merge pull request #23401 from l0rd/fix-machine-e2e-basic-test-volume-ops-on-hyperv
Stop skipping machine volume test on Hyper-V
2024-08-28 16:41:06 +00:00
f013ebe447 Merge pull request #23777 from edsantiago/socat-workaround
CI: flake workaround: ignore socat waitpid warnings
2024-08-28 14:23:37 +00:00
0e5eba6053 Merge pull request #23768 from Luap99/cirrus-rhel-machine
cirrus: skip windows/macos machine task on RHEL branches
2024-08-28 12:52:49 +00:00
5389eee737 Create a podman-troubleshooting man page
Generated at build time from troubleshooting.md. Purpose is
to ship an actual man page to end users.

Much more complicated than initial guess, because there was
a bug in my Makefile man page filtering, the sed expression
that cleans up markdown that does not translate to roff.
All I've done here is reorder some of the expressions,
stripping off https links *before* we process
podman man page links.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-28 05:49:45 -06:00
a19f42ead6 Merge pull request #23787 from containers/renovate/setuptools-74.x
chore(deps): update dependency setuptools to v74
2024-08-28 11:08:19 +00:00
33b96e78c8 chore(deps): update dependency setuptools to v74
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-28 10:41:59 +00:00
d45b153a99 Merge pull request #23656 from containers/renovate/github.com-rootless-containers-rootlesskit-v2-2.x
fix(deps): update module github.com/rootless-containers/rootlesskit/v2 to v2.3.1
2024-08-28 10:40:49 +00:00