Changes made in this commit will fix#16168
The current command in the docs expect a `docker.exe` file to exist in the current working directory.
As this is most likely a typo, changes made in this commit fix this issue.
Signed-off-by: Manuel Thalmann <m@nuth.ch>
In more recent Windows 11 versions (not sure about Windows 10),
Windows now ships its own `curl.exe`,
so PowerShell's "curl"-alias no longer exists.
Changes made in this commit will replace the `curl` alias call with the actual `Invoke-WebRequest` function.
Signed-off-by: Manuel Thalmann <m@nuth.ch>
Bumping the timeout for aarch64 machine tests as I am getting a
consistent timeout where the tests are not completing in the given time.
Signed-off-by: Brent Baude <bbaude@redhat.com>
This allows users to set the associated machine's system connection to the system default when running `podman machine init --now` or `podman machine start`. It also changes the default bbehavior of these commands in that the user will be prompted and asked if they would like to switch the system connection. It also introduces a command line switch called `--update-connection`. If the switch is unset, then the user will be prmpted. If the command value is explicitly set to `false`, the user will not be prompted and the system connection will not be altered. If the value is set to `true`, the system connection will be made the default and the user will not be prompted.
Fixes: https://issues.redhat.com/browse/RUN-3632
Signed-off-by: Brent Baude <bbaude@redhat.com>
Fixes a regression introduced by b2e6d53 that made always failing the
match of the WSL image from the registry with the image in the local
cache. The result was that the WSL machine image was always pulled from
quay.io even if an identical image was in the local cache.
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Bump bundled krunkit to 1.1.1. This is a minor, expedited release
to fix a library linking problem.
Fixes: #27427
Signed-off-by: Sergio Lopez <slp@redhat.com>
The remote client (podman --remote) was incorrectly throwing an error
when --detach-keys="" was specified for attach, run, or start commands.
According to documentation and the v1.7.0 release notes, specifying an
empty string should disable detaching, not cause an error.
Fixes: #27414
Signed-off-by: shiavm006 <shivammittal42006@gmail.com>
This variable is dead code as far as I can tell. I think it
got cargo culted from something similar in skopeo, where it *is*
used:
85598438ce/Makefile (L75)
etc.
(Instead it looks like there's a `PODMANCMD` here)
But I'm effectively using this PR as a way to suggest aligning
with what we're doing in bootc, where we have a core principle
that `Makefile` should *never* itself spawn containers (or VMs etc).
All the rules in Makefile are things that should work when e.g.
building RPMs or debs or the like.
Those tasks are things that are done via `Justfile`:
https://github.com/bootc-dev/bootc/blob/main/Justfile
So for example to align, we'd add a `Justfile` here and then
`make validatepr` would move to `just validatepr`.
Signed-off-by: Colin Walters <walters@verbum.org>
Perhaps exposing some our critical pull requests requirements in a checklist might help users. As of now, we do this as a "soft open".
Co-authored-by: Jan Rodák <hony.com@seznam.cz>
Co-authored-by: Ashley Cui <ashleycui16@gmail.com>
Signed-off-by: Brent Baude <bbaude@redhat.com>
A condition was changed in the refgactor of init where duplicate names would be allowed but no machine was created. Duplicate names are not permitted and should return an error.
Signed-off-by: Brent Baude <bbaude@redhat.com>
The windows installer doesn't like -rc's because it's not strictly semver, but this error can be suppressed.
Signed-off-by: Ashley Cui <acui@redhat.com>
The WSL tests for `podman machine` are flaking with unreasonable
frequency right now. Last Friday, I needed to re-run a job 8
times to get it to pass and complete the release of 5.7 RC1. This
is simply not sustainable. Mark the tests allowed-failure until
this can be resolved.
Signed-off-by: Matt Heon <mheon@redhat.com>
Add the ability for users to override the default provider when creating mahcines. The new flag is `--provider` and allows you to specifiy a valid vmtype for the platform. This PR also removes the previous list test where we tested listing all providers. I added a PR for testing --provider which includes a standard `machine ls` which defaults now to showing all providers.
Signed-off-by: Brent Baude <bbaude@redhat.com>
Bump bundled krunkit to 1.1.0. For podman, this release means
better I/O performance due to this libkrun version defaulting to
a more relaxed disk image sync on macOS, and raising the vCPU
limit to the maximum allowed by Hypervisor.framework.
Fixes: #27216
Signed-off-by: Sergio Lopez <slp@redhat.com>
This also includes a number of significant changes to the SQLite
state made possible by removal of the legacy DB.
1. Enable database unit tests for SQLite state, with numerous
tweaks to get tests passing. Most notable changes are to
container removal - where we previously didn't return an error
if there was no container to remove - and RemovePodContainers,
which I don't think ever worked properly from my reading of
the failures.
2. Removal of AddContainerToPod/RemoveContainerToPod. On SQLite,
these functions are identical to AddContainer/RemoveContainer
and there is no reason to retain duplicates.
3. Removal of SafeRewriteContainerConfig - it's identical to
RewriteContainerConfig in SQLite, no reason to have duplicate
entrypoints.
As an exciting side-note, this removes Podman's requirement that
containers and pods cannot share a name, which was a BoltDB
restriction only.
Signed-off-by: Matt Heon <matthew.heon@pm.me>
