21313 Commits

Author SHA1 Message Date
c315c8e74e Makefile - make sure gitvalidation is installed before calling it
[NO NEW TESTS NEEDED]

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2024-01-02 12:09:12 +02:00
5657e32726 Merge pull request #21084 from ygalblum/kube-generate-bind-mount-annotation
Kube Generate - check options in bind-mount-options exist before accessing
2024-01-02 08:27:42 +00:00
55b08d3bad applehv - fix vm lookup
small correction to properly lookup a applehv vm on disk.

Fixes: #21090

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <baude@redhat.com>
2024-01-01 14:33:30 -06:00
8dcd3b221c Merge pull request #21089 from bc-lee/feature/podman-machine-mount-mmap
Add mmap cache option to QEMU mount
2024-01-01 19:51:13 +00:00
4419924150 Merge pull request #21107 from fj-tsubasa/e2e-systemd_test-journald
e2e: Skip journalctl if journald is unavailable
2024-01-01 19:48:26 +00:00
ec5422af5b e2e: Skip journalctl if journald is unavailable
Test "podman start container by systemd" is failed on the system in
which rootless users don't have accessibility to journald. Therefore,
skip the part that reads journal with journalctl.

Signed-off-by: Tsubasa Watanabe <w.tsubasa@fujitsu.com>
2023-12-31 15:27:53 +09:00
4f94c96b9b remote: fix podman-remote kube play --publish-all
Fix `podman kube play --publish-all` to work in remote environment.

Signed-off-by: Tsubasa Watanabe <w.tsubasa@fujitsu.com>
2023-12-29 12:41:54 +09:00
4083ddbb00 Kube Generate - check options in bind-mount-options exist before accessing
Verify that the separator ':' was found before splitting the string

[NO NEW TESTS NEEDED]

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2023-12-26 18:13:41 +02:00
f10a7bfd4c Add mmap cache option to QEMU mount
This is required for mmap'ing on mounted files on MacOS Host.
Closes #19639, #20055.

Signed-off-by: Byoungchan Lee <daniel.l@hpcnt.com>
2023-12-26 18:37:10 +09:00
7dc7cbfd9b Merge pull request #21067 from containers/renovate/go-github.com/containerd/containerd-vulnerability
chore(deps): update module github.com/containerd/containerd to v1.7.11 [security]
2023-12-22 07:58:16 -05:00
2fc862d391 chore(deps): update module github.com/containerd/containerd to v1.7.11 [security]
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-12-20 15:50:20 +00:00
65266a3892 Merge pull request #21055 from edsantiago/xref_tests
[CI:DOCS] Tests for xref-helpmsgs-manpages
2023-12-19 12:27:39 +00:00
551e3c56de Merge pull request #21030 from containers/renovate/github.com-vbauerster-mpb-v8-8.x
Update module github.com/vbauerster/mpb/v8 to v8.7.1
2023-12-19 12:24:30 +00:00
90b09b5869 chore(deps): update module golang.org/x/crypto to v0.17.0 [security]
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-12-19 12:11:58 +00:00
6a65597358 Merge pull request #21053 from rhatdan/VERSION
Move golang requirement from 1.18 to 1.20
2023-12-19 12:10:46 +00:00
d161cf32fb Merge pull request #21046 from gavinkflam/improve-test-compose
Improve compose tests to report test errors as failures
2023-12-18 20:35:44 +00:00
f90b4e79a6 Tests for xref-helpmsgs-manpages
In the process of adding new functionality to the xref script,
I realized it is much too fragile. It's too easy to make some
minor change that could break the crossrefs, giving us the
illusion of testing.

Solution: add a test suite for the script. Still incomplete,
but an important step toward building confidence.

Requires minor surgery to the script itself

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-12-18 13:33:07 -07:00
26bcffd7a1 Merge pull request #21017 from giuseppe/fix-podman-info-twice
abi: drop check for IsRootless()
2023-12-18 20:32:59 +00:00
de3c02ab46 Merge pull request #21039 from rhatdan/pods
Allow PublishPorts to be used with [Pod] entry
2023-12-18 20:30:15 +00:00
1322f3193b abi: drop check for IsRootless()
it is the wrong check to do here since we need to setup the user
namespace even in the case we are running as root without
capabilities.

[NO NEW TESTS NEEDED] this happens in nested podman

Closes: https://github.com/containers/podman/issues/20908

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2023-12-18 14:05:30 +01:00
c324dbb8b4 Merge pull request #21049 from k9withabone/quadlet-ulimit-multiple
quadlet container support multiple Ulimit options
2023-12-18 12:38:22 +00:00
4dd58f226d Move golang requirement from 1.18 to 1.20
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-12-18 07:29:31 -05:00
702c6f8ada Merge pull request #21040 from gardar/docs/oci-dir-compress
[CI:DOCS] Fix `podman save` command example to use correct image format with `--compress` flag
2023-12-18 08:21:55 +00:00
a5aa970cb3 Merge pull request #21025 from lstolcman/contrib-systemd-readme-fix
[CI:DOCS] Fix path to example files in contrib/systemd/README.md
2023-12-17 11:27:51 +00:00
f169fc76af Allow PublishPorts to be used with [Pod] entry
Fixed: https://github.com/containers/podman/issues/21035

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-12-17 06:25:36 -05:00
6a96c8b5fc quadlet container support multiple Ulimit options
Add support for using multiple `Ulimit=` options in `.container` files.
Before, only the last `Ulimit=` option was used in the podman command.

Update podman-systemd.unit.5 docs to reflect this change.

Add `test/e2e/quadlet/ulimit.container` to e2e tests.

Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
2023-12-17 04:31:59 -06:00
ccc3eb774d Improve compose tests
* Add traps to report setup, tests, and teardown errors as failures
* Pass through return code of podman commands
* Fix unset variables
* Fix simple_port_map image build when installing flask (PEP 668 - externally managed environment error)
* Ignore kill errors in slirp4netns_opts teardown steps

Signed-off-by: Gavin Lam <gavin.oss@tutamail.com>
2023-12-16 12:04:25 -05:00
e51bab3c97 Remove duplicated content in docs
Signed-off-by: Łukasz Stolcman <lukasz.stolcman@protonmail.com>
2023-12-15 23:54:03 +01:00
07834ab39e Merge pull request #21013 from gavinkflam/17167-compat-base-hosts-file
Fix Docker API compatibility with network alias
2023-12-15 20:44:08 +00:00
d1d38b2aa4 Merge pull request #21011 from edsantiago/wait_wait_wait
CI: safer podman-stop tests
2023-12-15 20:31:38 +00:00
d76bb978b7 docs: oci-dir does not support compress as suggested
The docs have this note for the `--compress` flag

> Note: This flag can only be set with --format=docker-dir.

Yet the provided example has `--compress` with `--format=oci-dir`

Signed-off-by: gardar <gardar@users.noreply.github.com>
2023-12-15 19:40:46 +00:00
2258329769 Merge pull request #21026 from containers/renovate/github.com-mattn-go-sqlite3-1.x
Update module github.com/mattn/go-sqlite3 to v1.14.19
2023-12-15 13:38:59 +00:00
f02fe73c3d Update module github.com/vbauerster/mpb/v8 to v8.7.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-12-15 12:42:21 +00:00
b132c025db Merge pull request #21010 from edsantiago/docs_formatting
[CI:DOCS] doc cleanup
2023-12-15 12:41:12 +00:00
5c4c76b8c9 Update module github.com/mattn/go-sqlite3 to v1.14.19
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-12-15 10:42:30 +00:00
db68764d8b Fix Docker API compatibility with network alias (#17167)
* Add BaseHostsFile to container configuration
* Do not copy /etc/hosts file from host when creating a container using Docker API

Signed-off-by: Gavin Lam <gavin.oss@tutamail.com>
2023-12-14 23:31:44 -05:00
7c72d8c2f3 Fix path to example files
Signed-off-by: Łukasz Stolcman <lukasz.stolcman@protonmail.com>
2023-12-15 00:37:53 +01:00
077b000996 Merge pull request #20995 from mheon/error_on_gvproxy_exit
Error on HyperV VM start when gvproxy has failed to start
2023-12-14 20:53:13 +00:00
fb9e9de1ca Merge pull request #20966 from ygalblum/kube-play-build-private-reg
Kube Play - pass arguments to build
2023-12-14 20:33:10 +00:00
5cc5b43473 Error on HyperV VM start when gvproxy has failed to start
After the VM has successfully started, check that gvproxy is
still running. If it is not, throw an error and refuse to
complete machine start.

[NO NEW TESTS NEEDED] I don't think we can deliberately trigger a
bad gvproxy start without a bad Podman binary. We could try and
kill gvproxy after it starts but before the machine is booted but
that's very prone to races.

Slightly restructure code so that starting shares happens later
and has its own configuration write - so the VM is still recorded
as running if starting shares fails.

Signed-off-by: Matt Heon <mheon@redhat.com>
2023-12-14 13:31:37 -05:00
9c16f1bab8 Merge pull request #21009 from baude/hypervcheckexclusivearch
CheckExclusiveArch should use local JSON too
2023-12-14 18:30:03 +00:00
068eba15fb Merge pull request #21015 from containers/renovate/github.com-containers-libhvee-0.x
fix(deps): update module github.com/containers/libhvee to v0.6.0
2023-12-14 15:12:07 +00:00
d026ccf9a7 Kube Play - pass arguments to build
Create a buildah SystemContext from the existing cli arguments
Pass the SystemContext to the build
Add system test

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2023-12-14 16:31:09 +02:00
e4ecd7cca3 doc cleanup
Began as a review of #20983, a community PR from @krumelmonster
for moving divisive-language footnotes closer to the point
where they're used. In the process, I noticed a lot of poor
markdown, mostly bad use of whitespace. Cleaned it up, added
some italic/bold/tty markdown to options, and cleaned up
some language I found confusing.

Thanks to @krumelmonster for initial PR.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-12-14 05:17:43 -07:00
1c59a9ced1 CI: safer podman-stop tests
A number of tests start a container then immediately run podman stop.
This frequently flakes with:

   StopSignal SIGTERM failed to stop [...] in 10 seconds, resorting to SIGKILL

Likely reason: container is still initializing, and its process
has not yet set up its signal handlers.

Solution: if possible (containers running "top"), wait for "Mem:"
to indicate that top is running. If not possible (pods / catatonit),
sleep half a second.

Intended to fix some of the flakes cataloged in #20196 but I'm
leaving that open in case we see more. These are hard to identify
just by looking in the code.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-12-14 04:49:46 -07:00
8d94fc1564 fix(deps): update module github.com/containers/libhvee to v0.6.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-12-14 10:55:38 +00:00
b82e336751 Merge pull request #21004 from umohnani8/push-endpoint
Fix push endpoint stream
2023-12-13 22:41:33 +00:00
5e76a88a32 Merge pull request #20998 from edsantiago/safer_isolation
CI: systests: safer isolation in registry & tests
2023-12-13 21:38:12 +00:00
3a842027af CheckExclusiveArch should use local JSON too
When performing CheckExclusiveArch, we should get a list of VMs that
exist on disk (JSON).  We should then iterate those and checking if they
are running in HyperV.

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
2023-12-13 14:41:29 -06:00
7080d9980f Merge pull request #21002 from baude/machinee2edisksize
machine e2e : set default disk size to 11
2023-12-13 20:29:05 +00:00