21313 Commits

Author SHA1 Message Date
8b6d2a6d93 Merge pull request #21172 from cgwalters/machine-use-datadir
machine: use GlobalDataDir helper
2024-01-05 17:52:15 +00:00
0a316fa7d4 Merge pull request #21171 from alexandear/refactor-slices-contains
Refactor: replace StringInSlice with slices.Contains
2024-01-05 17:49:26 +00:00
e3f167f770 Add API forwarding support for HyperV
Provides Docker API client access, allowing compose to work by default
for HyperV. Basically the HyperV equiv of the work done here by #12916.

[NO NEW TESTS NEEDED]

Signed-off-by: Ashley Cui <acui@redhat.com>
2024-01-05 11:45:28 -05:00
a0a541351d consolidate ignition ready socket unit
consolidated ignition ready unit file content into one function.

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-01-05 10:11:43 -06:00
19678e3015 Merge pull request #21168 from containers/renovate/golang.org-x-sys-0.x
fix(deps): update module golang.org/x/sys to v0.16.0
2024-01-05 15:56:07 +00:00
8341ca0e7b Remove --latest from podman CMD --help output
Because --latest is not supported on podman-remote commands
we should not be showing examples using podman-remote CMD --help
with --latest usage, it confuses users. Rather then hacking up
the code with if remote else --latest, it is better to just remove
information in help messages.

Prevents: https://github.com/containers/podman/issues/21174

[NO NEW TESTS NEEDED] Since normal tests should cover this.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-01-05 10:37:51 -05:00
06064150ea machine: use GlobalDataDir helper
We shouldn't hardcode `~/.local` - we should use the internal
config helper APIs which honor the XDG_DATA_DIR etc. standard
environment variables.

Signed-off-by: Colin Walters <walters@verbum.org>
2024-01-05 10:29:36 -05:00
8bdf77aa20 Refactor: replace StringInSlice with slices.Contains
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
2024-01-05 16:25:56 +02:00
9c80f358fb Merge pull request #21125 from jakecorrenti/single-ssh-key
machine: Use a single ssh key for all machines
2024-01-05 12:55:41 +00:00
25602a03a0 fix(deps): update module golang.org/x/sys to v0.16.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-01-05 12:04:34 +00:00
82125f14b0 Merge pull request #21162 from containers/renovate/golang.org-x-sync-0.x
fix(deps): update module golang.org/x/sync to v0.6.0
2024-01-05 12:03:27 +00:00
a275f65bb2 Merge pull request #21153 from chuanchang/test_coverage_for_RHEL-14469
test/system: add test for mounting issue in the init container
2024-01-05 11:52:23 +00:00
8df25d705e Merge pull request #21118 from yyzxw/docs/remove-unused-link
[CI:DOCS] chore: remove unused links
2024-01-05 11:27:52 +00:00
79e4779558 Merge pull request #21164 from rhatdan/quadlet
Error messages not being reported unless more then one error present
2024-01-05 10:54:39 +00:00
3bfdd79150 Fix init teardown on bad ignition path
Fixes a bug where if a machine failed during init due to a bad ignition path, it would not be properly torn down.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2024-01-04 23:47:59 -05:00
b01a330d37 Use single persistent ssh key for all machines
Changes SSH key behavior such that there is a single persisted key for all
machines across all providers. If there is no key that is located at
`.local/share/containers/podman/machine/` then it is created. The keys are
not deleted when the last machine on the host is removed.

The main motivation for this change is it leads to fewer files created on the
host as a result of vm configuration. Having `n` machines on your system doesn't
result in `2n` machine-related files in `.ssh` on your system anymore.

As a result of ssh keys being persisted by default, the `--save-keys` flag
on `podman machine rm` will no longer be supported.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2024-01-04 23:47:49 -05:00
260f814bd3 test/system: add test for mounting issue in the init container
Test coverage: https://issues.redhat.com/browse/RHEL-14469

Signed-off-by: Alex Jia <chuanchang.jia@gmail.com>
2024-01-05 09:57:12 +08:00
f0319d5b7a Error messages not being reported unless more then one error present
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-01-04 14:23:04 -05:00
a1da24de4b Merge pull request #21072 from edsantiago/xref-manpage-tests
[CI:DOCS] xref-manpages script: more regression tests
2024-01-04 18:38:17 +00:00
753bdc39ba Merge pull request #20692 from jakecorrenti/ignition-pkg
Create `pkg/machine/ignition` package
2024-01-04 18:10:46 +00:00
49e2589a5f fix(deps): update module golang.org/x/sync to v0.6.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-01-04 16:38:20 +00:00
5b32dc45db Merge pull request #21155 from alexandear/docs-fix-typos
docs: fix typos
2024-01-04 16:37:19 +00:00
4508620545 xref-manpages script: more regression tests
Followup to #21055: regression tests for the code that
reads man pages. These are not xref-related at all, just
simple consistency checks on the man page content.

In the process of writing these tests, I also fixed a
longstanding bug where warning messages could be emitted
multiple times, once for each time we read a man page file
(as happens with command aliases).

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-01-04 09:35:37 -07:00
e63513542b Vendor latest c/image
Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2024-01-04 10:09:47 -05:00
98f332d482 Use parser.UnitFile
Uses the systemd unit file parser to build unit files instead of having
them be just blocks of hard-coded strings.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2024-01-04 08:51:35 -05:00
c728eeb39e Create pkg/machine/ignition package
Moves all of the ignitionfiles out of the `machine` package and into
its own called `ignition`. This required `VMType` to get moved out of
the `machine` package and into the `define` package in order to prevent
a circular dependency.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2024-01-04 08:51:35 -05:00
de797e5724 Merge pull request #21142 from ygalblum/quadlet-stop-params
Quadlet - add StopTimeout key for .container file
2024-01-04 11:53:31 +00:00
94da6397e7 Merge pull request #21149 from cgwalters/machine-debugging
machine/qemu: A few debugging prints
2024-01-04 11:50:49 +00:00
0587a00949 Merge pull request #21154 from alexandear/chore-remove-obsolete-build-constraints
chore: delete obsolete // +build lines
2024-01-04 11:48:02 +00:00
560455cbd6 docs: fix typos
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
2024-01-04 12:10:11 +02:00
2a2d0b0e18 chore: delete obsolete // +build lines
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
2024-01-04 11:53:38 +02:00
11c0277cd6 Merge pull request #21146 from cgwalters/label-machine
[CI:DOCS] ci: Automatically add "podman machine" label
2024-01-03 22:13:39 +00:00
7d131b8e11 Merge pull request #21145 from baude/appledarwindefault
Set applehv as default darwin provider
2024-01-03 22:10:54 +00:00
92f3bacc65 machine/qemu: A few debugging prints
I was trying to debug a failure which was seemingly related
to gvproxy failing which I now can't reproduce,
and added these while working on it.  Maybe they're useful in
the future.

[NO NEW TESTS NEEDED]

Signed-off-by: Colin Walters <walters@verbum.org>
2024-01-03 17:06:34 -05:00
876b2207ee ci/labeler: Add area/machine label
Because I want to track this sub-area myself.

Signed-off-by: Colin Walters <walters@verbum.org>
2024-01-03 14:04:26 -05:00
f5a986f4ee Set applehv as default darwin provider
Podman 5 will not support QEMU on darwin anymore.  This PR only changes the default from `qemu` to `applehv`.  Code changes to enforce not supporting qemu will come later.

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <baude@redhat.com>
2024-01-03 12:05:09 -06:00
689d97a1d1 Quadlet - add StopTimeout key for .container file
Allow setting the timeout for stopping the container
Add test
Update man

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2024-01-03 18:38:38 +02:00
185fa5ba3f Merge pull request #21103 from fj-tsubasa/remote-kube-play-publish-all
remote: fix podman-remote kube play --publish-all
2024-01-03 12:41:41 +00:00
490e5ed1a6 Merge pull request #21129 from edsantiago/new_vms
CI: bump VMs
2024-01-03 12:16:54 +00:00
45c3e76fe6 Merge pull request #21110 from cgwalters/doc-external-gvproxy
[CI:DOCS] docs/build_osx.md: Describe external gvproxy
2024-01-03 08:14:55 +00:00
ac0353aec9 chore: remove unused link
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io>
2024-01-03 09:29:58 +08:00
8c546cf7ee CI: bump VMs
All VMs have pasta 2023-12-04, so, remove a skip.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-01-02 16:10:35 -07:00
4f8154ca16 Merge pull request #21123 from containers/renovate/github.com-shirou-gopsutil-v3-3.x
fix(deps): update module github.com/shirou/gopsutil/v3 to v3.23.12
2024-01-02 18:46:14 +00:00
f9de9809e3 docs/build_osx.md: Describe external gvproxy
I think many podman-MacOS developers will fit into what this
doc section describes.

Signed-off-by: Colin Walters <walters@verbum.org>
2024-01-02 13:31:30 -05:00
8366cdccfe Merge pull request #21121 from ygalblum/makefile-install-git-validation
Makefile - make sure gitvalidation is installed before calling it
2024-01-02 12:59:43 +00:00
04548815fc Merge pull request #21114 from baude/applehvIsValid
applehv - fix vm lookup
2024-01-02 12:56:59 +00:00
a8c8704664 Merge pull request #21112 from ygalblum/quadlet-multiline-trailing-whitespaces
Quadlet - fix trailing whitespaces handling
2024-01-02 12:54:13 +00:00
5827ecb42e fix(deps): update module github.com/shirou/gopsutil/v3 to v3.23.12
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-01-02 12:36:51 +00:00
abe13a06ee Merge pull request #21059 from containers/renovate/go-golang.org/x/crypto-vulnerability
chore(deps): update module golang.org/x/crypto to v0.17.0 [security]
2024-01-02 12:34:59 +00:00
70a53cb76a Quadlet - fix trailing whitespaces handling
Remove all trailing white spaces from all lines before the line by line
processing
Add test
Exclude the unit file used for the test from whitespace check

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2024-01-02 12:26:44 +02:00