7382 Commits

Author SHA1 Message Date
e66346c7b0 Stop wrapping pull messages
The length and size of our error messages on failure to pull
is huge.  This patch at least eliminates some of the wrapping.
But I think eventually we need to look at containers/image
and see if we can modify the error messages to something a little
more human friendly.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-23 05:31:36 -04:00
c71bbffc0f Merge pull request #5948 from jwhonce/jira/826
V2 Restore rmi tests
2020-04-23 10:32:15 +02:00
be5605ac4f V2 Restore rmi tests
* Introduced define.ErrImageInUse to assist in determining the exit code
  without resorting string searches.

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-22 15:34:33 -07:00
bf1e5b875f Merge pull request #5942 from mheon/volume_flags
Enable basic volumes support in Podmanv2
2020-04-22 23:27:07 +02:00
142757bd72 Merge pull request #5947 from rhatdan/v
Turn on version.go except for -v check
2020-04-22 23:10:46 +02:00
2584d6bd58 Merge pull request #5936 from rhatdan/selinux1
Move selinux labeling support from pkg/util to pkg/selinux
2020-04-22 22:30:59 +02:00
576fe98bbc Merge pull request #5930 from jwhonce/issues/5765
Instrumentation to answer #5765
2020-04-22 21:29:10 +02:00
94dc39a41b Merge pull request #5945 from rhatdan/pull
Fix podman push and podman pull to check for authfile
2020-04-22 21:26:42 +02:00
cac05c8588 Merge pull request #5944 from rhatdan/untag
Fix integration tests for untag
2020-04-22 21:23:42 +02:00
34ee183ae6 Turn on version.go except for -v check
Currently podman -v does not work but the other version checks all pass.

enabling tests to that we can get more tests running in CI.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-22 15:18:42 -04:00
9a910efcf6 Merge pull request #5202 from QiWang19/path-config-storageconf
test rootless_storage_path from storage.conf
2020-04-22 20:57:14 +02:00
ae1731e03f Fix podman push and podman pull to check for authfile
This fixes pull_test.go push_test.go is still broken because of
lack of registry support.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-22 14:30:40 -04:00
b4a4338dfe Enable basic volumes support in Podmanv2
This enables the --volume, --mount, and --tmpfs flags in
Podmanv2. It does not enable init-related flags, image volumes,
and --volumes-from.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-04-22 14:24:12 -04:00
366fc0520b Merge pull request #5941 from jwhonce/jira/792
V2 Restore exists E2E tests
2020-04-22 20:22:44 +02:00
ede8380d37 Move selinux labeling support from pkg/util to pkg/selinux
The goal here is to make the package less heavy and not overload
the pkg/util.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-22 14:17:59 -04:00
6fdcc09a20 Fix integration tests for untag
Signed-off-by: Brent Baude <bbaude@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-22 14:13:07 -04:00
d7a27b8e84 Instrumentation to answer #5765
* currently wired to localhost:8888 to prevent access from off machine

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-22 11:07:28 -07:00
d422799595 test rootless_storage_path from strorage.conf
test rootless_storage_path from strorage.conf. If user configured rootless_storage_path in storage.conf, podman info should suggest the change.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-04-22 14:02:32 -04:00
703fd50553 Merge pull request #5940 from rhatdan/rm
Fix podman rm to have correct exit codes
2020-04-22 19:33:00 +02:00
7d8875f8e5 Merge pull request #5929 from QiWang19/v2test-info
Fix v2 test podman info
2020-04-22 19:30:18 +02:00
d0caf90940 V2 Restore exists E2E tests
* Fix setting exit code in */exists.go

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-22 09:53:05 -07:00
1be8ded964 Fix podman rm to have correct exit codes
If you attempt to remove a running container is it supposed to exit with
2
If you attempt to remove a non existing container is is supposed to exit with
1

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-22 11:53:00 -04:00
6e33c328b9 Fix v2 test podman info
Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-04-22 11:46:44 -04:00
7f1d00108e Merge pull request #5938 from rhatdan/v2
Fix handling of --cidfile on create/run
2020-04-22 17:02:16 +02:00
94b62dac74 Fix handling of --cidfile on create/run
Currently create and run are ignoring the cidfile flag.

Enable stop_test.go to make sure this works.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-22 09:52:33 -04:00
0d57ea420e Merge pull request #5934 from rhatdan/v2
vendor in containers/common v0.9.4
2020-04-22 09:44:42 -04:00
5bbbc9996f Merge pull request #5737 from cevich/add_f32
Cirrus: Add support for Fedora 32 beta
2020-04-22 07:37:14 -04:00
4494ec6f04 vendor in containers/common v0.9.4
This will change the default of UserNS to false

Also turn on tests for create_staticip_test.go
run_device_test.go, run_selinux_test.go

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-22 06:57:06 -04:00
ea63f7076a Merge pull request #5909 from abitrolly/patch-2
gate/README.md  Fix link to .cirrus.yml and reword
2020-04-21 18:45:25 -04:00
1ad978a3d7 Merge pull request #5919 from rhatdan/v2
Lots more fixes for V2 conversion.
2020-04-21 16:53:53 -04:00
ce07f1cde8 Merge pull request #5925 from rhatdan/containers.conf
Bump to github.com/containers/common to v0.9.2
2020-04-21 16:15:26 -04:00
ba1b5d4559 Merge pull request #5851 from jwhonce/wip/json
Provide a json variable pointing to a configured json API
2020-04-21 16:13:06 -04:00
02bd8cef7b Merge pull request #5916 from giuseppe/userns-auto
v2, podman: plug --userns=auto
2020-04-21 16:10:28 -04:00
103eca67b7 Merge pull request #5894 from baude/v2test
Enable integration tests (skip fails)
2020-04-21 16:08:09 -04:00
bc56236102 Handle hostname flag from client
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-21 16:02:11 -04:00
592e7867a3 Add support for devices from command line
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-21 16:02:11 -04:00
9d7b5947b9 Fix handling of CGroupsParent and CGroupsMode
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-21 16:00:45 -04:00
f7fe424e19 Throw error on IPv6 ip addresses
Podman does not currently support IPv6 addresses.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-21 16:00:45 -04:00
413929babd Merge pull request #5905 from mheon/redo_namespaces
Modify namespace generation code for specgen
2020-04-21 15:56:53 -04:00
5c968b7693 Force integration tests to pass
Failing tests are now skipped and we should work from this.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-21 13:48:50 -05:00
1cd2b746d0 Modify namespace generation code for specgen
Namespaces have now been changed to properly handle all cases.
Spec handling code for namespaces was consolidated in a single
function.

Still missing:
- Image ports
- Pod namespaces likely still broken in Podmanv2

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-04-21 14:38:52 -04:00
2ed4a0e35f Merge pull request #5917 from vrothberg/v2-login-logout
v2: implement log{in,out}
2020-04-21 14:28:09 -04:00
0134999034 Merge pull request #5911 from giuseppe/cgroup-skip-unset
podman: do not set empty cgroup limit blocks
2020-04-21 14:20:58 -04:00
b879ccbb73 Merge pull request #5923 from baude/mybad
my bad
2020-04-21 14:00:00 -04:00
08734894ae Bump to github.com/containers/common to v0.9.2
This allows us to fix issues with people with old libpod.conf

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-21 13:31:07 -04:00
0d817f5210 Merge pull request #5900 from baude/v2cp
podmanv2 cp
2020-04-21 12:47:17 -04:00
860356970b my bad
typos in previous pr are causing panics

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-21 10:46:23 -05:00
1ed849f2d1 Merge pull request #5921 from baude/v2imageep
add entrypoint from image where needed
2020-04-21 11:23:21 -04:00
87b7223df1 Merge pull request #5920 from edsantiago/chcon_podman_remote
Makefile: fix broken chcon for podman-remote
2020-04-21 11:20:58 -04:00
a2541bf133 Merge pull request #5912 from giuseppe/v2-rlimits
v2, pkg: implement rlimits
2020-04-21 11:17:35 -04:00