18456 Commits

Author SHA1 Message Date
dc9a65e348 test/e2e: use custom network config dir where needed
Since commit f250560a8043 the play kube command uses its own network.
this is racy be design because we create the network followed by
creating/running pod/containers. This means in the meantime another
prune or reset process could wipe out the network config because we have
to share the network config directory by design in the test.

The problem is we only have one host netns which is shared between
tests. If the network config dir is not shared we cannot make conflict
checks for interface names and ip address. This results in different
tests trying to use the same interface and/or ip address which will
cause runtime failures in CNI and netavark.

The only solution I see is to make sure only the reset/prune tests are
using a custom network dir. This makes sure they do not wipe configs
that are otherwise required by other parallel running tests.

Fixes #17946

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-04-06 16:16:50 +02:00
b39cdff8c2 Merge pull request #18043 from vrothberg/fix-18041
test updates to help debug #18041
2023-04-06 08:15:25 -04:00
4880f6379f Merge pull request #18076 from nalind/read-idmaps
libpod.storageService.CreateContainerStorage(): retrieve ID maps
2023-04-06 05:59:59 -04:00
3daead7d20 Merge pull request #18067 from edsantiago/silence_ginkgo_warning
e2e: GinkgoParallelNode() -> ...Process()
2023-04-06 04:40:32 -04:00
85b1ea6304 Merge pull request #18068 from umohnani8/kube-name
Fix invalid pod name and hostname during kube generate
2023-04-06 03:43:45 -04:00
e4aad8f0f4 libpod.storageService.CreateContainerStorage(): retrieve ID maps
When creating storage for a container using ID maps, read the ID maps
that are assigned to the container from the returned container
structure, rather than from the options structure that we passed to the
storage library, which it previously modified in error.

[NO NEW TESTS NEEDED]

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2023-04-05 17:58:30 -04:00
d0ffb87925 Fix invalid pod name and hostname during kube generate
Kube generate on pods was not checking for any underscores
in the pod name so was creating a kube yaml with an invalid
pod name when there were underscores present.
The hostname for the pod is set to the podname by default. There
is no need to set that to the container's name or the pod name
again in the generated yaml. So removed that field unless a hostname
was set for the container by the user.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2023-04-05 17:43:02 -04:00
19463738c2 Merge pull request #18069 from cevich/fix_build_aarch64_dep
Cirrus: Fix aarch64 clone_script 404 errors
2023-04-05 14:20:54 -04:00
74f9fd8e6c Cirrus: Fix aarch64 clone_script 404 errors
Fixes: https://github.com/containers/podman/issues/18040

If the `build_aarch64` task happens to fail for any reason, it will
cause the `curl` command in the `clone_script` for the aarch64 system
test tasks to throw a 404.  This is because the
`local_system_test_aarch64_task` depends on `build` not `build_aarch64`.
As discovered in another issue long ago, the Cirrus API depends on doing
some dependency-resolution magic to function properly.  Fix this by
correcting the dependencies.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-04-05 12:16:06 -04:00
ce8a3a0c1e e2e: GinkgoParallelNode() -> ...Process()
...to silence runtime warning:

   GinkgoParallelNode is deprecated and will be removed in Ginkgo V2.
   Please use GinkgoParallelProcess instead.

Ref: https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#renamed-ginkgoparallelnode

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-04-05 09:44:23 -06:00
89d186bdcf Merge pull request #18050 from n1hility/ignore-nonexist-env
Fix daily run CI failures on win installer task
2023-04-05 11:00:59 -04:00
3338ffa38e Merge pull request #18055 from vrothberg/fix-17185
[CI:DOCS] --creds and registries
2023-04-05 09:40:14 -04:00
cf1582984d Merge pull request #18053 from lsm5/envsubst-rpm
Copr: fix build deps for /usr/bin/envsubst
2023-04-05 07:31:46 -04:00
10d2e9fdec [CI:DOCS] --creds and registries
Mention that specified credentials are only used to authenticate against
target registries (e.g., during `pull` or `build`) and are not used to
authenticat against mirrors etc.

Closes: #17185
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-04-05 13:28:46 +02:00
9b7fd39368 Copr: fix build deps for /usr/bin/envsubst
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-04-05 08:53:16 +02:00
80f9f80770 Don't error when removing non-existant env vars
[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2023-04-04 16:26:53 -05:00
ac1d297fc7 Merge pull request #18024 from Luap99/netns-recover
rootless netns: recover from invalid netns
2023-04-04 15:02:30 -04:00
0b80b0cdd6 Merge pull request #18045 from edsantiago/healthcheck_stopped_flake
e2e: healthcheck on stopped container: fix flake
2023-04-04 13:09:14 -04:00
ecce01e614 e2e: healthcheck on stopped container: fix flake
Test has been flaking. Reason: container was run with -d, so
there's a small window in which podman-healthcheck ran on
a running container. Solution: remove -d

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-04-04 09:42:05 -06:00
6725b1e84a Merge pull request #18042 from vrothberg/rm-release.sh
rm `hack/release.sh`
2023-04-04 10:33:54 -04:00
cb7b8fb31b test/apiv2/80-kube.at
Don't check for `.Pods` field in DELETE reports since they don't exist.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-04-04 16:07:02 +02:00
e1be7d1417 test/apiv2/80-kube.at
Check the DELETE reports for both deletes.  #18041 indicates that the
pod hasn't been removed which made me suspicious about the 1st delete.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-04-04 15:52:55 +02:00
1f3ae8a4fb system service: do not close Body
The standard lib states that server handlers don't need to close the
body, so let's not do that to avoid any unforeseen side effect.

[NO TESTS NEEDED] - existing tests should suffice.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-04-04 15:47:10 +02:00
e179079351 Merge pull request #18038 from vrothberg/quadlet-version
add `quadlet -version` flag
2023-04-04 09:01:00 -04:00
bb70d60f15 rm hack/release.sh
The script is not used anymore as it can't release off a branch, so
let's remove it.

[1] https://github.com/containers/podman/pull/18038#issuecomment-1495914827

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-04-04 14:55:58 +02:00
b9821b5e66 Merge pull request #17987 from containers/dependabot/go_modules/github.com/onsi/gomega-1.27.6
build(deps): bump github.com/onsi/gomega from 1.27.5 to 1.27.6
2023-04-04 07:43:08 -04:00
ab06fb234e Merge pull request #17993 from xduugu/quadlet-tmpfs
quadlet: implement `Tmpfs` option
2023-04-04 06:35:18 -04:00
b36bc21e21 Merge pull request #17813 from containers/dependabot/go_modules/github.com/openshift/imagebuilder-1.2.4
build(deps): bump github.com/openshift/imagebuilder from 1.2.4-0.20230207193036-6e08c897da73 to 1.2.4
2023-04-04 05:38:55 -04:00
704901d113 build(deps): bump github.com/onsi/gomega from 1.27.5 to 1.27.6
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.27.5 to 1.27.6.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.27.5...v1.27.6)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-04 09:35:33 +00:00
243ca7c280 add quadlet -version flag
I recently wanted to check which version of Quadlet I was using and
found a `-version` flag to be missing.  Since Quadlet and Podman are
bundled together, it seems reasonable to me for them to share the same
version.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-04-04 11:32:47 +02:00
7eb78f8a74 add version/rawversion package
To prevent the `semver` packages from bloating Quadlet.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-04-04 11:32:41 +02:00
53b16ccd26 quadlet: use Flag suffix for variables
Purely cosmetic change for consistency.

[NO NEW TESTS NEEDED]  as it doesn't change functionality.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-04-04 09:55:14 +02:00
17508852a7 Merge pull request #18030 from ashley-cui/rel450rc1
Bump to 4.5.0-rc1
2023-04-03 15:35:48 -04:00
443f8d89c9 quadlet: implement Tmpfs option
This commit adds an quadlet option `Tmpfs` which can be used to mount a
tmpfs in the container.

Closes #17907

Signed-off-by: Cedric Staniewski <cedric@gmx.ca>
2023-04-03 20:22:02 +02:00
91ca15e96f Bump to v4.5.0-dev
Signed-off-by: Ashley Cui <acui@redhat.com>
2023-04-03 13:50:39 -04:00
3e48017d85 Bump to 4.5.0-rc1
Signed-off-by: Ashley Cui <acui@redhat.com>
v4.5.0-rc1
2023-04-03 13:50:01 -04:00
b7175a366f Update release notes from 4.4 branch
Signed-off-by: Ashley Cui <acui@redhat.com>
2023-04-03 13:46:34 -04:00
3978347bea Merge pull request #18021 from edsantiago/unverbosify_sleeploop
System tests: unverbosify a flake log
2023-04-03 12:22:15 -04:00
9d7633d9b7 Merge pull request #17791 from multimeric/portable-wrapper
Portable Docker wrapper
2023-04-03 11:14:00 -04:00
98933456bc Merge pull request #17950 from umohnani8/deployments
Support Deployment generation with kube generate
2023-04-03 11:08:29 -04:00
facb5b0ede Merge pull request #18018 from n1hility/fix-win-inst-ci-large-env
Fix Win install task failures with large PR bodies
2023-04-03 10:31:53 -04:00
f3c5c8fb05 Merge pull request #17994 from stickM4N/patch-1
Update podman-for-windows.md
2023-04-03 10:23:46 -04:00
2051e54e01 rootless netns: recover from invalid netns
I made a change in c/common[1] to prevent duplicates in netns names.
This now causes problem in podman[2] where the rootless netns will no
longer work after the netns got invalid but the underlying path still
exists. AFAICT this happens when the podman pause process got killed and
we are now in a different user namespace.

While I do not know what causes this, this commit should make it at
least possible to recover from this situation automatically as it used
to be before[1].

the problem with that is that containers started before it will not be
able to talk to contianers started after this. A restart of the previous
container will fix it but this was also the case before.

[NO NEW TESTS NEEDED]

[1] https://github.com/containers/common/pull/1381
[2] https://github.com/containers/podman/issues/17903#issuecomment-1494169843

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-04-03 16:21:02 +02:00
8ebec20ff1 Merge pull request #18019 from ygalblum/add-secret-exists
Add support for secret exists
2023-04-03 10:11:48 -04:00
99ace19084 System tests: unverbosify a flake log
One of our oldest most frustrating flakes is #16091, "Timed
out waiting for BYE".

In #17489 we added some debug output to see if the problem
was a container hang of some sort. It does not seem to be
(see #17675), and the debug output makes it hard to read
failure logs, so let's remove it.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-04-03 07:25:53 -06:00
68dbddd979 Add support for secret exists
Add the command along with the abi and tunnel support
Add e2e tests
Add man page
Add apiv2 test to ensure return codes

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2023-04-03 15:33:50 +03:00
80a199a83c Merge pull request #17998 from vrothberg/systemd-docs
[CI:DOCS] fix typo in --systemd option
2023-04-03 08:32:19 -04:00
9ca3dd34f4 Merge pull request #17970 from TomSweeneyRedHat/dev/tsweeney/tutorup1
[CI:DOCS] Improve basic tutorial
2023-04-03 08:18:30 -04:00
5190ab1d02 Merge pull request #18009 from acouvreur/main
[CI:DOCS] docs: add `starting` to `HealthCheckResults.Status`
2023-04-03 03:08:36 -04:00
78e7ade0da Fix Win install task failures with large PR bodies
MSI Validation will fail if the process env is > 32k chars
Remove CIRRUS_COMMIT_MESSAGE and CIRRUS_PR_BODY which can easily exceed this limit

[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2023-04-02 22:44:42 -05:00