8055 Commits

Author SHA1 Message Date
cbca625328 V2 Add support for ssh authentication methods
* podman --remote ssh://<user>:<password>@<host>:<port><path>
* podman --remote ssh://<user>:<password>@<host>:<port><path> \
  --identity <path> --passphrase <phrase>
* ssh-add <key>
  podman --remote ssh://<user>@<host><path>
* Fix `podman help` to run even if podman missing components
* Prompt for passphrase on stdin IFF key is protected and passphrase
  not given via any other configuration

* cobra flags do not support optional value flags therefore refactored
  --remote to be a boolean and --url will now contain the URI to Podman
  service

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-06-03 09:54:39 -07:00
9bd48a64bb Merge pull request #6477 from rhatdan/spec
RHEL8 and Centos8 don't have oci-runtime yet
2020-06-03 16:20:51 +02:00
428303c789 Merge pull request #6474 from QiWang19/remote-cidfile-test
Turn on remote rm_test
2020-06-03 12:36:39 +02:00
48d2bea1a3 RHEL8 and Centos8 don't have oci-runtime yet
For the time being we need to just require runc
this should fix rdoproject.org/github-check

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-06-03 06:32:58 -04:00
5473ba95d7 Turn on remote rm_test --cidfile
Turn on remote rm_test --cidfile

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-06-02 19:12:31 -04:00
95ea39edf3 Merge pull request #6471 from mheon/troubleshooting_77
Remove reference to "upcoming" RHEL 7.7
2020-06-03 00:05:08 +02:00
26bb48951f Merge pull request #6468 from mheon/remote_detached_exec
Enable detached exec for remote
2020-06-03 00:02:20 +02:00
0c878beb57 Remove reference to "upcoming" RHEL 7.7
7.7 has been released for a while now, so change troubleshooting
reference to indicate that.

Fixes #6349

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-06-02 16:47:28 -04:00
4632a4b706 Merge pull request #6467 from baude/v2windowsenv
make env handling os dependent
2020-06-02 22:36:46 +02:00
69020c7040 Bump Conmon in COPR spec
We need 2.0.17 for detached remote exec.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-06-02 15:30:42 -04:00
e0d9404634 Enable detached exec for remote
The biggest obstacle here was cleanup - we needed a way to remove
detached exec sessions after they exited, but there's no way to
tell if an exec session will be attached or detached when it's
created, and that's when we must add the exit command that would
do the removal. The solution was adding a delay to the exit
command (5 minutes), which gives sufficient time for attached
exec sessions to retrieve the exit code of the session after it
exits, but still guarantees that they will be removed, even for
detached sessions. This requires Conmon 2.0.17, which has the new
`--exit-delay` flag.

As part of the exit command rework, we can drop the hack we were
using to clean up exec sessions (remove them as part of inspect).
This is a lot cleaner, and I'm a lot happier about it.

Otherwise, this is just plumbing - we need a bindings call for
detached exec, and that needed to be added to the tunnel mode
backend for entities.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-06-02 15:30:42 -04:00
c4ccd7cbc1 Merge pull request #6435 from QiWang19/uid
check --user range for rootless containers
2020-06-02 20:51:13 +02:00
37ac21ff08 Merge pull request #6460 from vrothberg/no-trunc
images --no-trunc: fix ID formatting
2020-06-02 20:48:18 +02:00
77e4b077b9 check --user range for rootless containers
Check --user range if it's a uid for rootless containers. Returns error if it is out of the range. From https://github.com/containers/libpod/issues/6431#issuecomment-636124686

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-06-02 11:28:58 -04:00
030a4d3257 images --no-trunc: fix ID formatting
Remove the redundant `sha256:` prefix from the image IDs.

Fixes: #6459
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-06-02 17:08:31 +02:00
d10addca6c Merge pull request #6457 from rhatdan/psgo
Update vendor containers/psgo
2020-06-02 15:44:15 +02:00
70e6b2e6dd make env handling os dependent
environment variables are handled differently on windows vs linux.  here we split them to be handled but no actually processing of windows environment variables was done.  it can be added for future.  hoowever, now we dont get errors on windows about processing them.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-06-02 08:28:08 -05:00
2937151e37 Merge pull request #6445 from containers/dependabot/go_modules/github.com/onsi/ginkgo-1.12.3
Bump github.com/onsi/ginkgo from 1.12.2 to 1.12.3
2020-06-02 09:02:08 -04:00
eb488e760a Merge pull request #6463 from containers/dependabot/go_modules/github.com/coreos/go-systemd/v22-22.1.0
Bump github.com/coreos/go-systemd/v22 from 22.0.0 to 22.1.0
2020-06-02 07:27:53 -04:00
b2feaa4d18 Merge pull request #6462 from containers/dependabot/go_modules/github.com/opencontainers/runc-1.0.0-rc90
Bump github.com/opencontainers/runc from 1.0.0-rc9 to 1.0.0-rc90
2020-06-02 07:25:04 -04:00
288bb2e858 Bump github.com/onsi/ginkgo from 1.12.2 to 1.12.3
Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.12.2 to 1.12.3.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/ginkgo/compare/v1.12.2...v1.12.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-06-02 07:22:54 -04:00
92f5029838 Merge pull request #6455 from rhatdan/detatchkeys
Add information on detach-keys
2020-06-02 06:11:09 -04:00
94f2241831 Merge pull request #6411 from mheon/exec_bindings
Add bindings for exec and enable attached remote exec
2020-06-02 06:08:21 -04:00
cc021546c5 Merge pull request #6443 from SCHEN2015/combine_ro_readonly
Combine the code of dealing with 'readonly' and 'ro'.
2020-06-02 06:02:54 -04:00
4157af8776 Update vendor containers/psgo
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-06-02 05:56:52 -04:00
23ff93d879 Bump github.com/opencontainers/runc from 1.0.0-rc9 to 1.0.0-rc90
Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.0.0-rc9 to 1.0.0-rc90.
- [Release notes](https://github.com/opencontainers/runc/releases)
- [Commits](https://github.com/opencontainers/runc/compare/v1.0.0-rc9...v1.0.0-rc90)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-06-02 05:53:10 -04:00
bea4264ed3 Bump github.com/coreos/go-systemd/v22 from 22.0.0 to 22.1.0
Bumps [github.com/coreos/go-systemd/v22](https://github.com/coreos/go-systemd) from 22.0.0 to 22.1.0.
- [Release notes](https://github.com/coreos/go-systemd/releases)
- [Commits](https://github.com/coreos/go-systemd/compare/v22.0.0...v22.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-06-02 05:52:35 -04:00
9f08881c20 Combine the code of dealing with 'readonly' and 'ro'.
https://github.com/containers/libpod/pull/6380#discussion_r432391376

Signed-off-by: Charles Shih <schrht@gmail.com>
2020-06-02 09:41:11 +08:00
45a7e7266e Add bindings for exec and enable attached remote
This adds bindings for starting exec sessions, and then uses them
to wire up detached exec. Code is heavily based on Attach code
for containers, slightly modified to handle exec sessions.

Bindings are presently attached-only, detached is pending on a
Conmon update landing in CI. I'll probably get to that next.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-06-01 17:24:00 -04:00
d6bf6b92c8 Merge pull request #6456 from edsantiago/bats
system tests : more tests
2020-06-01 21:11:41 +02:00
85d3641fe1 Merge pull request #6350 from rhatdan/build
Don't build code on remoteclient
2020-06-01 20:57:58 +02:00
e92a65f38c Merge pull request #6453 from jwhonce/wip/errors
Add invalid value to error message
2020-06-01 20:44:48 +02:00
7c41cb7802 Merge pull request #6454 from rhatdan/remote
Remove skipifremote checks in images_test.go
2020-06-01 20:41:41 +02:00
8b7c7e8125 Add information on detach-keys
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-06-01 14:38:05 -04:00
03d32d05ac system tests : more tests
- exec: add test for #5046, in which conmon swallowed chars
  on a large byte transfer

- pod: add 'pod exists' tests, both positive and negative;
  consolidate tests; add '--label', and check in 'pod inspect'
  add 'pod ps' tests

- networking: add test for #5466, in which detached run
  with --userns=keep-id would not forward a port

Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-06-01 12:00:47 -06:00
5f1c23dba9 Merge pull request #6449 from baude/v2podlabels
Add support for format {{.Label}}
2020-06-01 19:41:30 +02:00
990514ea92 Add support for format {{.Label}}
the pod ps man page says .Label is valid go template format. i dont think the function was actually ever implemented.

Fixes #6448

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-06-01 11:54:15 -05:00
d8b0a58fd8 turn on remote testing for images. podman-remote build now works.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-06-01 12:44:04 -04:00
670f7c271f Add invalid value to error message
Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-06-01 09:23:10 -07:00
f559cec6c0 Merge pull request #6447 from baude/v2apitarleak
Fix leak of empty tarball
2020-06-01 18:00:56 +02:00
8c1883721c Fix leak of empty tarball
In cases of trying to export an image, if the image was not found, we leaked an empty tarball or directory depending on the format.

Fixes: #6409

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-06-01 10:07:58 -05:00
2c6016f330 Merge pull request #6438 from rhatdan/man
[CI:DOCS] Update man pages for --ip with CNI networks
2020-06-01 15:37:19 +02:00
22713d62e2 Merge pull request #6353 from lsm5/build-without-varlink
enable building without `varlink` tag
2020-06-01 14:48:35 +02:00
eb9788db23 Update man pages for --ip with CNI networks
Originally, we did not allow this, and the manpage reflects that.
We added support with 1.7.0, but did not update the manpage. Fix
the manpages so they are once again accurate.

Signed-off-by: Matthew Heon <mheon@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-05-31 06:02:34 -04:00
bb05337f0a Merge pull request #6441 from TomSweeneyRedHat/dev/tsweeney/fixtuthttpd
[CI:DOCS] update httpd location in tutorial
2020-05-31 05:57:57 -04:00
bc1f5ef36e [CI:DOCS] update httpd location in tutorial
Update the reference to the httpd in the Podman tutorial.
This just bumps it to F29 for now to get things working,
I'd prefer to get something set up in quay.io to make it
more resistant to Fedora version changes.

Fixes: #6439

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2020-05-30 13:51:44 -04:00
9037908b78 Merge pull request #5594 from edsantiago/bats
system tests: enable skopeo REGISTRY_AUTH_FILE
2020-05-30 05:17:18 -04:00
6d6a629db5 Merge pull request #6165 from containers/dependabot/go_modules/github.com/rootless-containers/rootlesskit-0.9.5
Bump github.com/rootless-containers/rootlesskit from 0.9.4 to 0.9.5
2020-05-30 05:09:30 -04:00
c479d63dd6 Merge pull request #6356 from baude/v2copyendpoints
v2 copy endpoints
2020-05-30 05:06:48 -04:00
8a914e8a0b default build without varlink tag
Issue gh#6286 was already fixed in a prior commit but the Makefile still
ran some varlink steps by default.

This commit makes any varlink build steps dependent on the varlink
build tag and also makes the contrib rpm spec file independent of
varlink.

Endpoint tests will be run only if BUILDTAGS contains varlink.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2020-05-29 14:38:33 -04:00