All API versions before version 1.44 are now deprecated,
starting with Docker client version 1.29 giving an error:
"API version 1.41 is not supported by this client"
Previously it was backward-compatible for more than 10 years,
with version 1.24 being the version in classic Docker 1.12.
It seems like API code changes were already added?
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Previously, `secret create` required stdin to be a pipe when using `-`,
blocking interactive stdin forcing users to use insecure patterns like
`echo "secret" | podman secret create <name>`.
Remove the pipe check to allow interactive stdin.
Closes#18591, #27879
Signed-off-by: Danish Prakash <contact@danishpraka.sh>
When startVM fails quickly, CleanupGVProxy may attempt to read the
gvproxy.pid file before gvproxy has written it, causing cleanup to
fail.
This commit adds retry logic that waits up to 2 seconds for the PID
file to appear.
Signed-off-by: lstocchi <lstocchi@redhat.com>
Podman 5.x and earlier required to run as admin to work with Hyper-v.
Starting from Podman 6 this is not mandatory anymore as Registry
entries are handled differently. However, it may
happen the user have a legacy machine running when switching to Podman 6
or starts an old machine in elevated mode and then tries to stop it as a
normal user with Podman 6. If that happens the system will end up in a corrupted state
as the gvproxy process will not be stopped.
To prevent such scenario and issues, this commit maintains the original
behavior Podman 5.x has. Legacy Hyper-v machines needs to be handled
with elevated rights.
Signed-off-by: lstocchi <lstocchi@redhat.com>
Instead of using rpm-ostree, we now use bootc for os apply. the
implementation is a little murky right now and will require some cleanup
to implement bootc's transports. for now, we only support oci images
from registries.
once we have an upgrade command, the transports can be added and the
docs for apply can be ammended to be more clear.
Fixes: RUN-3836
Signed-off-by: Brent Baude <bbaude@redhat.com>
The test for issue #19800 depended on finding a system user with an
octal UID. This approach was fragile because system users found on the
host may have a different UID in the testing image.
Use the rootless user ID instead which is likely to be octal anyway as
new user IDs start with 1000.
Signed-off-by: Ricardo Branco <rbranco@suse.de>
He'd like to help out with issue triage in the repo - especially
flagging issues as potential development priorities.
Signed-off-by: Matt Heon <matthew.heon@pm.me>
We'd like our community managers to be able to assist in issue
triage - mostly to justify giving them the Github permissions to
add and edit labels on issues in the project.
As community managers are not expected to be technical, we're not
expecting them to act fully as reviewers, but letting them move
issues between repos, close issues that have gotten out of hand
and are accumulating CoC violations, and label persistent
problems as things that should be strongly considered for future
releases are valuable.
Signed-off-by: Matt Heon <matthew.heon@pm.me>
These are not options directly passed to `--opt`, but these use `--opt o=`, so update the table accordingly.
Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
The old setup bundle was still built and released to avoid breaking
downstream projects. This commit removes it and, starting from Podman
v6, only the installer that doesn't require elevated privileges will be
released.
This is a subtask of issue #27624.
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Before running machine e2e tests on Windows, the gvproxy executable was
copied in `C:\Program Files\Redhat\Podman`. This is wrong because the
target folder, where Podman is installed, has changed but is also
useless because, after #27612, podman looks for gvproxy in `podman.exe`
folder too. This commit removes the gvproxy copy step.
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
This commit removes the steps to build and publish the legacy windows
installer from the GitHub release workflow.
It's related to #27624.
It also removes the deprecated `upload-win-installer.yml` workflow.
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
