Commit Graph

16363 Commits

Author SHA1 Message Date
bdfc4df1f2 pkg/autoupdate: allow updating multiple tasks per unit
Refactor the auto-update backend to allow for updating multiple
tasks/containers per unit.  This commit is merely doing the plumbing.
The actual integration comes in a following commit.

[NO NEW TESTS NEEDED] as behavior should not change and existing
tests are expected to continue to pass.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2022-09-05 16:23:06 +02:00
8882b7664d Merge pull request from rhatdan/capabilities
[CI:DOCS] Fix list of default capabilities
2022-09-05 16:07:42 +02:00
cbaa78cd8a Fix list of default capabilities
Fixes: https://github.com/containers/podman/issues/15626

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-09-05 07:25:38 -04:00
098c0714e5 Merge pull request from lsm5/fix-copr-rhel-builds
[CI:BUILD] Copr: Define _user_tmpfilesdir for rhel
2022-09-05 00:19:19 +02:00
5c7f283361 Merge pull request from mheon/add_group_to_addtlgroups
Add container GID to additional groups
2022-09-05 00:16:51 +02:00
b506f6ebb7 Merge pull request from edsantiago/docs_dedup_label
[CI:DOCS] Man pages: refactor common options: --label
2022-09-05 00:14:10 +02:00
7cc2543433 Merge pull request from TomSweeneyRedHat/dev/tsweeney/adjusttest
Update test per comment in 
2022-09-04 14:24:00 +02:00
8942a60bb0 Merge pull request from dfr/freebsd-bind
Add support for FreeBSD volume mounts in specgen
2022-09-04 13:34:41 +02:00
b9df3a6a9f Man pages: refactor common options: --label
Went with the podman-run version, where the "example" is
in the option template as per our guidelines.

I could not include the network- or volume-create
man pages, nor podman build.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-09-03 05:49:52 -06:00
e136bcc7c9 Merge pull request from edsantiago/docs_dedup_digestfile
[CI:DOCS] Man pages: refactor common options: --digestfile
2022-09-03 13:27:25 +02:00
d82a41687e Add container GID to additional groups
Mitigates a potential permissions issue. Mirrors Buildah PR 
and CRI-O PR .

Signed-off-by: Matthew Heon <mheon@redhat.com>
2022-09-02 15:51:36 -04:00
2a7a6bd9a4 Merge pull request from dfr/random-names
libpod: Ensure that generated container names are random
2022-09-02 21:00:35 +02:00
9476b78316 Merge pull request from sstosh/fix-swagger
Fix swagger documentation
2022-09-02 20:15:03 +02:00
c5da5e459a Merge pull request from umohnani8/gen-kube
Fix bind-mount-option annotation in gen/play kube
2022-09-02 20:12:25 +02:00
3e1dde10b8 [CI:BUILD] Copr: Define _user_tmpfilesdir for rhel
[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2022-09-02 13:47:30 -04:00
0e66f75f2a Merge pull request from edsantiago/docs_dedup_deviceXY
[CI:DOCS] Man pages: refactor common options: --device-X-Y
2022-09-02 12:57:45 +02:00
4cbc4774f1 Merge pull request from arixmkii/win_compat2
Improved Windows compatibility for machine command
2022-09-02 12:49:58 +02:00
875fd48580 Fix swagger documentation
* ContainerKillLibpod "signal" query default is SIGKILL.
* ContainerListLibpod "namespace" query is failed to show.
* SecretListLibpod parameters is duplicated.
* SecretList parameters is duplicated.

[NO NEW TESTS NEEDED]

Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
2022-09-02 19:21:20 +09:00
9ab6449e36 Merge pull request from edsantiago/skip_ubuntu_flake
CI: disable flaking test on ubuntu
2022-09-02 00:05:07 +02:00
070dfa3b3b Man pages: refactor common options: --digestfile
Only used in two pages. I took the liberty of adding the "N/A
on remote" text to manifest-push.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-09-01 15:45:00 -06:00
475cac4432 Merge pull request from edsantiago/docs_dedup_name
[CI:DOCS] Man pages: refactor common options: --name
2022-09-01 23:41:53 +02:00
c05b6e5d3b Update test per comment in
While backporting a test from main, @edsantiago asked that
the test be adjusted as noted here:
https://github.com/containers/podman/pull/15555#issuecomment-1232791752.

This PR brings those same changes to main for posterity sake.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2022-09-01 15:55:42 -04:00
3d09d47a25 Man pages: refactor common options: --device-X-Y
Followup from : add the FAQ-26 link, and fix one
broken replacement.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-09-01 13:11:44 -06:00
d0d1af338a Merge pull request from cdoern/update
implement podman update
2022-09-01 20:48:25 +02:00
050f3291b9 implement podman update
podman update allows users to change the cgroup configuration of an existing container using the already defined resource limits flags
from podman create/run. The supported flags in crun are:

this command is also now supported in the libpod api via the /libpod/containers/<CID>/update endpoint where
the resource limits are passed inthe request body and follow the OCI resource spec format

–memory
–cpus
–cpuset-cpus
–cpuset-mems
–memory-swap
–memory-reservation
–cpu-shares
–cpu-quota
–cpu-period
–blkio-weight
–cpu-rt-period
–cpu-rt-runtime
-device-read-bps
-device-write-bps
-device-read-iops
-device-write-iops
-memory-swappiness
-blkio-weight-device

resolves 

Signed-off-by: Charlie Doern <cdoern@redhat.com>
2022-09-01 13:02:01 -04:00
c63830166c Man pages: refactor common options: --name
Only for podman-create and -run, unfortunately: all the
others are too different, and can't easily be combined.

I went with the podman-run version because it was most
recently updated in .

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-09-01 10:58:00 -06:00
4a1acccf96 Fix bind-mount-option annotation in gen/play kube
The format used for setting the bind-mount-options annotations
in the kube yaml was incorrect and caused k8s to throw an error
when trying to play the generated kube yaml.
Fix the annotation format to match the rules of k8s.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2022-09-01 11:51:46 -04:00
64eb079415 CI: disable flaking test on ubuntu
See https://github.com/containers/conmon/pull/352

As of a few days ago, Ubuntu still hadn't built a fixed conmon.
Just skip the test until we get a fixed Ubuntu or until we
figure out a better solution to the test-something-RHEL8ish
problem.

UPDATE: WEIRD: this 'skip' triggered a baffling failure
on Ubuntu: the "Kubernetes only allows 63 characters"
warning message stopped appearing, on Ubuntu only, which
then caused the kube-generate tests to fail because they
actually checked for that. The message doesn't appear
because generate-kube is no longer spitting out a line
for org.opencontainers.image.base.digest/CONTAINER.
(Why this line is gone, I don't know, and choose not
to investigate). Solution: stop checking for the kube-63
warning. It's just not that important.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-09-01 09:27:21 -06:00
0085fbb488 Merge pull request from umohnani8/gen-kube
Set enableServiceLinks to false in generated yaml
2022-09-01 15:17:39 +02:00
3994eb6985 Merge pull request from edsantiago/fix_useradd_flake
Cirrus: pick UIDs/GIDs starting at 1500, not 1000
2022-09-01 13:51:15 +02:00
b667d7340c libpod: Ensure that generated container names are random
Fixes .

Signed-off-by: Doug Rabson <dfr@rabson.org>
2022-09-01 10:27:04 +01:00
72f4c77139 Merge pull request from m0duspwnens/api_compat_containers
api: return imageID instead of imageName, for "Image" when Podman api is queried
2022-09-01 10:58:33 +02:00
009afb50b3 Merge pull request from dfr/freebsd-specgen
Add FreeBSD support for pkg/specgen/generate
2022-09-01 10:47:47 +02:00
54873c1f5e Merge pull request from lsm5/disable-packit
[CI:BUILD] Packit: Disable until proved in other repos
2022-09-01 03:13:28 +02:00
5faf4eff10 Cirrus: pick UIDs/GIDs starting at 1500, not 1000
Reason: looks like UIDs 1001, 1003, 1006 are already taken
in the CI VMs.

Fixes: 

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-08-31 13:47:05 -06:00
b25d62a4db [CI:BUILD] Packit: Disable until proved in other repos
There are concerns with Packit causing flakes and delays on Podman so
let's have Packit prove itself in other repos and only then make its way
into Podman.

See: https://github.com/containers/podman/pull/15549#issuecomment-1233230573

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2022-08-31 15:19:07 -04:00
84352a81c9 Set enableServiceLinks to false in generated yaml
Since podman doesn't set/use the needed service env
variable, always set enableServiceLinks to false in
the generated kube yaml.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2022-08-31 14:02:13 -04:00
07413f2035 Merge pull request from mheon/fix_15557
Inhibit SIGTERM during Conmon startup
2022-08-31 19:19:08 +02:00
fed4ce0ea9 Inhibit SIGTERM during Conmon startup
If we get a SIGTERM immediately after Conmon starts but before we
record its PID in the database, we end up leaking a Conmon and
associated OCI runtime process. Inhibit shutdown using the logic
we originally wrote to prevent similar issues during container
creation to prevent this problem.

[NO NEW TESTS NEEDED] No real way to test this I can think of.

Fixes 

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2022-08-31 10:58:06 -04:00
8266dbe7a9 Merge pull request from umohnani8/empty-dir
Add emptyDir volume support to kube play
2022-08-31 09:36:04 -04:00
60e4b762b3 Merge pull request from edsantiago/docs_dedup_signal
[CI:DOCS] Man pages: refactor common options: --signal
2022-08-31 09:28:00 -04:00
4cff780322 Merge pull request from dcermak/don-t-use-privileged-containers
Makefile: Mount . with --security-opt label=disable instead of using --privileged
2022-08-31 09:21:51 -04:00
6bda96ab18 Merge pull request from vrothberg/fix-15485
podman rmi: emit untag events
2022-08-31 09:19:10 -04:00
55710d8d55 Merge pull request from arixmkii/override_default_username
Allow to override default username via command line
2022-08-31 09:12:46 -04:00
9b4dac4c4d Merge pull request from giuseppe/userns-map-user
podman: add uid and gid options to keep-id
2022-08-31 08:37:34 -04:00
70a599b571 Man pages: refactor common options: --signal
Would've been an easy one, except I decided to fix the text
to conform to our guidelines. I haven't been doing this,
but in this case it's only two man pages and the text is
short enough to make for easy review.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-08-31 05:27:08 -06:00
7503c5544d Merge pull request from marshall-lee/bindings-schema-ignore
Mark some of the option fields as ignored in pkg/bindings
2022-08-31 06:28:19 -04:00
ac7f4ebb6a Merge pull request from dfr/freebsd-conmon
libpod: Make sure writeConmonPipeData is called on FreeBSD
2022-08-31 06:10:06 -04:00
f8a861b0e9 Merge pull request from edsantiago/docs_dedup_restart
[CI:DOCS] Man pages: refactor common options: --restart
2022-08-31 05:40:02 -04:00
368fa6074d Merge branch 'containers:main' into api_compat_containers 2022-08-30 14:12:01 -04:00