19956 Commits

Author SHA1 Message Date
adf34cbd79 Share podman sock bindings with other WSL distros
Registers a rootless and rootful socket underneath /mnt/wsl/podman-sockets/[machine name]/
This allows podman remote clients on other Linux distributions to access podman.

This also registers the podman root socket under the wheel group, to allow for rootful
linking against /var/run/docker.sock, a use case expected by some clients and APIs.
While this is not recommended practice on a Linux host, a WSL guest is user-isolated
and already enables escalation trivially.

[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2023-08-24 16:23:50 -05:00
db95e678ad Fix user-mode validation check
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2023-08-24 16:23:50 -05:00
0322b9df9d Merge pull request #19733 from edsantiago/registry_282
e2e tests: use registry:2.8.2 (was 2.8)
2023-08-24 14:04:11 -04:00
7661ebbc63 Merge pull request #19500 from martinpitt/tmt-revdeps-cockpit-podman
[CI:BUILD] Packit: run cockpit-podman tests in PRs
2023-08-24 13:53:50 -04:00
2c5c2d2134 [CI:BUILD] Packit: run cockpit-podman tests in PRs
See https://cockpit-project.org/blog/tmt-cross-project-testing.html

[NO NEW TESTS NEEDED] - quiesce bot, that whole commit *is* a new test

Signed-off-by: Martin Pitt <mpitt@redhat.com>
2023-08-24 18:29:44 +02:00
32f7bb131a Merge pull request #19727 from vrothberg/fix-19715
kube: notifyproxy: close once
2023-08-24 12:25:22 -04:00
6009d16b51 Merge pull request #19732 from containers/renovate/k8s.io-kubernetes-1.x
Update module k8s.io/kubernetes to v1.28.1
2023-08-24 10:28:16 -04:00
6545529df5 Merge pull request #19725 from containers/renovate/github.com-onsi-ginkgo-v2-2.x
Update module github.com/onsi/ginkgo/v2 to v2.12.0
2023-08-24 16:26:15 +02:00
a5f6a4a3bf kube: notifyproxy: close once
Do not close a notifyproxy more than once.  Also polish the backend a
bit to reflect ealier changes from commit 4fa307f.

Fixes: #19715
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-08-24 16:24:28 +02:00
638f994c26 Update module k8s.io/kubernetes to v1.28.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-24 14:22:41 +00:00
61dd7f80c2 e2e tests: use registry:2.8.2 (was 2.8)
...in hopes of addressing flake #18355

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-08-24 08:21:29 -06:00
4d5bef98f5 Merge pull request #19730 from edsantiago/you_say_hello_and_i_say_goodbye
Revert "Remove `hello` multi-arch image build"
2023-08-24 10:18:36 -04:00
70f77efef9 Revert "Remove hello multi-arch image build"
This reverts commit 7e0130f75cc27ae32d8843a8be8d2588aa2dcee9.

It broke CI, not just on podman but on Buildah too. Buildah bud
tests require the hello subdirectory.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-08-24 05:16:01 -06:00
202cc433af Update module github.com/onsi/ginkgo/v2 to v2.12.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-23 23:41:24 +00:00
7c0e926820 Merge pull request #19719 from cevich/stop_building_hello
[CI:DOCS] Remove `hello` multi-arch image build
2023-08-23 16:13:23 -02:30
c07f46e15c Merge pull request #19630 from rhatdan/kube
Expand env variables for cmds/entrypoint with format $(ENV)
2023-08-23 13:56:38 -02:30
7e0130f75c Remove hello multi-arch image build
Moved to https://github.com/containers/PodmanHello

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-23 12:10:22 -04:00
f29986178e Merge pull request #19710 from vrothberg/df-benchmarks
[CI:DOCS] hack/perf/system-df.sh: add `df` benchmarks
2023-08-23 10:53:23 -02:30
1b0e64a103 hack/perf/system-df.sh: add df benchmarks
The performance issue in #19467 drove me to add a benchmark for
system-df to avoid regressing on it in the future.

Comparing current HEAD to v4.6.0 yields

```
/home/vrothberg/containers/podman/bin/podman system df ran
201.47 times faster than /usr/bin/podman system df
```

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-08-23 14:17:27 +02:00
7f6bcbba81 Merge pull request #19709 from vrothberg/vendor-storage
vendor c/storage@6902c2d
2023-08-23 09:29:32 -02:30
d22c336287 Merge pull request #19707 from sstosh/cgroupv1-limit-ignore
Ignore the resource limits on cgroups V1 rootless systems
2023-08-23 09:26:55 -02:30
148d95d8df Expand env variables for cmds/entrypoint with format $(ENV)
Kubernetes supports expanding $(FOOBAR) as environment variables within
the kube.YAML. When using podman kube play, we need to do the same, for
supporting these YAML files.

Fixes: #15983

Signed-off-by: Chee Hau Lim <ch33hau@gmail.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-08-23 07:56:17 -04:00
a9c98770e6 Merge pull request #19557 from n1hility/automatic-ports
Implement automatic port reassignment on Windows
2023-08-23 06:49:11 -02:30
2978addf78 Merge pull request #19703 from baude/stopgvproxyfixups
Fixups for stopping gvproxy
2023-08-23 06:18:14 -02:30
e092f887fe vendor c/storage@6902c2d
Mainly to merge fixes for #19467 into the main branch.

Fixes: #19467
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-08-23 10:47:41 +02:00
c416e45766 Ignore the resource limits on cgroups V1 rootless systems
This is a regression for #18052.
When podman ignores the resource limits, s.ResourceLimits needs to be
nil.

[NO NEW TESTS NEEDED]

Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
2023-08-23 13:58:13 +09:00
9e680cbc63 Fixups for stopping gvproxy
Paul found logic errors in my earlier code for finding processes and
sending signals.  Some of the logic errors are associated with how
methods behave on different operating systems.  Created a darwin and
linux approach and a windows approach.

Signed-off-by: Brent Baude <bbaude@redhat.com>

[NO NEW TESTS NEEDED]
2023-08-22 16:00:15 -05:00
7bd60867de Merge pull request #19700 from cevich/remove_lock_test
[CI:DOCS] Revert "GHA: Closed issue/PR comment-lock test"
2023-08-22 17:37:04 -02:30
21c9517b5e Revert "GHA: Closed issue/PR comment-lock test"
This reverts commit f0e8e79c97361df3a9408d665237f08f6a88e96e.
This is intentional, it was needed for testing. See

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-22 14:51:24 -04:00
5e295a940d Merge pull request #19691 from cevich/lock_closed_issues
[skip-ci] Lock closed issues and PRs
2023-08-22 16:05:21 -02:30
260adf567a Merge pull request #19695 from vrothberg/auto-update-docs
[CI:DOCS] update auto-update docs
2023-08-22 15:59:43 -02:30
f0e8e79c97 GHA: Closed issue/PR comment-lock test
This commit limits the blast-radius should the workflow fail
catastrophically.  It also instruments the workflow with a job-level
test-failure to trigger a notification mail.  This commit should be
reverted once the workflow is deemed functional.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-22 13:30:04 -04:00
5477fd38a9 GHA: Add workflow to lock closed issues/PRs
Ref: https://github.com/containers/podman/discussions/19012

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-22 13:30:03 -04:00
75ce47347c [CI:DOCS] update auto-update docs
Rewrite the auto-update man page.  It was quite dusty and out-dated as
it was not mentioning Quadlet at all.  At times it was too verbose about
internal implementation details that users shouldn't need to worry
about.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-08-22 16:19:06 +02:00
f38668e322 Merge pull request #19622 from jakecorrenti/umask-on-play
Set default Umask for `podman kube play`
2023-08-22 06:39:58 -02:30
8354be9cf6 Merge pull request #19683 from lsm5/main-spdx-license
[CI:BUILD] rpm: spdx compatible license field
2023-08-22 06:06:19 -02:30
960b3960f3 Merge pull request #19689 from containers/renovate/github.com-google-uuid-1.x
fix(deps): update module github.com/google/uuid to v1.3.1
2023-08-21 19:52:55 -02:30
1bb96a87c9 Merge pull request #19687 from dfr/freebsd-netstat
libpod: sum per-interface network stats for FreeBSD
2023-08-21 19:49:56 -02:30
8295bbced8 Merge pull request #19690 from containers/renovate/major-ci-vm-image
chore(deps): update dependency containers/automation_images to v20230816
2023-08-21 19:47:22 -02:30
f727428b52 Merge pull request #19663 from rhatdan/ramfs
Add support for ramfs as well as tmpfs in volume mounts
2023-08-21 16:51:06 -02:30
5a6515c6eb Merge pull request #19684 from containers/renovate/golangci-golangci-lint-1.x
chore(deps): update dependency golangci/golangci-lint to v1.54.2
2023-08-21 16:48:34 -02:30
85d0df330f chore(deps): update dependency containers/automation_images to v20230816
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-21 17:52:10 +00:00
bc35e28c03 fix(deps): update module github.com/google/uuid to v1.3.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-21 17:27:05 +00:00
3d00744d29 libpod: sum per-interface network stats for FreeBSD
This sums the metric values from all interfaces similar to the Linux
version.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
2023-08-21 16:00:41 +01:00
5eee8825e8 Set default Umask for podman kube play
Fixes a bug where `podman kube play` fails to set a container's Umask
to the default 0022, and sets it to 0000 instead.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-08-21 10:56:53 -04:00
375eb045ca Merge pull request #19661 from dfr/freebsd-var-run
libpod: use /var/run instead of /run on FreeBSD
2023-08-21 12:24:50 -02:30
30ec94fea4 Merge pull request #19670 from lsm5/rpm-dep-man
[CI:BUILD] rpm: depend on man-db
2023-08-21 11:46:54 -02:30
ef8f4db81c [CI:BUILD] rpm: spdx compatible license field
The lowercase `and` in the License field isn't compatible with spdx
license format.

This commit replaces all `and` with `AND` in the License field in spec.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-08-21 09:52:27 -04:00
e9539768ca chore(deps): update dependency golangci/golangci-lint to v1.54.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-21 13:49:46 +00:00
63a8926e96 Implement automatic port reassignment on Windows
While only leveraged by the WSL backend, this commit also adds core
infrastructure for all other backends for future enhancement.

- Adds a common port cross backend allocation registry to prevent duplicate
  assignment across multiple machine instances
- Introduces logic in Start() that detects OS port conflicts and scans for a
  viable replacement port
- Updates connection definitions and server configuration accordingly
- Utilizes a coordinated file lock strategy to prevent racing overwrites of port
  and connection registries
- WSL backend coordinates locking for containers.conf until a future common
  enhancement exists to replace it

[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2023-08-21 07:23:31 -05:00