22763 Commits

Author SHA1 Message Date
aa2bbeea48 Merge pull request #23010 from ygalblum/quadlet-doc-relative-path
[CI:DOCS] Quadlet - add note about relative path resolution
2024-06-17 15:30:58 +00:00
dca94be028 [CI:DOCS] Quadlet - add note about relative path resolution
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2024-06-17 17:32:34 +03:00
f269485295 Merge pull request #23013 from Luap99/fix-CI
CI: do not install python packages at runtime
2024-06-17 08:48:16 -04:00
c20767120f CI: do not install python packages at runtime
No idea why we need them, it passes without them so I just remove them.
Currently CI is broken as this install is failing on rawhide for some
reason. I don't know what changed there but this is working and unblocks
CI so I like to get this in.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-06-17 13:03:25 +02:00
1d339e4ae3 Merge pull request #22999 from cevich/candidate_release
[skip-ci] Release workflow: Include candidate descriptor
2024-06-14 16:52:34 +00:00
54edf3d8ee Release workflow: Include candidate descriptor
Assist humans by indicating clearly whe a release announcement is
pertaining to a candidate.  Otherwise, it's possible someone may
overlook the `-rcX` version suffix.

Also fix a quoting problem missed in testing.

Signed-off-by: Chris Evich <cevich@redhat.com>
2024-06-13 17:22:03 -04:00
26370c95b7 Merge pull request #22988 from cevich/send_release_mail
[skip-ci] GHA: Send release notification mail
2024-06-13 13:30:29 -04:00
19989380b8 Minor: Fix indentation in GHA release workflow
Simply indent list items two spaces to the right WRT their parent.

Signed-off-by: Chris Evich <cevich@redhat.com>
2024-06-13 10:49:37 -04:00
82973c38e4 GHA: Send release notification mail
Rather than manually crafting what ends up being nearly identical
release e-mails, do it automatically whenever a release is created.

Note: At the time of this commit, there is a possible race condition
with the `mac-pkg.yml` workflow, since it runs in parallel.  It could
fail, or fail to complete prior to the e-mail content being generated.
This should be unlikely, if `release-artifacts.yml` goes through and
compiles every artifact, but it's not guaranteed.

Signed-off-by: Chris Evich <cevich@redhat.com>
2024-06-13 10:48:14 -04:00
ad56dc7e2b GHA: Validate release version number
There's a reasonable chance this workflow will be triggered by a human
(via `workflow_dispatch``), and a non-zero chance with an invalid
version number for which a release should not be created.  Detect this
and provide a way for the operator to debug the source of the error.

Also fix some whitespace inconsistencies.

Signed-off-by: Chris Evich <cevich@redhat.com>
2024-06-13 10:47:26 -04:00
00bcd9aa81 Merge pull request #22733 from nalind/system-check
Add `podman system check`
2024-06-13 10:35:56 +00:00
6180052534 Merge pull request #22983 from edsantiago/exitwitherror-continued
ExitWithError, continued
2024-06-13 10:27:47 +00:00
09f22eb907 Merge pull request #22977 from giuseppe/add-pull-option-cli
podman: add new hidden flag --pull-option
2024-06-13 10:25:00 +00:00
e77e660b37 Merge pull request #22981 from baude/issue22946
[CI:DOCS] Fix typos in podman-build
2024-06-13 10:22:11 +00:00
267d838e38 ExitWithError, continued
Low-hanging fruit: Exit(X) with no error message
is now ExitWithError(X, "")

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-06-12 08:48:19 -06:00
730a215025 podman: add new hidden flag --pull-option
add a new flag that allows to override the pull options configured in
the storage.conf file.

e.g.: --pull-option="enable_partial_images=false" can be specified to
Podman to disable partial pulls even if enabled.

Leave it as a hidden configuration flag for now since the API itself
is marked as experimental in c/storage.

Currently c/storage doesn't honor the overrides, being fixed with
https://github.com/containers/storage/pull/1966

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-06-12 15:48:36 +02:00
5a4416be08 [CI:DOCS] Fix typos in podman-build
Fix two typos in podman build as reported by #22946

FIXES: #22946

Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-06-12 08:03:48 -05:00
8fececcdb9 infra: mark storageSet when imagestore is changed
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-06-12 14:47:35 +02:00
009a2441de Merge pull request #22759 from slp/krun-debug
Enable libkrun provider to open a debug console
2024-06-12 06:30:04 +00:00
798beb47ec Merge pull request #22694 from jmaibaum/quadlet-build
Quadlet: Add support for .build files
2024-06-11 20:41:28 +00:00
49f4ded69f Merge pull request #22964 from lsm5/add-jnovy
[CI:DOCS] Add jnovy as reviewer and approver
2024-06-11 19:22:04 +00:00
f79ede86c6 Merge pull request #22914 from Luap99/start-stopped
libpod: do not reuse networking on start
2024-06-11 19:18:55 +00:00
e0a7adec68 Merge pull request #22957 from rhatdan/squash
--squash --layers=false should be allowed
2024-06-11 19:16:12 +00:00
18c7a55ccd [CI:DOCS] Add jnovy as reviewer and approver
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2024-06-11 09:04:49 -04:00
094bd4ef67 Merge pull request #22962 from containers/renovate/google.golang.org-protobuf-1.x
fix(deps): update module google.golang.org/protobuf to v1.34.2
2024-06-11 11:13:22 +00:00
5b24d1b48c fix(deps): update module google.golang.org/protobuf to v1.34.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-06-11 09:15:15 +00:00
b0780def3e Merge pull request #22954 from Luap99/lint
update golangci-lint to v1.59.1
2024-06-10 21:05:15 +00:00
ad8fc6a74b --squash --layers=false should be allowed
This is the same as what --squash-all is doing, and we already support
--squash with --layers=true since this is the default.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-06-10 13:24:05 -04:00
88308aa23f Merge pull request #22956 from containers/renovate/github.com-checkpoint-restore-checkpointctl-1.x
fix(deps): update module github.com/checkpoint-restore/checkpointctl to v1.2.0
2024-06-10 16:46:08 +00:00
858b3b7def fix(deps): update module github.com/checkpoint-restore/checkpointctl to v1.2.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-06-10 14:51:22 +00:00
e231bf0a46 Merge pull request #22924 from l0rd/fix-branch-name-in-contributing
[CI:DOCS] Rename master to main in CONTRIBUTING.md
2024-06-10 14:50:19 +00:00
2f5ce5d90f Merge pull request #22933 from marinmo/patch-1
[CI:DOCS] podman 5, pasta and inter-container networking
2024-06-10 14:14:25 +00:00
fa4f11facc update golangci-lint to v1.59.1
Includes fixes for new lint warnings from unparam and usestdlibvars.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-06-10 14:57:45 +02:00
3825e73120 Rename master to main in CONTRIBUTING.md
Fix a couple of references to main branch in CONTRIBUTING.md

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-06-10 14:09:13 +02:00
cec6859369 podman 5, pasta and inter-container networking
add information about pasta and how its behaviour changes the way a user needs to think about inter-container connections, as without configuration they aren't able to reach each other (assuming single interface)

Signed-off-by: marinmo <bugzilla@marinmo.org>

Update rootless.md

Co-authored-by: Paul Holzinger <45212748+Luap99@users.noreply.github.com>
Signed-off-by: marinmo <bugzilla@marinmo.org>

Update rootless.md

Co-authored-by: Tom Sweeney <tsweeney@redhat.com>
Signed-off-by: marinmo <bugzilla@marinmo.org>

Update rootless.md

Co-authored-by: Tom Sweeney <tsweeney@redhat.com>
Signed-off-by: marinmo <bugzilla@marinmo.org>
2024-06-07 22:31:00 +02:00
a9de888a15 libpod: do not resuse networking on start
If a container was stopped and we try to start it before we called
cleanup it tried to reuse the network which caused a panic as the pasta
code cannot deal with that. It is also never correct as the netns must
be created by the runtime in case of custom user namespaces used. As
such the proper thing is to clean the netns up first.

Also change a e2e test to report better errors. It is not directly
related to this chnage but it failed on v1 of this patch so we noticed
the ugly error message it produced. Thanks to Ed for the fix.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-06-07 17:50:28 +02:00
7ff1494c47 Merge pull request #22913 from l0rd/winmake-install-target
New Windows makefile (winmake.ps1) targets and Windows build documentation update
2024-06-06 22:31:00 +00:00
37663cbc69 Merge pull request #22926 from edsantiago/exitwitherror-continued
ExitWithError() - continued
2024-06-06 20:40:56 +00:00
f317eb29ab ExitWithError() - continued
Convert Exit(N) to ExitWithError(N, "expected error")

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-06-06 12:00:16 -06:00
550cb07fc0 Enable libkrun provider to open a debug console
When running with "log-level=debug" and libkrun as machine provider,
spawn a Terminal to execute "krunkit" to enable users to have full
access to the VMs console for debugging purposes.

Users obtain an interactive, text console with scrollback. It's possible
to interact with both the kernel and GRUB2. To obtain even additional
debugging information, users can add "console=hvc0" to the linux kernel
command line through GRUB2 (it may be worth considering extending the
initial configuration of the VM to add that argument by default).

Signed-off-by: Sergio Lopez <slp@redhat.com>
2024-06-06 15:20:56 +02:00
dcec81e694 Add new targets on Windows makefile (winmake.ps1)
Add the following targets in winmake.ps1:
- `installer`: builds the Windows installer
- `docs`: builds the documentation HTML pages
- `validatepr`: runs the Linux Makefile `.valiatepr`
                target using podman.
- `lint`: faster validation that runs linter locally

Update of `build_windows.md`:
- removed every reference to the MSYS2 platform
- added instructions to build the installer and linters

Fix https://github.com/containers/podman/issues/21821 and https://github.com/containers/podman/issues/21911

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-06-06 13:41:53 +02:00
0e57573d1e Merge pull request #22917 from containers/renovate/github.com-docker-docker-26.x
fix(deps): update module github.com/docker/docker to v26.1.4+incompatible
2024-06-06 10:34:11 +00:00
5b23a2e1c7 fix(deps): update module github.com/docker/docker to v26.1.4+incompatible
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-06-05 20:02:49 +00:00
be6dbd7202 Merge pull request #22912 from containers/renovate/github.com-crc-org-crc-v2-2.x
fix(deps): update module github.com/crc-org/crc/v2 to v2.37.1
2024-06-05 17:04:34 +00:00
c3728a50e6 Merge pull request #22908 from containers/renovate/golang.org-x-tools-0.x
fix(deps): update module golang.org/x/tools to v0.22.0
2024-06-05 14:52:52 +00:00
2334a7ea6c fix(deps): update module github.com/crc-org/crc/v2 to v2.37.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-06-05 13:20:35 +00:00
42ffa4db43 Merge pull request #22886 from Luap99/fast-system-test-3
test/system: make some tests faster part 3
2024-06-05 13:19:00 +00:00
f4b14c11ef fix(deps): update module golang.org/x/tools to v0.22.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-06-05 10:59:51 +00:00
bdd07c2f7f Merge pull request #22906 from containers/renovate/golang.org-x-net-0.x
fix(deps): update module golang.org/x/net to v0.26.0
2024-06-05 10:58:36 +00:00
a990ca4835 Merge pull request #22905 from dfr/freebsd-kube
libpod: fix 'podman kube generate' on FreeBSD
2024-06-05 10:55:50 +00:00