2988 Commits

Author SHA1 Message Date
a99f4924d9 Merge pull request #2340 from QiWang19/login_lying
Fix `podman login` lying problem
2019-02-17 13:44:45 +01:00
1cb16bd24b Merge pull request #2341 from TomSweeneyRedHat/dev/tsweeney/helpexamples2
Second chunk of Cobra help
2019-02-16 17:31:51 +01:00
0a521e139f Merge pull request #2335 from mheon/enable_detach_rm
Enable --rm with --detach
2019-02-15 22:05:13 +01:00
72b91eb87f Second chunk of Cobra help
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>

Adds examples to Cobra help for a second chunk of commands.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2019-02-15 14:38:46 -05:00
9c1b08fd79 Merge pull request #2353 from giuseppe/honor-storage-opt
podman: honor --storage-opt again
2019-02-15 20:22:06 +01:00
de146b0a2d podman: honor --storage-opt again
possibly a regression after we moved to Cobra

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-02-15 19:43:03 +01:00
40c6d5c98c Merge pull request #2188 from TomSweeneyRedHat/dev/tsweeney/pullall
Add --all-tags to pull command
2019-02-15 14:45:03 +01:00
5a0a1144c5 Merge pull request #2346 from giuseppe/fix-runtime-lookup
libpod.conf: add backward compatibility for runtime_path
2019-02-15 14:21:43 +01:00
7899b738f4 docs: mention the new OCI runtime configuration
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-02-15 13:04:23 +01:00
8aa9b85fa7 libpod: honor runtime_path from libpod.conf
Add backward compatibility for `runtime_path` that was used by older
versions of Podman.

The issue was introduced with: 650cf122e1b33f4d8f4426ee1cc1a4bf00c14798

If `runtime_path` is specified, it overrides any other configuration
and a warning is printed.

It should be considered deprecated and will be removed in future.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-02-15 11:41:17 +01:00
71782812fe rootless: open the correct file
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-02-15 10:53:50 +01:00
d512c4d255 Merge pull request #2305 from rhatdan/tlsverify
Add tlsVerify bool to SearchImage for varlink
2019-02-15 10:50:36 +01:00
81ace5caac Merge pull request #2333 from TomSweeneyRedHat/dev/tsweeney/helpexamples
Add examples for Cobra
2019-02-15 00:07:34 +01:00
c90d3177ad Fix podman login lying problem
Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-02-14 17:00:24 -05:00
ae8cc41295 Merge pull request #2332 from baude/remotevolumeprune
volume prune
2019-02-14 22:52:03 +01:00
1a9128d1e4 Merge pull request #2320 from QiWang19/stdinPW
--password-stdin flag in `podman login`
2019-02-14 22:31:58 +01:00
18bf883eeb Merge pull request #2151 from QiWang19/cp
'podman cp' copy between host and container
2019-02-14 22:31:52 +01:00
1b352ff62a Merge pull request #2298 from mtrmac/multiple-manifests
Vendor in latest c/storage and c/image
2019-02-14 22:05:39 +01:00
2e6fff1f5e Fix error code retrieval for podman start --attach
When we start a container with 'podman run' and it exits and is
removed before we get the code, we grab its exit code from the
Conmon exit file. Podman start --attach wants to do the same, but
was missing the logic. Fix that here.

Also, remove some --rm handling leftover in start. Don't need it
anymore, we have the cleanup process now.

Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-02-14 15:54:34 -05:00
b5653a7f36 Enable --rm with --detach
We can now safely remove detached containers as --rm handling has
moved into the cleanup process.

Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-02-14 15:53:53 -05:00
8ec9eb0a76 Merge pull request #2229 from rhatdan/volumes
Fix volume handling in podman
2019-02-14 21:45:58 +01:00
a7a691809a Add examples for Cobra
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>

First pass of entries for the Examples listed in the Cobra
Help.  Will add others in following PR's.
2019-02-14 15:03:11 -05:00
5f7d4ee73f Add tlsVerify bool to SearchImage for varlink
Cockpit wants to be able to search images on systems without
tlsverify turned on.

tlsverify should be an optional parameter, if not set then we default
to the system defaults defined in /etc/containers/registries.conf.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-02-14 14:31:20 -05:00
52df1fa7e0 Fix volume handling in podman
iFix builtin volumes to work with podman volume

Currently builtin volumes are not recored in podman volumes when
they are created automatically. This patch fixes this.

Remove container volumes when requested

Currently the --volume option on podman remove does nothing.
This will implement the changes needed to remove the volumes
if the user requests it.

When removing a volume make sure that no container uses the volume.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-02-14 13:21:52 -05:00
dd82acd8ba Merge pull request #2336 from baude/addbuildtomain
add build to main and as subcommand to image
2019-02-14 19:16:03 +01:00
5be818e715 enable podman-remote volume prune
allow users to remotely prune volumes.

this is the last volume command for remote enablement.  as such,
the volume commands are being folded back into main because they
are supported for both local and remote clients.

also, enable all volume tests that do not use containers
as containers are not enabled for the remote client yet.

Signed-off-by: baude <bbaude@redhat.com>
2019-02-14 10:55:05 -06:00
476ea5645e add build to main and as subcommand to image
add build as a local and remote-client command in the main
podman menu.  also ensure it is added to the image subcommands
as well.

Signed-off-by: baude <bbaude@redhat.com>
2019-02-14 10:52:30 -06:00
a8b149b406 --password-stdin flag in podman login
Support --password-stdin flag, reads a password from STDIN and pass it to `podman login`.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-02-14 10:09:25 -05:00
0cd2243596 Merge pull request #2321 from baude/remotebuild
podman-remote build
2019-02-14 15:40:52 +01:00
36d962990a 'podman cp' copy between host and container
Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-02-14 09:29:53 -05:00
dfc64e15d7 Merge pull request #2319 from mheon/unconditional_cleanup
Fix manual detach from containers to not wait for exit
2019-02-13 22:55:52 +01:00
29d9ccf381 Merge pull request #2330 from baude/issue1842
build varlink without GOPATH
2019-02-13 22:40:31 +01:00
a05e9c8f60 Merge pull request #2329 from vrothberg/run-pod-completion
completions: add --pod to run/create
2019-02-13 22:40:25 +01:00
ef85dd7950 podman-remote build
add the ability to build images using files local to the remote-client
but over a varlink interface to a "remote" server.

Signed-off-by: baude <bbaude@redhat.com>
2019-02-13 15:36:36 -06:00
a6707e4348 Vendor in latest c/storage and c/image
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2019-02-13 22:23:14 +01:00
e86aec7855 Merge pull request #2331 from baude/issue846
show container ports of network namespace
2019-02-13 21:30:00 +01:00
dd74467fd8 show container ports of network namespace
in cases where a container is part of a network namespace, we should
show the network namespace's ports when dealing with ports. this
impacts ps, kube, and port.

fixes: #846

Signed-off-by: baude <bbaude@redhat.com>
2019-02-13 13:51:23 -06:00
fa3b91dc12 Merge pull request #2316 from baude/remotevolumeinspect
podman-remote volume inspect|ls
2019-02-13 20:20:10 +01:00
4f60f79a27 podman-remote volume inspect|ls
add the ability to list and inspect volumes using the remote
client and varlink

Signed-off-by: baude <bbaude@redhat.com>
2019-02-13 12:43:51 -06:00
d2601eeaa3 build varlink without GOPATH
when gopath was not explicitly set, make would fail due
to the varlink generator.  this symlink in the makefile
addresses that.

fixes: #1842

Signed-off-by: baude <bbaude@redhat.com>
2019-02-13 12:25:08 -06:00
8a16f83b0a Merge pull request #2327 from baude/issue2175
Parse fq name correctly for images
2019-02-13 19:20:10 +01:00
4d72b9c3df completions: add --pod to run/create
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2019-02-13 19:04:28 +01:00
62d88558e7 Merge pull request #2322 from baude/remotepush
podman-remote push
2019-02-13 18:42:00 +01:00
f29a11c201 Parse fq name correctly for images
When parsing a string name for repo and tag (for images output), we
should be using parsenormalizedname and reference.Canonical to
get the proper output.

Resolves: #2175

Signed-off-by: baude <bbaude@redhat.com>
2019-02-13 11:05:20 -06:00
9d4e7fe58b Try disabling --rm on notify_socket test
We have a consistent CI failure with the notify_socket test that
I can't reproduce locally. There's no reason for the test to have
--rm, so try removing it.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-02-13 11:41:20 -05:00
7dcc21f213 podman-remote push
enable podman-remote push so that users can push images from a
remote client.

change in push API to deal with the need to see output over the
varlink connection.

Signed-off-by: baude <bbaude@redhat.com>
2019-02-13 08:44:12 -06:00
df52dac1e7 Merge pull request #2326 from edsantiago/esm/nosudo
get_ci_vm : allow running without sudo
2019-02-13 15:37:16 +01:00
17a5f39739 get_ci_vm : allow running without sudo
More complicated than one would think. The first problem is that,
on certain (but not all) Fedora systems, podman cannot mount
volumes read-only (issue #2312). This is baffling, and since
it's not easily reproducible it's likely that the dev team
will not spend much effort on it. Workaround: instead of bind-
mounting /tmp read-only, bind-mount a *tempdir* (subdirectory)
read-write. This is actually cleaner in some ways but it
leads to complications with the paths we use and with cleanup.

Next, allow overriding the default image and allow asking
for no sudo:

    export GCLOUD_IMAGE=quay.io/edsantiago/gcloud_centos:latest
    export GCLOUD_SUDO=

(yes, that's an equal-sign and EOL. Just an empty string).

The third part, unfortunately, requires a custom image because
the as_dollar_user.sh script (the one that runs gcloud in a
container) is hardwired in a cevich image and needs tweaks
in order to detect rootless and avoid sudo.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2019-02-13 05:27:56 -07:00
037107bc84 Merge pull request #2323 from baude/varlinkconditional
Only build varlink when buildtag is available
2019-02-13 07:19:48 +01:00
2ea8cd1b4f Only build varlink when buildtag is available
Correct mistake that broke things like dlv where we should only
try to add the varlink command to podman when the 'varlink' build
tag is present.

Signed-off-by: baude <bbaude@redhat.com>
2019-02-12 15:53:19 -06:00