4044 Commits

Author SHA1 Message Date
a791242dfb Merge pull request #3162 from giuseppe/fix-hang-waitforfile
util: fix race condition in WaitForFile
2019-05-20 22:00:43 +02:00
9567d87bdf Merge pull request #3152 from rhatdan/remote
install.remote should be separate for install.bin
2019-05-20 20:26:09 +02:00
0804b28825 Merge pull request #3092 from mheon/jhonce_approver
Add Jhon Honce (@jwhonce on github) to OWNERS
2019-05-20 20:17:06 +02:00
f86bb561ef container: move channel close to its writer
let the writer of the channel close it.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-05-20 19:41:02 +02:00
57e781462c util: fix race condition in WaitForFile
enable polling also when using inotify.  It is generally useful to
have it as under high load inotify can lose notifications.  It also
solves a race condition where the file is created while the watcher
is configured and it'd wait until the timeout and fail.

Closes: https://github.com/containers/libpod/issues/2942

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-05-20 19:40:15 +02:00
8d5432932d Merge pull request #3139 from jwhonce/wip/remote_info
Add connection information to podman-remote info
2019-05-20 17:20:59 +02:00
27f9e23a0b Merge pull request #3164 from rhatdan/apparmor
Don't set apparmor if --priviliged
2019-05-20 17:05:08 +02:00
18a953918e Merge pull request #3154 from haircommander/tutorial-conmon
Fixup conmon documentation
2019-05-20 15:46:58 +02:00
8719cb828c Add Jhon Honce (@jwhonce on github) to OWNERS
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-05-20 09:35:17 -04:00
db218e7162 Don't set apparmor if --priviliged
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-05-20 09:11:16 -04:00
a83edf23ac Merge pull request #3158 from kofalt/runlabel-formating
Output name of process on runlabel command
2019-05-20 10:42:52 +02:00
5c0dfd0a4d Merge pull request #3160 from wking/have-higher-precedence-typo
docs/libpod.conf.5: Add "have" to "higher precedence" typo
2019-05-20 09:46:52 +02:00
d85a9bff83 docs/libpod.conf.5: Add "have" to "higher precedence" typo
I'd left this out in a4b483c848 (libpod/container_internal: Deprecate
implicit hook directories, 2018-12-02, #1920).

Signed-off-by: W. Trevor King <wking@tremily.us>
2019-05-19 07:25:05 -07:00
f4a4c7cda0 Output name of process on runlabel command
Signed-off-by: Nathaniel Kofalt <nathaniel@kofalt.com>
2019-05-18 23:31:52 -05:00
ce84c3afdb Merge pull request #3138 from weirdwiz/env-var
Minor fix splitting env vars in podman-commit
2019-05-19 06:31:25 +02:00
ee3381f8f2 Minor fix splitting env vars in podman-commit
`string.Split()` splits into slice of size greater than 2
which may result in loss of environment variables

fixes #3132

Signed-off-by: Divyansh Kamboj <kambojdivyansh2000@gmail.com>
2019-05-19 06:51:30 +05:30
900dd3e633 Fixup conmon documentation
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-05-18 19:33:12 -04:00
00ecbfc131 Merge pull request #2844 from haircommander/cri-o-update
move to cri-o/cri-o and build with containers/conmon
2019-05-17 21:49:10 +02:00
ba612a098c Merge pull request #3142 from cevich/confirm_networking
Cirrus: Confirm networking is working
2019-05-17 21:38:14 +02:00
6154ba4a80 install.remote should be separate for install.bin
For people who want to install podman remote or podman
only we need to separate out the two install commands.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-05-17 14:20:45 -04:00
144244aeed Merge pull request #3104 from giuseppe/initial-cgroup2
rootless: allow resource isolation with cgroup v2
2019-05-17 19:54:13 +02:00
0f31c6bdc4 Cirrus: Confirm networking is working
Thanks to @edsantiago for suggestion to use nc

Signed-off-by: Chris Evich <cevich@redhat.com>
2019-05-17 13:25:59 -04:00
cb0d89c56e Use containers/conmon
There were some build issues updating cri-o to cri-o/cri-o. Since the only thing we need cri-o for is conmon, we should just build using conmon.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-05-17 12:54:47 -04:00
41c4721b0b Merge pull request #3098 from mheon/fix_release_notes
Fix a typo in release notes, and bump README version
2019-05-17 18:36:07 +02:00
07b87b1390 Merge pull request #3149 from nalind/bump-storage
Bump github.com/containers/storage to v1.12.7
2019-05-17 17:36:08 +02:00
4b2d743d53 Fix a typo in release notes, and bump README version
Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-05-17 11:16:10 -04:00
38333970ba s|kubernetes-sigs/cri-o|cri-o/cri-o|g
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-05-17 11:10:09 -04:00
fc4e5f2580 Bump github.com/containers/storage to v1.12.7
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2019-05-17 10:25:36 -04:00
0e20ae0b3a Merge pull request #3146 from vrothberg/fix-3145
remote: version: fix nil dereference
2019-05-17 15:04:39 +02:00
8f7f86d8cd remote: version: fix nil dereference
Fix a nil dereference by passing the PodmanCommand to GetRuntime().

Fixes: #3145
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2019-05-17 11:32:30 +02:00
ee1383a7b9 Merge pull request #3091 from cevich/root_rootless_must_die
Replace root-based rootless tests
2019-05-17 02:25:57 +02:00
1b0b738bef Merge pull request #3140 from mheon/bump-1.3.1
Bump to v1.3.1
2019-05-17 01:20:58 +02:00
a61ebf0446 Bump gitvalidation epoch
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-05-16 17:38:43 -04:00
03918cfd5f Bump to v1.3.2-dev
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-05-16 17:38:43 -04:00
7210727e20 Bump to v1.3.1
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
v1.3.1
2019-05-16 17:38:43 -04:00
e2cd3d2eec Merge pull request #3141 from mheon/revert_3090
Revert "Add VarlinkCall.RequiresUpgrade() type and method"
2019-05-16 22:59:58 +02:00
601fc2ce4f Revert "Add VarlinkCall.RequiresUpgrade() type and method"
This reverts commit bd3154fcf6a48b37cfde5d9b1226900cd863c0d9.

Commit in question may be breaking upstream CI.

Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-05-16 14:36:11 -04:00
a1c654de94 Add connection information to podman-remote info
Refactor client code to break out building connection string from
making the connection.

Example:

client:
  Connection: unix:/run/podman/io.podman
  Connection Type: DirectConnection
  .
  :

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2019-05-16 11:03:22 -07:00
8161802f7d Merge pull request #3135 from mheon/release_notes_1.3.1
More release notes for 1.3.1
2019-05-16 18:21:40 +02:00
ff70b6031a Merge pull request #3090 from jwhonce/wip/upgrade_link
Add VarlinkCall.RequiresUpgrade() type and method
2019-05-16 17:07:12 +02:00
9b81b0dd59 More release notes
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-05-16 10:49:42 -04:00
bd21a99501 Merge pull request #3121 from giuseppe/rootless-error-cni
network: raise a clearer error when using CNI
2019-05-16 16:24:06 +02:00
ae64e4e547 Replace root-based rootless tests
Since CI automation is now executing all tests as a regular user, there
is no need for root-based testing to run special rootless tests.  Remove
them.

However, the root-based rootless tests did include one test for exercising
the '--rootfs' option which is needed.  Add a new general, and more through
test to replace it - meaning it will be executed as root and non-root.

Signed-off-by: Chris Evich <cevich@redhat.com>
2019-05-16 09:44:00 -04:00
2bb1487a00 Merge pull request #2969 from weirdwiz/master
Add unshare to podman
2019-05-16 12:34:31 +02:00
2a961a7113 Add unshare to podman
This command lets the user run a command in a new user namespace like `unshare -u`.
It uses the implementation of unshare in buildah. ( fixes #1388 )

Signed-off-by: Divyansh Kamboj <kambojdivyansh2000@gmail.com>
2019-05-16 13:38:31 +05:30
5445d7d104 Merge pull request #3123 from mheon/release_notes_1.3.1
Release notes for 1.3.1
2019-05-16 08:06:13 +02:00
bffa2189ba Release notes for 1.3.1
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-05-15 19:29:27 -04:00
95d90c1de7 Merge pull request #3127 from mheon/fix_start_race
Ensure that start() in StartAndAttach() is locked
2019-05-16 01:08:05 +02:00
5b3f3c4110 Kill os.Exit() in tests, replace with asserts
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-05-15 16:33:08 -04:00
7ede159465 Merge pull request #3089 from baude/splittest
split remote tests from distro tests
2019-05-15 22:20:04 +02:00