7511 Commits

Author SHA1 Message Date
8700c2fd03 enable inspect tests
A surprisingly big change.  A core problem was that `podman inspect`
allows for passing containers AND images with the default `--type=all`.
This only worked partially as the data was processed in isolation which
caused various issues (e.g., two separate outputs instead of one) but it
also caused issues regarding error handling.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 07:25:31 +02:00
bf4efc1953 Merge pull request #6026 from baude/v2forcesystemtests
system tests must pass
2020-04-28 23:29:20 +02:00
dcac908bbe Merge pull request #6011 from sujil02/podman-save-issue-5234
Fixes podman save fails when specifying an image using a digest fixes-5234
2020-04-28 23:10:20 +02:00
30b27819d0 Merge pull request #5991 from sujil02/pod-rm-test
Fix typos in messages pod rm
2020-04-28 22:40:09 +02:00
517bc28360 system tests must pass
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-28 15:17:00 -05:00
38eb9f4a3d Fixes podman save fails when specifying an image using a digest #5234
Adds check to parse normalized name and create docker archive dst reference
for tagged untagged image. Relevant test case added.

Signed-off-by: Sujil02 <sushah@redhat.com>
2020-04-28 16:16:30 -04:00
b3cfb20aa2 Fix typos in rm messages
Fix typos in pod rm messages

Signed-off-by: Sujil02 <sushah@redhat.com>
2020-04-28 15:57:40 -04:00
23be7b5049 Merge pull request #6024 from baude/v2checkmediatypew
check image media/manifest type for healthchecks
2020-04-28 19:21:50 +02:00
8f57f312d6 Merge pull request #6020 from giuseppe/fix-exec
v2, podman: fix create tests
2020-04-28 19:19:12 +02:00
a255075fe8 check image media/manifest type for healthchecks
before looking up a healthcheck in an image, check to make sure it is a dockerv2schema image.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-28 11:49:58 -05:00
4ed125f7b5 Merge pull request #5907 from sujil02/systemprune-v2
Adding system prune for podman v2
2020-04-28 18:11:39 +02:00
5077aece7e Merge pull request #5954 from lsm5/usable-Makefile-for-packaging
Makefile: install targets should not depend on build targets
2020-04-28 17:28:57 +02:00
e8e00133c1 test: enable exec tests
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 15:32:59 +02:00
a9aa9e2f78 pkg, specgen: do not hardcode user=0 in the config if not specified
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 15:25:59 +02:00
e9a1726f50 Merge pull request #6007 from baude/v2intvolumes
enable volume integration tests
2020-04-28 15:25:16 +02:00
c999f9daf2 specgen: remove dead code
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 14:30:55 +02:00
e76c8527dc cmd: set correct parent for container exec
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 14:15:39 +02:00
f079b4ee5e Merge pull request #6014 from vrothberg/enable-build-tests
enable build tests
2020-04-28 14:14:36 +02:00
34b2ccae4c enable build tests
One test is still being skipped as container creation doesn't yet set
certain data from the image (e.g., PATH).

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-28 08:58:06 +02:00
ebf041652e Merge pull request #6009 from baude/v2hclog
separate healthcheck and container log paths
2020-04-28 00:37:12 +02:00
e78e66c5b9 enable volume integration tests
enabled integration tests for volumes.  there are two exceptions that still need work because of something not yet implemented.

also, add code to deal with the fact that containers conf appears to set a local volume driver where it used to be simply blank.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-27 16:12:06 -05:00
fadd011a80 separate healthcheck and container log paths
instead of using the container log path to derive where to put the healthchecks, we now put them into the rundir to avoid collision of health check log files when the log path is set by user.

Fixes: #5915

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-27 16:05:48 -05:00
ba6d7cf1b3 Merge pull request #6006 from GabyCT/topic/fixtypo
install.md: Fix typo
2020-04-27 22:31:57 +02:00
f172361c7a install.md: Fix typo
This PR fixes a typo on the install.md.

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
2020-04-27 14:56:57 -05:00
f6f7172494 Merge pull request #6000 from mheon/volume_backend_flags
Add support for volumes-from, image volumes, init
2020-04-27 21:53:37 +02:00
8642e256f2 Merge pull request #5978 from rhatdan/ports
Make podman container list == podman ps
2020-04-27 21:27:49 +02:00
618d4be212 Merge pull request #6002 from lsm5/fix-specgen-in-bindings-test
Fix NewSpecGenerator args in pkg/bindings/test
2020-04-27 20:39:27 +02:00
733c38028d Merge pull request #5999 from giuseppe/fix-pod-infra-container
v2, podman: fix pod tests
2020-04-27 20:37:03 +02:00
ccf009d22e Merge pull request #6001 from baude/v2intload
enable load integration tests
2020-04-27 20:34:39 +02:00
e90112a58c Merge pull request #5984 from baude/v2intrestart
enable integration tests for restart
2020-04-27 20:27:36 +02:00
5554698a44 Merge pull request #5975 from giuseppe/fix-pause-tests
[v2] tests: fix pause tests
2020-04-27 20:25:14 +02:00
67ec4e1d27 Improve Entrypoint and Command support
We should not be overwriting the Specgen's Command and Entrypoint
when building the final command to pass in the OCI spec. Both of
these will be provided to Libpod for use in `podman inspect` and
committing containers, and both must be set to the user's input,
not overwritten by the image if unset.

Fix this by moving command generation into OCI spec generation
and not modifying the SpecGenerator when we do so.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-04-27 13:13:21 -04:00
02671a103f Add support for volumes-from, image volumes, init
This should complete Podmanv2's support for volume-related flags.
Most code was sourced from the old pkg/spec implementation with
modifications to account for the split between frontend flags
(volume, mount, tmpfs) and the backend flags implemented here.

Also enables tests for podman run with volumes

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-04-27 13:13:21 -04:00
bee486b91f Fix NewSpecGenerator args in pkg/bindings/test
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2020-04-27 11:29:43 -04:00
6db081fc5e enable load integration tests
fix bug where multiple images can be loaded and have to be able to handle the return of multiple names

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-27 10:20:53 -05:00
1803b28d8c test: enable all pod tests
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 17:08:56 +02:00
b69ba30b14 libpod: set hostname from joined container
when joining a UTS namespace, take the hostname from the destination
container.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 17:08:53 +02:00
d227d44fd6 namespaces: accept pod namespace
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 17:08:52 +02:00
a7318f7364 pkg, ps: add namespaces methods
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 17:08:52 +02:00
ca1c674d2e Merge pull request #5966 from vrothberg/v2-pod-stats
implement pod stats
2020-04-27 16:15:09 +02:00
a7b3310db5 enable integration tests for restart
enable integrations tests for container restart.  fixed bug where --running was not being honored.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-27 09:08:27 -05:00
a83d1a2772 Make podman container list == podman ps
Also make
podman create -p PUBLISHPorts
work.

This PR fixes ps_test.go

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-27 09:51:26 -04:00
fdf64f0c66 Merge pull request #5994 from giuseppe/fix-healthchecks
v2, podman: fix healthchecks
2020-04-27 15:40:24 +02:00
529824ec1e Merge pull request #5997 from giuseppe/fix-pod-create
v2, podman: fix a bunch of "podman pod *" tests
2020-04-27 15:37:58 +02:00
7cb46450fd Merge pull request #5973 from rhatdan/man
[ci:docs] Cleanup man pages for pull and push
2020-04-27 15:35:27 +02:00
ef46687dc5 Merge pull request #5976 from QiWang19/manifest-add-os
Add --os to manifest add
2020-04-27 15:33:00 +02:00
a5bce57218 Merge pull request #5995 from containers/dependabot/go_modules/github.com/rootless-containers/rootlesskit-0.9.4
build(deps): bump github.com/rootless-containers/rootlesskit from 0.9.3 to 0.9.4
2020-04-27 15:30:36 +02:00
cea18bd38c Merge pull request #5996 from vrothberg/ignore
gitignore
2020-04-27 15:27:57 +02:00
2fc54facf2 test: enable pod rm tests
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 14:02:54 +02:00
869a1a211a pkg, pods: report pod rm errors
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 14:02:53 +02:00