722ea2f1f8
runtime: create userns when CAP_SYS_ADMIN is not present
...
when deciding to create a user namespace, check for CAP_SYS_ADMIN
instead of looking at the euid.
[NO TESTS NEEDED] Needs nested Podman
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-04-26 08:58:55 +02:00
e4c269e2d0
rootless: attempt to copy current mappings first
...
when creating a user namespace, attempt to create it first by copying
the current mappings and then fallback to the other methods:
1) use newidmap tools and ...
2) create a user namespace with a single user mapped.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-04-26 08:58:54 +02:00
24f00e4695
rootless: if root is not sub?id raise a debug message
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-04-22 15:32:36 +02:00
21c77846e4
Merge pull request #9495 from rhatdan/groups
...
Add '--group-add keep-groups': supplementary groups into container
2021-04-22 09:29:28 -04:00
a67aec72ed
Merge pull request #10113 from containers/dependabot/go_modules/github.com/containers/common-0.37.0
...
Bump github.com/containers/common from 0.36.0 to 0.37.0
2021-04-22 06:39:43 -04:00
8ebafbde34
Bump github.com/containers/common from 0.36.0 to 0.37.0
...
Bumps [github.com/containers/common](https://github.com/containers/common ) from 0.36.0 to 0.37.0.
- [Release notes](https://github.com/containers/common/releases )
- [Commits](https://github.com/containers/common/compare/v0.36.0...v0.37.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-22 07:59:24 +00:00
979f047d73
Merge pull request #10102 from edsantiago/bats
...
corrupt-image test: fix an oops
2021-04-21 15:45:47 -04:00
382c0ac133
Merge pull request #10103 from pipern/patch-1
...
[CI:DOCS] Typo fix to usage text of --compress option
2021-04-21 15:42:47 -04:00
5c8ba48807
Merge pull request #10097 from containers/dependabot/go_modules/github.com/containers/storage-1.30.0
...
Bump github.com/containers/storage from 1.29.0 to 1.30.0
2021-04-21 15:41:46 -04:00
e356160f41
Add --group-add keep-groups: suplimentary groups into container
...
Currently we have rootless users who want to leak their groups access
into containers, but this group access is only able to be pushed in by
a hard to find OCI Runtime annotation. This PR makes this option a lot
more visable and hides the complexity within the podman client.
This option is only really needed for local rootless users. It makes
no sense for remote clients, and probably makes little sense for
rootfull containers.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-04-21 13:28:36 -04:00
897f6c3a4a
Merge pull request #10088 from rhatdan/no-headers
...
Add --noheading flag to all list commands
2021-04-21 13:20:36 -04:00
9c8277247d
Fixes from make codespell
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-04-21 13:16:33 -04:00
85937044cd
Typo fix to usage text of --compress option
...
Correction of `--format-docker-dir` in to `--format=docker-dir`
Signed-off-by: Nick Piper <nick.piper@cgi.com>
2021-04-21 17:26:50 +01:00
a273d25ed1
corrupt-image test: fix an oops
...
Followup to #10033 : actually implement the system reset test.
And, just out of paranoia, extend the warning-message check.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-04-21 06:09:31 -06:00
544c315665
Merge pull request #10080 from rhatdan/remote
...
podman-remote should show podman.sock info
2021-04-21 08:05:35 -04:00
41677b192a
Merge pull request #8979 from haircommander/full-attach-path
...
Use full attach path, rather than a symlink
2021-04-21 05:25:19 -04:00
8ebeadc3c6
Add --noheading flag to all list commands
...
Currently we have only podman images list --noheading.
This PR Adds this option to volumes, containers, pods, networks,
machines, and secrets.
Fixes: https://github.com/containers/podman/issues/10065
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-04-21 05:22:29 -04:00
0d3aa18f04
Merge pull request #10096 from containers/dependabot/go_modules/github.com/containers/image/v5-5.11.1
...
Bump github.com/containers/image/v5 from 5.11.0 to 5.11.1
2021-04-21 05:17:20 -04:00
5aef11026a
Bump github.com/containers/storage from 1.29.0 to 1.30.0
...
Bumps [github.com/containers/storage](https://github.com/containers/storage ) from 1.29.0 to 1.30.0.
- [Release notes](https://github.com/containers/storage/releases )
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md )
- [Commits](https://github.com/containers/storage/compare/v1.29.0...v1.30.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-21 07:58:32 +00:00
8a3df76ef9
Bump github.com/containers/image/v5 from 5.11.0 to 5.11.1
...
Bumps [github.com/containers/image/v5](https://github.com/containers/image ) from 5.11.0 to 5.11.1.
- [Release notes](https://github.com/containers/image/releases )
- [Commits](https://github.com/containers/image/compare/v5.11.0...v5.11.1 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-21 07:57:31 +00:00
9ef298e784
Merge pull request #10033 from nalind/just-remove-it
...
rmi: don't break when the image is missing a manifest
2021-04-21 02:39:53 -04:00
101571dc6b
Merge pull request #10093 from eriksjolund/fix_markdown_table_bug
...
[CI:DOCS] Fix Markdown table layout bugs
2021-04-20 22:14:53 -04:00
c1f117e526
[CI:DOCS] Fix Markdown table layout bugs
...
* Fix the Markdown table layout bugs that manifest themselves in
corrupted tables in the generated HTML pages
http://docs.podman.io/en/latest/markdown/podman-create.1.html
http://docs.podman.io/en/latest/markdown/podman-run.1.html
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2021-04-20 22:18:44 +02:00
659dc7843c
podman-remote should show podman.sock info
...
Currently podman-remote info does not show socket information.
Fixes: https://github.com/containers/podman/issues/10077
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-04-20 15:56:45 -04:00
fd9dd7065d
rmi: don't break when the image is missing a manifest
...
In libpod/image.Image.Remove(), if the attempt to find the image's
parent fails for any reason, log a warning and proceed as though it
didn't have one instead of failing, which would leave us unable to
remove the image without resetting everything.
In libpod/Runtime.RemoveImage(), if we can't determine if an image has
children, log a warning, and assume that it doesn't have any instead of
failing, which would leave us unable to remove the image without
resetting everything.
In pkg/domain/infra/abi.ImageEngine.Remove(), when attempting to remove
all images, if we encounter an error checking if a given image has
children, log a warning, and assume that it doesn't have any instead of
failing, which would leave us unable to remove the image without
resetting everything.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2021-04-20 15:44:39 -04:00
2a32fc3e40
Merge pull request #10072 from eriksjolund/rewrite_uidmap_documenation
...
[CI:DOCS] Rewrite --uidmap doc in podman-create.1.md and podman-run.1.md
2021-04-20 15:07:11 -04:00
6e5bb9d1d3
[CI:DOCS] Rewrite --uidmap doc in podman-create.1.md and podman-run.1.md
...
Introduce the concept of "intermediate UID" to explain
how --uidmap works when running rootless.
Add Markdown tables to show examples of how UIDs are mapped.
Co-authored-by: Tom Sweeney <tsweeney@redhat.com>
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2021-04-20 20:28:11 +02:00
cf2c3a1f13
Merge pull request #10087 from TomSweeneyRedHat/dev/tsweeney/quickimportfix
...
[CI:DOCS] Add missing dash to verbose option
2021-04-19 22:28:04 -04:00
d84422e14e
Merge pull request #10085 from containers/dependabot/go_modules/github.com/uber/jaeger-client-go-2.27.0incompatible
...
Bump github.com/uber/jaeger-client-go from 2.25.0+incompatible to 2.27.0+incompatible
2021-04-19 16:38:04 -04:00
7f6bcc2008
[CI:DOCS] Add missing dash to verbose option
...
The `--verbose` option in the import man page was
missing a dash, this corrects it.
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2021-04-19 16:24:52 -04:00
a94360a3f7
Merge pull request #10041 from chenk008/add_pidfile_flag
...
Add flag "--pidfile" for podman create/run
2021-04-19 16:22:05 -04:00
37a00c9964
Bump github.com/uber/jaeger-client-go
...
Bumps [github.com/uber/jaeger-client-go](https://github.com/uber/jaeger-client-go ) from 2.25.0+incompatible to 2.27.0+incompatible.
- [Release notes](https://github.com/uber/jaeger-client-go/releases )
- [Changelog](https://github.com/jaegertracing/jaeger-client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/uber/jaeger-client-go/compare/v2.25.0...v2.27.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-19 17:12:04 +00:00
b5e0b292bf
Merge pull request #10056 from mheon/misc_cleanup
...
[NO TESTS NEEDED] Make an advanced layer diff function private
2021-04-19 10:51:58 -04:00
a917bae67d
Merge pull request #10025 from zhangguanzhang/remote-save-dir
...
Fixes podman-remote save to directories does not work
2021-04-19 10:22:52 -04:00
db21c1c0ea
Remove an advanced layer diff function
...
Noticed this while I was poking around in the runtime doing DB
work. The signature of this function makes me a bit uncomfortable
(why should we let people apply arbitrary diffs to layers? Seems
like a good way to break things...) and it's completely unused,
so let's just remove it.
[NO TESTS NEEDED] since this is a pure removal.
Signed-off-by: Matthew Heon <mheon@redhat.com>
2021-04-19 09:17:04 -04:00
69085570f7
Merge pull request #10070 from TomSweeneyRedHat/dev/tsweeney/fixintrotypo
...
[CI:DOCS] Fix introduction page typo
2021-04-19 06:39:53 -04:00
21ae073034
Merge pull request #10069 from EduardoVega/clean-mounts-9618
...
Ensure mount destination is clean, no trailing slash
2021-04-19 05:01:52 -04:00
18d462c41b
Ensure mount destination is clean, no trailing slash
...
Signed-off-by: Eduardo Vega <edvegavalerio@gmail.com>
2021-04-18 09:57:04 -06:00
4ffaa50d05
add it for inspect pidfile
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-18 21:29:12 +08:00
53a1edc3db
[CI:DOCS] Fix introduction page typo
...
Fixes a small typo on the introduction pages.
Fixes : #10042
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2021-04-17 15:13:16 -04:00
a35e16c234
support pidfile on container restore
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-18 00:02:50 +08:00
a1002beb78
fix start it
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 23:35:27 +08:00
4ce7aa6ee8
skip pidfile test on remote
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 22:30:43 +08:00
022bf589c8
improve document
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 21:25:11 +08:00
728b73d7c4
set pidfile default value int containerconfig
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 21:15:23 +08:00
b963a5eb4a
add pidfile in inspection
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 20:56:08 +08:00
f3f7ae5cdd
add pidfile it for container start
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 20:42:21 +08:00
c9f347e9a8
skip pidfile it on remote
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 20:33:37 +08:00
6ff56ab50a
Merge pull request #10018 from jmguzik/more-network-bindings-tests
...
Add network bindings tests: remove and list
2021-04-17 06:35:49 -04:00
676c33f079
Merge pull request #10043 from Luap99/play-kube-ip
...
add --ip to podman play kube
2021-04-17 05:52:51 -04:00
