The old location is deprecated and has been removed in v0.6.0 even. I
did this as extra commit to make cherry-picking easier.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Since this will be required by the runc security update I bump it hare
already to make the runc bump easier. Note while there is 0.6.0 out we
use 0.5.1 intentionally as 0.6 comes with breaking changes that won't
build in our dependencies.
Also note the lib now contains code licensed under MPL-2 which is not
yet approved by the CNCF[1] but because the runc fix requires it we were
advised to just go ahead and update it for now.
[1] https://github.com/cncf/foundation/issues/1154
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Changes made in this commit will fix#16168
The current command in the docs expect a `docker.exe` file to exist in the current working directory.
As this is most likely a typo, changes made in this commit fix this issue.
Signed-off-by: Manuel Thalmann <m@nuth.ch>
In more recent Windows 11 versions (not sure about Windows 10),
Windows now ships its own `curl.exe`,
so PowerShell's "curl"-alias no longer exists.
Changes made in this commit will replace the `curl` alias call with the actual `Invoke-WebRequest` function.
Signed-off-by: Manuel Thalmann <m@nuth.ch>
Bumping the timeout for aarch64 machine tests as I am getting a
consistent timeout where the tests are not completing in the given time.
Signed-off-by: Brent Baude <bbaude@redhat.com>
This allows users to set the associated machine's system connection to the system default when running `podman machine init --now` or `podman machine start`. It also changes the default bbehavior of these commands in that the user will be prompted and asked if they would like to switch the system connection. It also introduces a command line switch called `--update-connection`. If the switch is unset, then the user will be prmpted. If the command value is explicitly set to `false`, the user will not be prompted and the system connection will not be altered. If the value is set to `true`, the system connection will be made the default and the user will not be prompted.
Fixes: https://issues.redhat.com/browse/RUN-3632
Signed-off-by: Brent Baude <bbaude@redhat.com>
Fixes a regression introduced by b2e6d53 that made always failing the
match of the WSL image from the registry with the image in the local
cache. The result was that the WSL machine image was always pulled from
quay.io even if an identical image was in the local cache.
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Bump bundled krunkit to 1.1.1. This is a minor, expedited release
to fix a library linking problem.
Fixes: #27427
Signed-off-by: Sergio Lopez <slp@redhat.com>
The remote client (podman --remote) was incorrectly throwing an error
when --detach-keys="" was specified for attach, run, or start commands.
According to documentation and the v1.7.0 release notes, specifying an
empty string should disable detaching, not cause an error.
Fixes: #27414
Signed-off-by: shiavm006 <shivammittal42006@gmail.com>
This variable is dead code as far as I can tell. I think it
got cargo culted from something similar in skopeo, where it *is*
used:
85598438ce/Makefile (L75)
etc.
(Instead it looks like there's a `PODMANCMD` here)
But I'm effectively using this PR as a way to suggest aligning
with what we're doing in bootc, where we have a core principle
that `Makefile` should *never* itself spawn containers (or VMs etc).
All the rules in Makefile are things that should work when e.g.
building RPMs or debs or the like.
Those tasks are things that are done via `Justfile`:
https://github.com/bootc-dev/bootc/blob/main/Justfile
So for example to align, we'd add a `Justfile` here and then
`make validatepr` would move to `just validatepr`.
Signed-off-by: Colin Walters <walters@verbum.org>
Perhaps exposing some our critical pull requests requirements in a checklist might help users. As of now, we do this as a "soft open".
Co-authored-by: Jan Rodák <hony.com@seznam.cz>
Co-authored-by: Ashley Cui <ashleycui16@gmail.com>
Signed-off-by: Brent Baude <bbaude@redhat.com>
A condition was changed in the refgactor of init where duplicate names would be allowed but no machine was created. Duplicate names are not permitted and should return an error.
Signed-off-by: Brent Baude <bbaude@redhat.com>
