Commit Graph

14720 Commits

Author SHA1 Message Date
Ed Santiago
615099ddb9 System tests: reenable ps --external test
Buildah issue 3544 has been fixed and vendored into podman.
We can reenable a long-skipped test.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-04-11 05:39:39 -06:00
OpenShift Merge Robot
1d01815c10 Merge pull request #13794 from rhatdan/newuidmap
If newuidmap or newgidmap fail, then check their permissions
2022-04-08 13:04:51 -04:00
OpenShift Merge Robot
343778f61a Merge pull request #13811 from flouthoc/container_inspect_entrypoint
container,inspect: convert `Entrypoint` to an array instead of a string
2022-04-08 12:40:23 -04:00
Daniel J Walsh
2508913a0f If newuidmap or newgidmap fail, then check their permissions
Often distributions to not have newuidmap and netgidmap configured
to be setuid. If Podman fails to setup the user namespace, check to
see if these files doe not have the proper protection and tell the user.

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-04-08 10:52:08 -04:00
OpenShift Merge Robot
cdbc33112e Merge pull request #13687 from rhatdan/VENDOR
Vendor in new opencontainers/selinux
2022-04-08 10:42:44 -04:00
Aditya R
0cebd158b6 container,inspect: convert Entrypoint to array instead of a string
Convert container entrypoint from string to an array inorder to make
sure there is parity between `podman inspect` and `docker inspect`

Signed-off-by: Aditya R <arajan@redhat.com>
2022-04-08 18:43:37 +05:30
Daniel J Walsh
dc17195bd9 Vendor in new opencontainers/selinux
Also update vendor of containers/common,buildah,storage,image

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2069586

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-04-08 09:02:52 -04:00
OpenShift Merge Robot
0c9c3e6714 Merge pull request #13810 from vrothberg/images-size
images --size
2022-04-08 07:28:16 -04:00
Valentin Rothberg
e133a06d2f images --size
Add a --size option to podman images to allow for disabling computing
the size of listed images.  If listing images is critical to
performance, user may chose to turn off size computation to speed things
up.

Context: #13755
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2022-04-08 10:09:38 +02:00
OpenShift Merge Robot
4bd35cb01f Merge pull request #13773 from TomSweeneyRedHat/dev/tsweeney/hello
[CI:DOCS] Add Podman Hello to readme.md
2022-04-07 13:21:15 -04:00
OpenShift Merge Robot
f838333b7e Merge pull request #13798 from n1hility/fix-docker-sock
Fix mac docker socket handling
2022-04-07 07:17:35 -04:00
OpenShift Merge Robot
d7ff08aff4 Merge pull request #13796 from n1hility/no-live-set
Prevent set command from updating a running instance
2022-04-07 06:59:32 -04:00
Jason T. Greene
356d534344 Fix docker socket handling
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2022-04-06 23:06:57 -05:00
Jason T. Greene
90ac1ba2a6 Prevent set command from updating a running instance
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2022-04-06 20:39:59 -05:00
tomsweeneyredhat
db7d699508 Add Podman Hello to readme.md
As the title says.  Adds a Podman hello image
to the home page.  I ran it on windows, so had to have
a blue screen to honor that!

[NO NEW TESTS NEEDED]

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2022-04-06 18:26:57 -04:00
OpenShift Merge Robot
6a9c21c456 Merge pull request #13776 from containers/dependabot/go_modules/github.com/BurntSushi/toml-1.1.0
build(deps): bump github.com/BurntSushi/toml from 1.0.0 to 1.1.0
2022-04-06 10:56:52 -04:00
OpenShift Merge Robot
8b6f911e48 Merge pull request #13786 from patrycja-guzik/docu3
[CI:DOCS] Unify examples section across several man pages: pod rm/start/unpause
2022-04-06 04:44:52 -04:00
OpenShift Merge Robot
370821f3e3 Merge pull request #13750 from baude/refactor3
machine refactor 3: add symlinks for sockets
2022-04-06 03:20:50 -04:00
Patrycja Guzik
e73547a635 Unify examples section across several man pages: pod rm/start/unpause
Signed-off-by: Patrycja Guzik <patrycja.k.guzik@gmail.com>
2022-04-05 23:40:07 +02:00
Brent Baude
9c72ea3434 machine refactor 3: add symlinks for sockets
to avoid errors on macos, we use symlinks to long socket names.

Fixes: #12751
Fixes: #13609

Signed-off-by: Brent Baude <bbaude@redhat.com>

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
2022-04-05 13:14:28 -05:00
dependabot[bot]
bd4b9c3d57 build(deps): bump github.com/BurntSushi/toml from 1.0.0 to 1.1.0
Bumps [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/BurntSushi/toml/releases)
- [Commits](https://github.com/BurntSushi/toml/compare/v1.0.0...v1.1.0)

---
updated-dependencies:
- dependency-name: github.com/BurntSushi/toml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-05 12:08:35 +00:00
OpenShift Merge Robot
5e821f7339 Merge pull request #13771 from patrycja-guzik/docu3
[CI:DOCS] Unify examples section across several man pages: init/kill
2022-04-05 05:27:39 -04:00
Patrycja Guzik
dd9eec06a3 Unify examples section across several man pages: init/kill
Signed-off-by: Patrycja Guzik <patrycja.k.guzik@gmail.com>
2022-04-04 22:46:28 +02:00
OpenShift Merge Robot
839744af56 Merge pull request #13696 from Luap99/apiv2-netavark
test/apiv2: support netavark
2022-04-04 14:07:28 -04:00
OpenShift Merge Robot
330205ebed Merge pull request #13490 from gcalin/13266
pod logs enhancements: option to color logs
2022-04-04 13:43:27 -04:00
OpenShift Merge Robot
4f31ade2b2 Merge pull request #13765 from giuseppe/do-not-set-oom-score-adj
specgen: do not set OOMScoreAdj by default
2022-04-04 13:19:35 -04:00
OpenShift Merge Robot
aecb2023d2 Merge pull request #13724 from naveensrinivasan/naveen/feat/set-perms-actions
[CI:DOCS] Set permissions for GitHub actions
2022-04-04 10:47:27 -04:00
Giuseppe Scrivano
164b64ea3b specgen: do not set OOMScoreAdj by default
do not force a value of OOMScoreAdj=0 if it is wasn't specified by the
user.

Closes: https://github.com/containers/podman/issues/13731

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-04-04 15:40:12 +02:00
OpenShift Merge Robot
0e3a704f69 Merge pull request #13757 from andrewaylett/anonymous_volumes
Allow creating anonymous volumes with --mount
2022-04-04 09:29:12 -04:00
OpenShift Merge Robot
48c4015ac1 Merge pull request #13655 from n1hility/dual-pipes
Prefer registering both machine and global pipe on Win
2022-04-04 08:06:02 -04:00
OpenShift Merge Robot
66d30e946d Merge pull request #13739 from cevich/fix_build_push
Fix multi-arch image build version-tag + allow testing in PRs
2022-04-04 03:17:34 -04:00
Naveen
6375a85055 Merge branch 'containers:main' into naveen/feat/set-perms-actions 2022-04-02 16:29:37 -05:00
Andrew Aylett
bf4318e606 Allow creating anonymous volumes with --mount
This fixes #13756.

All the mechanics to create anonymous volumes is already present, but
there's still a validation preventing that path from being taken.  We
remove the validation, which allows the volume to be created
successfully.

Signed-off-by: Andrew Aylett <andrew@aylett.co.uk>
2022-04-02 21:10:40 +01:00
OpenShift Merge Robot
d4394ea368 Merge pull request #13665 from jwhonce/issues/13535
Add build test for .containerignore tar file
2022-04-01 11:59:46 -04:00
OpenShift Merge Robot
23e57575b0 Merge pull request #13594 from cdoern/podVolumes
fix pod volume passing and alter infra inheritance
2022-04-01 09:51:23 -04:00
OpenShift Merge Robot
59fcf0e39d Merge pull request #13744 from giuseppe/allow-privileged-cap-add
specgen: permit --privileged and --cap-add
2022-04-01 09:25:26 -04:00
Giuseppe Scrivano
1cd529b22d specgen: permit --privileged and --cap-add
--cap-add is useful when running a privileged container with UID != 0,
so that individual capabilities can be added to the container process.

Closes: https://github.com/containers/podman/issues/13449

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-04-01 10:15:17 +02:00
Chris Evich
d55c46f8c6 Cirrus: Allow manually running image-build task
Building multi-arch images in a standardized way is complex.  Some
of the builds themselves can take a really long time to run (over
an hour).  Make changes easier to test inside a PR by adding
manually-triggered image-build tasks.  These mirror most of the real
cron-triggered task, without actually pushing the final images.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-03-31 17:07:33 -04:00
Chris Evich
5fcd2a7ac3 Cirrus: Upd VM images to fix multi-arch build bug
Ref: https://github.com/containers/automation_images/pull/122

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-03-31 15:40:30 -04:00
OpenShift Merge Robot
d1f3a2d6a8 Merge pull request #13738 from Luap99/remote-command
cli commands: better error for unsupported commands
2022-03-31 12:46:38 -04:00
Jhon Honce
f8c2df87cb Add build test for .containerignore tar file
Ensure a directory added to .containerignore on client is not included
in tar sent to remote podman API service

* Clean up podman invocations to not include duplicate --remote and
  --url flags
* Use pkill vs. pgrep when cleaning up podman API service in tests
* Add exit code when logging error when testing

Closes #13535

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2022-03-31 08:48:54 -07:00
Paul Holzinger
e5745139a7 cli commands: better error for unsupported commands
When you run podman-remote unsahre for example you currently get:
Error: unrecognized command `podman-remote unshare`

This is because we do not add the command to the cobra tree when we run
in remote mode. However this is a bad user experience since it is not
clear that the command is only supported for local podman. Users are
left wondering why this does not work and could think the documentation
is wrong.

To fix it we add a clear error message:
Error: cannot use command "podman-remote unshare" with the remote podman client

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-03-31 16:20:18 +02:00
OpenShift Merge Robot
4ba71f955a Merge pull request #13732 from flouthoc/reuse-configmap-volume
kube: `configmap` volume should be reused if already exists
2022-03-31 07:30:46 -04:00
Aditya R
daeea48df5 kube: configmap volume should be reused if already exists
`podman play kube` creates a new volume for configmap, if same configmap
is applied again volume can be re-used, there is no need to remove and
re-create the volume again

Signed-off-by: Aditya R <arajan@redhat.com>
2022-03-31 15:07:22 +05:30
OpenShift Merge Robot
c08e8c30a1 Merge pull request #13697 from edsantiago/upgrade_test_matrix
Upgrade tests: reexamine cross-testing matrix
2022-03-30 16:41:21 -04:00
naveensrinivasan
9cacc18c95 Set permissions for GitHub actions
- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
2022-03-30 20:36:23 +00:00
OpenShift Merge Robot
3c75c4a54c Merge pull request #13704 from baude/refactor2
Machine refactor part 2
2022-03-30 16:23:20 -04:00
OpenShift Merge Robot
fbbf5e88fd Merge pull request #13646 from Luap99/slirp4netns-portrange
fix slirp4netns port forwarding with ranges
2022-03-30 13:25:20 -04:00
OpenShift Merge Robot
688213ba19 Merge pull request #13716 from giuseppe/enable-all-controllers-service
systemd: enable all cgroups when running as a service
2022-03-30 12:09:38 -04:00
OpenShift Merge Robot
0cb93e2285 Merge pull request #13712 from Luap99/netns-scope-systemd
rootless netns: move process to scope only with systemd
2022-03-30 10:23:19 -04:00