7064 Commits

Author SHA1 Message Date
4c02aa46c2 attach: fix hang if control path is deleted
if the control path file is deleted, libpod hangs waiting for a reader
to open it.  Attempt to open it as non blocking until it returns an
error different than EINTR or EAGAIN.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-02 09:15:56 +02:00
88455fe704 Merge pull request #5687 from TomSweeneyRedHat/dev/tsweeney/fixmaillist
Touch up mailing list address in README.md
2020-04-02 02:27:06 +02:00
a8cde905d5 Merge pull request #5699 from edsantiago/podmanv2-retry
podmanv2-retry - new helper for testing v2
2020-04-02 01:00:06 +02:00
79f191cb59 Merge pull request #5697 from baude/v2export
podmanv2 export
2020-04-02 00:13:21 +02:00
bb39051616 podmanv2 export
add ability to export a container to a tarball

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-01 16:02:53 -05:00
0f357be5ae Merge pull request #5686 from baude/v2load
podmanv2 load
2020-04-01 22:54:22 +02:00
108ab380f1 podmanv2-retry - new helper for testing v2
./hack/podmanv2-retry will first invoke $PODMAN_V2 with given
arguments. If that fails with any of the following errors:

    unrecognized command
    unknown flag
    unknown shorthand

...it will run $PODMAN_FALLBACK with the same arguments.
Output and exit code will be those of the final podman command,
although be aware that stderr and stdout are combined.

This is a quick-hack script intended for use in v2 testing, to
test implemented commands without noise from unimplemented ones.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-04-01 14:14:00 -06:00
8500ce6b9a podmanv2 load
enable podman load for v2

add reexec into main

add systemd build flag to v2 makefile

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-01 14:10:57 -05:00
0a16372035 Merge pull request #5678 from sshnaidm/buildrpm
Fix repos for CentOS 7 RPM build
2020-04-01 20:18:48 +02:00
d534e52427 Merge pull request #5645 from jwhonce/wip/inspect
V2 podman inspect
2020-04-01 19:08:08 +02:00
46e3b2efb8 V2 podman inspect
* Expose podman container inspect
* Expose podman image inspect

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-01 08:07:43 -07:00
82cbebcbea Merge pull request #5656 from baude/v2imagetag
podman v2 image tag and untag
2020-04-01 16:10:10 +02:00
394f1c26d6 Merge pull request #5684 from baude/v2podps
podmanv2 pod ps
2020-04-01 15:39:35 +02:00
19aa4b4c0b Fix repos for CentOS 7 RPM build
CBS repos are gone, so we need a new repos to configure for RPM.

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2020-04-01 14:01:46 +03:00
26644d7cb8 podman v2 image tag and untag
add the ability to tag and untag images in podmanv2

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-03-31 19:36:26 -05:00
7def91910c podmanv2 pod ps
add the ability to list pods in podmanv2

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-03-31 19:32:37 -05:00
6d36d05447 Merge pull request #5670 from cevich/new_images
Cirrus: Update VM Images
2020-04-01 00:01:10 +02:00
9f5fcc3565 Merge pull request #5655 from baude/v2hcrun
podmanv2 enable healthcheck run
2020-03-31 23:01:19 +02:00
4d66704211 Merge pull request #5683 from larsks/bug/rpm-systemd-tag
add systemd build tag to podman builds
2020-03-31 22:37:15 +02:00
6e8f6cab60 Merge pull request #5675 from vrothberg/v2-pull
podmanV2: implement pull
2020-03-31 21:12:49 +02:00
688e858740 Touch up mailing list address in README.md
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2020-03-31 15:02:39 -04:00
56ab9e4cc8 Merge pull request #5649 from jwhonce/wip/varlink
V2 Move varlink home
2020-03-31 20:34:36 +02:00
4e3010d4e7 Merge pull request #5681 from rhatdan/timeout
Switch to using --time as opposed to --timeout to better match Docker.
2020-03-31 16:32:59 +02:00
7d4ab3fd8f Merge pull request #5518 from containers/dependabot/go_modules/github.com/containers/conmon-2.0.12incompatible
Bump github.com/containers/conmon from 2.0.10+incompatible to 2.0.14
2020-03-31 16:30:34 +02:00
9b86835c39 Merge pull request #5674 from containers/dependabot/go_modules/github.com/rootless-containers/rootlesskit-0.9.3
Bump github.com/rootless-containers/rootlesskit from 0.9.2 to 0.9.3
2020-03-31 16:28:09 +02:00
2753df2973 add systemd build tag to podman builds
Without the systemd build tag, podman will fail with the error "No
support for journald logging".

This commit adds the `systemd` build tag explicitly, rather than
relying on `hack/systemd_tag.sh` (because we're building an rpm and
we've explicitly included systemd-devel as a dependency).

Signed-off-by: Lars Kellogg-Stedman <lars@redhat.com>
2020-03-31 09:42:42 -04:00
4841cd1630 Bump github.com/rootless-containers/rootlesskit from 0.9.2 to 0.9.3
Bumps [github.com/rootless-containers/rootlesskit](https://github.com/rootless-containers/rootlesskit) from 0.9.2 to 0.9.3.
- [Release notes](https://github.com/rootless-containers/rootlesskit/releases)
- [Commits](https://github.com/rootless-containers/rootlesskit/compare/v0.9.2...v0.9.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-03-31 09:05:15 -04:00
3449b27cd1 Switch to using --time as opposed to --timeout to better match Docker.
We need to consistently use --time rather then --timeout throughout the code.
Fix locations where timeout defaults are not set correctly as well.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-03-31 08:50:32 -04:00
3bdad6fa2a podmanV2: implement pull
Implement pulling images for the v2 client.  What I _really_ don't like
is the fact that we are now having a near identical code clone among
`pkg/domain/infra/abi` and `pkg/api/handlers/libpod`.  Partly because we
don't yet have a higher-level pull function and partly because we have
redudancy among `pkg/domain` and `pkg/api`.  Pull might be a high
outlier but I am concerned already by the potential of introducing more
redundancy.  I'd love to `infra/abi` and `pkg/abi` to really use the
same code in the future.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-03-31 13:01:27 +02:00
5884225cb0 Cirrus: Update VM Images
Fedora release 31 (Thirty One)
```
Kernel:  5.5.11-200.fc31.x86_64
Cgroups:  cgroup2fs
conmon-2.0.14-1.fc31-x86_64
containernetworking-plugins-0.8.5-1.fc31-x86_64
containers-common-0.1.41-1.fc31-x86_64
container-selinux-2.129.0-1.fc31-noarch
criu-3.13-5.fc31-x86_64
crun-0.13-1.fc31-x86_64
golang-1.13.6-1.fc31-x86_64
libseccomp-2.4.2-2.fc31-x86_64
package runc is not installed
podman-1.8.2-2.fc31-x86_64
skopeo-0.1.41-1.fc31-x86_64
slirp4netns-0.4.0-20.1.dev.gitbbd6f25.fc31-x86_64
```

Ubuntu 18.04.4 LTS
```
Kernel:  5.0.0-1031-gcp
Cgroups:  tmpfs
conmon-2.0.14~1-amd64
containernetworking-plugins-0.8.5~1-amd64
containers-common-0.1.41~1-all
cri-o-runc-1.0.0-3~dev2-amd64
criu-3.13-2ppa1.18.04-amd64
golang-2:1.14-1longsleep1+bionic-all
libseccomp2-2.4.1-0ubuntu0.18.04.2-amd64
podman-1.8.2~1-amd64
skopeo-0.1.41~1-amd64
slirp4netns-0.4.3~1-amd64
```

Signed-off-by: Chris Evich <cevich@redhat.com>
2020-03-30 17:07:33 -04:00
9c7410d331 Merge pull request #5669 from sshnaidm/cpushare
Revert "Default CPUShares in Inspect are 1024"
2020-03-30 22:01:16 +02:00
19c3b5462f Cirrus: Minor docs update
Signed-off-by: Chris Evich <cevich@redhat.com>
2020-03-30 16:00:01 -04:00
f7241b24e6 Revert "Default CPUShares in Inspect are 1024"
cpu-share is 0 in docker inspect, see
https://github.com/moby/moby/issues/35452

This reverts commit eb229d526c04f17ca8b7e65abba745fd5b465a6c.

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2020-03-30 21:38:19 +03:00
edd623c419 Merge pull request #5667 from edsantiago/apiv2_fixes
fix more swagger inconsistencies
2020-03-30 19:29:10 +02:00
95d9a1e667 Merge pull request #5664 from giuseppe/rootless-make-error-not-fatal
rootless: make cgroup ownership detection not fatal
2020-03-30 17:50:06 +02:00
c77a57ff2c Merge pull request #5662 from containers/dependabot/go_modules/github.com/spf13/cobra-0.0.7
Bump github.com/spf13/cobra from 0.0.6 to 0.0.7
2020-03-30 17:47:28 +02:00
11e79bcd95 fix more swagger inconsistencies
I'm getting really tired of doing this manually.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-03-30 09:45:34 -06:00
7a12e01556 V2 Move varlink home
* move cmd/podman/varlink/* to pkg/varlink to support podmanV2 refactor
* update Makefile
* reformatted all impacted code

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-03-30 08:18:35 -07:00
0fa01c8bf8 Merge pull request #5643 from edsantiago/test_apiv2
API v2 tests: usability improvements
2020-03-30 16:51:58 +02:00
3838bb0062 Bump github.com/containers/conmon
Bumps [github.com/containers/conmon](https://github.com/containers/conmon) from 2.0.10+incompatible to 2.0.14
- [Release notes](https://github.com/containers/conmon/releases)
- [Changelog](https://github.com/containers/conmon/blob/master/changelog.txt)
- [Commits](https://github.com/containers/conmon/compare/v2.0.10...v2.0.14)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-03-30 10:30:33 -04:00
16fa9b6a0b Bump github.com/spf13/cobra from 0.0.6 to 0.0.7
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 0.0.6 to 0.0.7.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](https://github.com/spf13/cobra/compare/v0.0.6...0.0.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-03-30 10:00:55 -04:00
cc22b94a7a Merge pull request #5602 from rhatdan/vendor
Update vendor of boltdb and containers/image
2020-03-30 15:54:36 +02:00
8193751287 Merge pull request #5639 from vrothberg/v2-pod-top
V2 pod top
2020-03-30 13:59:37 +02:00
f59c948928 rootless: make cgroup ownership detection not fatal
do not fail if we cannot detect the cgroup ownership.  The detection
fails when running in a container, since the cgroup showed in
/proc/self/cgroup is not accessible, due to the runtime mounting it
directly as the cgroup root.

Closes: https://github.com/containers/libpod/issues/5488

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-03-30 12:24:10 +02:00
a84c006368 podmanv2 enable healthcheck run
run healthcheck with podmanv2

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-03-29 18:48:29 -05:00
598bb53d46 Merge pull request #5523 from xcffl/patch-1
Fix path of tmp_dir
2020-03-29 14:12:58 +02:00
dabfa10b65 Merge pull request #5641 from baude/v2commit
podmanv2 commit
2020-03-29 13:22:25 +02:00
366001fb5f Update vendor of boltdb and containers/image
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-03-29 06:16:27 -04:00
edec8ccf3f swagger: top: remove "Docker" from the identifiers
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-03-28 17:32:27 +01:00
9812804f75 podmanv2: implement pod top
Implement `podman pod top` for podmanV2.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-03-28 17:32:22 +01:00