48ab4aec31
podman kube play: fix broken annotation parsing
...
If a user did not set an equal sign in the annotation that old code
would panic when accessing the second element in the slice.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-11 15:43:21 +01:00
e916f49f0b
cli: podman kube play --annotation use StringArray()
...
This option accepts arbitrary input so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-11 15:43:20 +01:00
47b65086ee
cli: podman image trust set --pubkeysfile use StringArray()
...
This option accepts a file path so we should allow commas in it.
There ar eno tests for this option, I have no idea what this option does
nor how to use it so I cannot write one.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-11 15:43:20 +01:00
cdb178e954
cli: podman push --encryption-key use StringArray()
...
This option accepts a file path so we should allow commas in it.
Also add tests for --decryption-key
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-11 15:43:20 +01:00
3e1b9146f7
cli: podman pull --decryption-key use StringArray()
...
This option accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-11 15:43:20 +01:00
71b3437a81
Merge pull request #20979 from edsantiago/emergency
...
EMERGENCY: fix broken CI
2023-12-11 14:41:03 +00:00
6415471dcd
EMERGENCY: fix broken CI
...
Broken by #20827 .
Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-12-11 06:28:21 -07:00
611ba2ff31
Merge pull request #20827 from kaivol/userns-auto-intermediate-id-lookup
...
Support lookup of intermediate ID for uidmapping and gidmapping in `--userns=auto`
2023-12-11 10:19:14 +00:00
952c708906
added system test
...
Signed-off-by: kaivol <github@kavol.de>
2023-12-10 14:16:08 +01:00
c87311b6d5
Merge pull request #20945 from Luap99/string-array
...
cli: use StringArray over StringSlice Part 1
2023-12-09 21:11:39 +00:00
d513749085
Merge pull request #20914 from baude/machinehypervregression
...
Fix regression in e2e machine test suite
2023-12-08 16:16:24 +00:00
0a9914f3b2
Merge pull request #20947 from edsantiago/treadmill_cleanup
...
buildah treadmill: cleaner YAML, uglier script
2023-12-08 14:48:27 +00:00
289d6fed6c
Merge pull request #20925 from containers/renovate/actions-setup-go-5.x
...
[skip-ci] Update actions/setup-go action to v5
2023-12-08 14:26:26 +00:00
44a9371164
Merge pull request #20772 from Luap99/rootlessnetns
...
use rootless netns from c/common
2023-12-08 14:23:40 +00:00
4590b663a7
add test for podman exec --env-file
...
There was no test for this option, resuse existing podman run
--env-file test for exec as well.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:24 +01:00
06cee546a3
cli: podman exec --env-file use StringArray()
...
This option accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
7866f6c6e1
cli: podman run/create --blkio-weight-device use StringArray()
...
This option accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
432be13301
cli: podman run/create --device-{read,write}-bps use StringArray()
...
This option accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
8de13271ca
cli: podman run/create --device-{read,write}-iops use StringArray()
...
This option accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
e763cc62b7
cli: podman run/create --device use StringArray()
...
This options accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
833163ff3e
add podman create --label-file test
...
There was no test for this option so I added one.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
19571f7509
cli: podman run/create --label-file use StringArray()
...
This option accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:22 +01:00
24d08a94d8
cli: podman run/create --decryption-key use StringArray()
...
This option accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:10 +01:00
8edfea423e
Merge pull request #20948 from cfergeau/typo
...
machine: usb: Fix 'passtrough' typo
2023-12-08 13:06:43 +00:00
67a840fefb
Merge pull request #20949 from lsm5/crun-wasm-podman-next-fcos
...
[CI:BUILD] override crun-wasm in fcos + podman-next image build
2023-12-08 13:03:55 +00:00
f9b2da3eb7
[CI:BUILD] override crun-wasm in fcos + podman-next image build
...
crun-wasm depends on the same epoch:version-release as crun so
overriding `crun` but not `crun-wasm` will cause installation issues
like:
```
error: Could not depsolve transaction; 1 problem detected:
Problem: package crun-wasm-1.11.1-1.fc39.x86_64 from @System requires crun = 1.11.1-1.fc39, but none of the providers can be installed
- cannot install both crun-102:1.12-1.20231205201336970037.main.19.g90b21dd.fc39.x86_64 from @commandline and crun-1.11.1-1.fc39.x86_64 from @System
- cannot install both crun-102:1.12-1.20231205201336970037.main.19.g90b21dd.fc39.x86_64 from @commandline and crun-1.11.1-1.fc39.x86_64 from updates-archive
- conflicting requests
```
This commit overrides both crun and crun-wasm from what's found in
podman-next.
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2023-12-08 17:10:41 +05:30
7dc7ae10ed
Merge pull request #20931 from baude/issue20916
...
[CI:DOCS]use nginx in podman tutorial
2023-12-08 11:36:00 +00:00
6c2a0196a9
machine: usb: Fix 'passtrough' typo
...
[NO NEW TESTS NEEDED]
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
2023-12-08 12:24:39 +01:00
201920f6a4
cli: podman run/create --chrootdirs use StringArray()
...
This options accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:02 +01:00
dbbec99361
cli: podman run/create --log-opt use StringArray()
...
This option accepts arbitrary input so we should allow commas in it.
Fixes #20064
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:01 +01:00
b011aa4430
cli: podman run/create --env-file use StringArray()
...
This option accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:01 +01:00
ef10073b51
cli: podman run/create --annotation use StringArray()
...
This option accepts arbitrary input so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:01 +01:00
c5258d4630
cli: podman --hooks-dir use StringArray()
...
This option accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:01 +01:00
12c39ffda2
cli: podman --module use StringArray()
...
This option accepts a file path so we should allow commas in it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:01 +01:00
c97560841f
cli: add docs for StringArray vs StringSlice options
...
In short always use StringArray over StringSlice.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:16:52 +01:00
1ebd507fbf
Fix regression in e2e machine test suite
...
A simple regression was introduced to the test suite that overrode the
default image for hyperv testing.
Signed-off-by: Brent Baude <bbaude@redhat.com>
2023-12-07 21:06:46 -06:00
95145d957d
buildah treadmill: cleaner YAML, uglier script
...
There's a stanza in .cirrus.yml that only "runs" in
the treadmill cron job ... but that job is long gone.
The task actually runs in the buildah treadmill PR, #13808 ,
but that's not obvious to someone reading .cirrus.yml.
This is a maintenance burden. Remove it.
Because rootless bud tests are still important, and we
still want to run them in the treadmill PR, modify the
treadmill script itself so it (ugh) injects rootless jobs
into the buildah_bud test matrix. This is super fragile
but acceptable because I am the only one who ever runs
the treadmill script. I will notice if this breaks.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-12-07 17:55:16 -07:00
deab493ca6
Merge pull request #20930 from rhatdan/VENDOR
...
Update vendor of containers/storage
2023-12-07 21:29:42 +00:00
f8c031170b
Merge pull request #20928 from edsantiago/flakey_since
...
CI: systests: fix flaking --since test
2023-12-07 17:36:51 +00:00
8b6eb806c7
Merge pull request #20937 from eriksjolund/fix-issue-20390
...
[CI:DOCS] compat api: fix formatting syntax
2023-12-07 17:34:12 +00:00
0d1b90d367
CI: systests: fix flaking --since test
...
Very rare flake, probably caused by my nemesis, podman run -d
Solution: keep the sleep-1 (vs using nanosecond resolution),
but make sure we first wait for the output from the container.
Also, bump down the iteration delay in wait_for_output, from 5s to 1.
Thanks to Paul for noticing that.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-12-07 09:41:07 -07:00
09d7260e1c
Merge pull request #20929 from n1hility/fix-user-mode-init
...
Fix user-mode net init flag on first time install
2023-12-07 15:13:57 +00:00
1e3b7ccb7e
Merge pull request #20936 from containers/renovate/actions-stale-9.x
...
[skip-ci] Update actions/stale action to v9
2023-12-07 14:43:33 +00:00
4687654100
Merge pull request #20933 from n1hility/improve-ps-errors
...
Improve error handling in win-lib.ps1
2023-12-07 14:18:50 +00:00
9a963221b5
[CI:DOCS]use nginx in podman tutorial
...
the podman tutorial refers to an old httpd image based on Fedora 29. It
is x86_64 only so Apple Silicon Macs and RPI's cannot follow the
tutorial. Switch to nginx
Fixes : #20916
[NO NEW TESTS NEEDED]
Signed-off-by: Brent Baude <bbaude@redhat.com>
2023-12-07 07:54:28 -06:00
a1cc99dd46
[CI:DOCS] compat api: fix formatting syntax
...
Reuse text from podman api
Fixes https://github.com/containers/podman/issues/20390
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2023-12-07 14:27:47 +01:00
cac4aa3b44
[skip-ci] Update actions/stale action to v9
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-12-07 13:19:55 +00:00
19457f3823
system service: split out cgroups call into linux specific file
...
So that we do not cause compile errors on freebsd.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-07 11:26:36 +01:00
03d411abc0
libpod: split out cgroups call into linux specific file
...
So that we do not cause compile error on freebsd.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-07 11:24:47 +01:00
32c25c6026
pkg/specgen/generate: NOP verifyContainerResources() on freebsd
...
There is no point in calling into cgroup specific code as freebsd does
not support cgroups.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-07 11:24:47 +01:00