19870 Commits

Author SHA1 Message Date
362747cfab podmansh man page UID=$(id -u lockedu) is not allowed
Switch man page to user USERID instead of UID, since UID environment
variable is set at login, and is not allowed to be changed.

UID=foobar
bash: UID: readonly variable

Fixes: https://github.com/containers/podman/issues/19646

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-08-16 14:16:33 -04:00
9cd4286922 Merge pull request #19596 from baude/allowdownload
enabled hyperv image downloads
2023-08-16 09:52:18 -02:30
7836401c8f Merge pull request #19626 from michalbiesek/feat-riscv64-support
Add riscv64 support for cross compilation
2023-08-16 06:45:37 -02:30
464e97f65e Merge pull request #19638 from containers/renovate/setuptools-68.x
Update dependency setuptools to ~=68.1.0
2023-08-16 04:48:22 -02:30
8326c81db6 Merge pull request #19627 from containers/renovate/github.com-containers-ocicrypt-1.x
fix(deps): update module github.com/containers/ocicrypt to v1.1.8
2023-08-16 04:37:49 -02:30
6a3f09e8a7 Update dependency setuptools to ~=68.1.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-15 20:35:31 +00:00
c8b7c77305 Merge pull request #19624 from TomSweeneyRedHat/dev/tsweeney/fixbuildmd
[CI:DOCS] Fix git build example in build page
2023-08-15 11:05:30 -02:30
0e37599e8d Merge pull request #19621 from edsantiago/manifest_quay
CI: e2e manifest_test: use image from quay
2023-08-15 11:02:55 -02:30
1d5890bcd5 Add riscv64 architecture to the cross build target
[NO NEW TESTS NEEDED]

Signed-off-by: Michal Biesek <michalbiesek@gmail.com>
2023-08-15 15:29:29 +02:00
252f51de84 GetFcosArch add riscv64 arch
[NO NEW TESTS NEEDED]

Signed-off-by: Michal Biesek <michalbiesek@gmail.com>
2023-08-15 15:29:24 +02:00
98e7d7af01 Update WSL backend to be compat with FCOS defaults
container/common Config was recently updated to use FCOS
default names, since Windows HyperV backend needs them,
and these are common with other providers.

Map this to values the WSL backend expects.

[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2023-08-15 07:48:59 -05:00
9e14e3ebe5 enabled hyperv image downloads
now that we have public hypverv fcos artifacts, we can download them
instead of requiring a special build.

Signed-off-by: Brent Baude <bbaude@redhat.com>

[NO NEW TESTS NEEDED]
2023-08-15 07:45:29 -05:00
3e2e360b9e fix(deps): update module github.com/containers/ocicrypt to v1.1.8
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-15 04:04:14 +00:00
abd35d4d37 [CI:DOCS] Fix git build example in build page
The git repo that was used for the example of a git build:

  `podman build https://github.com/scollier/purpletest`

no longer exists.  Someone reached out to @rhatdan about this
and he suggested using the Podman Hello World repo.  However,
that didn't exist until a little bit ago, so I've updated
the man page with a pointer there.  That should be a lot more
stable.

[NO NEW TESTS NEEDED]
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2023-08-14 17:45:02 -04:00
3e8f19be9d Merge pull request #19619 from cevich/remove_ec2_experimental
Cirrus: Remove EC2 experimental flag
2023-08-14 16:22:44 -02:30
0c52d10040 CI: e2e manifest_test: use image from quay
Flake suppression: going with the one-basket model of egg storage,
switch manifest_test to use an image on quay.io (was: k8s.io).

Closes: #19148

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-08-14 12:45:42 -06:00
c742ec6fea Merge pull request #19617 from edsantiago/sphinx_ignore
[CI:DOCS] sphinx: skip options include dir
2023-08-14 15:45:04 -02:30
824c76616a Merge pull request #19591 from matejvasek/fix-build-pull-compat
Fix pull parameter parsing for compat `/build` endpoint
2023-08-14 15:36:54 -02:30
31dc422243 Cirrus: Remove EC2 experimental flag
The VM-naming feature is now mainstream.
Ref: https://github.com/cirruslabs/cirrus-ci-docs/ issue 1051

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-14 11:43:21 -04:00
1c37acceb5 Merge pull request #19613 from PeterWhittaker/main
Update rootfs.md: Fix formatting and wording of idmap option
2023-08-14 10:41:56 -04:00
4c7546cb31 sphinx: skip options include dir
Tell sphinx not to process the "options" dir, those files
are not to be published.

Context: websearching for podman volume info, I stumbled upon:

   https://docs.podman.io/en/latest/markdown/options/volume.html

...and panicked because I saw '<<container|pod>>', the options
include-file syntax that should never be seen by users. I thought
the filter script was broken.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-08-14 08:12:16 -06:00
6727644b18 Merge pull request #19595 from Luap99/top-output-flake
fix podman top missing output flake
2023-08-14 09:57:26 -04:00
345b9b0295 Update rootfs.md: Fix formatting and wording of idmap option
The newly introduced `idmap` section of rootfs lacked a header
(comparable to Overlay Rootfs Mounts), had odd formatting, and
wording that differed from other instances of idmap, e.g., the
one in the --volume section. This commits addresses those issues.

Signed-off-by: Peter Whittaker <PeterWhittaker@SphyrnaSecurity.com>
2023-08-14 09:21:24 -04:00
f33b01b731 fix: Docker API compatible bool deserialization
In Docker anything but "", "0", "no", "false", "none" (ignoring case) is considered to be true.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2023-08-14 15:09:14 +02:00
4cb2d48ca4 Revert "compat,build: pull must accept string"
This reverts commit 5b148a0a68360892f57603b77e73c69e32fb7b7e.

Reverting to treating the `pull` query parameter as a boolean.
Because of deceiving Docker API documentation it was assumed that the
parameter is pull-policy, however that is not true. Docker does treat
`pull` as a boolean. What is interesting is that Docker indeed accepts
strings like `always` or `never` however Docekr both of these strings
treat as `true`, not as pull-policy. As matter of the fact it seems
there is no such a thing as pull-policy in Docker.

More context https://github.com/containers/podman/issues/17778#issuecomment-1673931925

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2023-08-14 15:01:53 +02:00
0b612a9a2d Merge pull request #19576 from edsantiago/logpartial_flake
New partial-line test is flaking
2023-08-14 08:08:06 -04:00
2487ea4399 Merge pull request #19587 from cevich/kill_bench_job
[CI:BUILD] Cirrus: Prune defunct job + fix noop alias
2023-08-14 07:39:25 -04:00
de6bdd1907 Merge pull request #19152 from geichelberger/add-host-gateway-support
Add support for host-gateway
2023-08-14 05:47:59 -04:00
615a9cf29d Merge pull request #19598 from containers/renovate/golangci-golangci-lint-1.x
chore(deps): update dependency golangci/golangci-lint to v1.54.1
2023-08-14 04:15:13 -04:00
84bd6c71fa Merge pull request #19607 from wjt/performance-machinectl-shell
[CI:DOCS] Add missing verb in machinectl example
2023-08-14 03:51:59 -04:00
79d87f4674 Merge pull request #19599 from ashley-cui/rel
[CI:DOCS] Update Release Notes and Release Process
2023-08-14 03:18:26 -04:00
68bd81470a Add missing verb in machinectl example
Without the verb 'shell', the invocation fails with:

    Unknown command verb testuser@

Signed-off-by: Will Thompson <will@willthompson.co.uk>
2023-08-13 11:52:56 +01:00
6ab38e55e7 Merge pull request #19589 from lsm5/main-packit
[CI:BUILD] Packit: add back fedora-eln targets
2023-08-11 15:23:25 -04:00
78d6cd4c9e [CI:DOCS] Update Release Notes and Release Process
Signed-off-by: Ashley Cui <acui@redhat.com>
2023-08-11 11:16:54 -04:00
b6349017af chore(deps): update dependency golangci/golangci-lint to v1.54.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-11 13:40:49 +00:00
4b80492bd2 fix podman top missing output flake
Sometimes there is no output displayed from the podman top command but
no error is shown either. Looking at the code I think the issue here is
that we do not wait for the output reader to end as it runs in a
different goroutine. Thus the last lines of output might be missing.

The fix is simply to wait for said goroutine to finish before returning.
While at it also fix the missing scanner error check and return the read
errors back to the caller.

[NO NEW TESTS NEEDED] It is a flake.

Fixes #19504

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-08-11 13:43:23 +02:00
5908999e6d New partial-line test is flaking
...possibly because we somehow ended up with a two-line
log file for a simple 'echo hi'? Make our timestamp-getting
code safer by adding 'head -1'.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-08-10 17:43:50 -06:00
555b4f930d [CI:BUILD] Packit: add back fedora-eln targets
Fedora ELN targets were removed in the switch to ephemeral coprs. Add
them back.

Podman rpm doesn't depend on go-md2man package anymore and instead uses
vendored go-md2man for building manpages, so that's no longer a reason
for build failures on Fedora ELN.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-08-10 15:13:53 -04:00
f0dac36770 Cirrus: Prune defunct job + fix noop alias
The mechanism fueling the benchmarks job has long since been removed.
Running the job is useless now, remove it.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-10 11:38:47 -04:00
a60bafea48 Merge pull request #19573 from edsantiago/env-tests
systests: tests for --env and --env-file
2023-08-10 09:33:00 -04:00
14e290a306 Merge pull request #19358 from umohnani8/buildfarm-2
Add phase 1 of podman farm subcommands
2023-08-10 09:29:33 -04:00
970976a7f5 Merge pull request #19503 from edsantiago/journalctl_unreliable
CI: e2e: add delay before podman logs or journalctl
2023-08-10 08:39:25 -04:00
df28df1aee systests: tests for --env and --env-file
We've made rather a mess of those options, due to lack of testing.

Here we have a first step toward regression tests. --env is OK,
but there are three special-case exceptions in --env-file for
three incompatibilities introduced by #19096.

To be continued, but probably in future PRs. We need this ASAP
to prevent us from making any more regressions.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-08-09 14:11:00 -06:00
bcebcad1fd Update system connection add & remove
Add new --farm flag to podman system connection add so that
a user can add a new connection to a farm immediately.
Update system connection remove such that when a connection is
removed, the connection is also removed from any farms that have it.
Add docs and tests for these changes.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2023-08-09 13:37:37 -04:00
310f971fcf Add tests for podman farm
Add tests for podman farm create, remove, and update.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2023-08-09 13:37:37 -04:00
dce3ef3c42 Add podman farm update command
Podman farm update allows users to update a farm by addig
connections, removing connections, or changing the default farm.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2023-08-09 13:37:37 -04:00
44a704dfcf Add podman farm remove command
Podman farm remove allows users to remove one or more
existing farms.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2023-08-09 13:37:37 -04:00
59a8140f1f Add podman farm list command
The podman farm list command allows users to list
the existing farms.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2023-08-09 13:37:37 -04:00
6fcdf1a190 Add podman farm create command
The podman farm create command allows users to create
farms from the avaiable podman system connections.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2023-08-09 13:37:37 -04:00
1d5ef29f01 Add podman farm subcommand
Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2023-08-09 13:37:33 -04:00