13952 Commits

Author SHA1 Message Date
2cdab5d539 Merge pull request #12824 from containers/dependabot/go_modules/github.com/BurntSushi/toml-1.0.0
Bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0
2022-01-12 15:26:20 +01:00
c75c6ce908 Merge pull request #12821 from vrothberg/vendor-common
vendor latest c/common
2022-01-12 14:18:20 +01:00
47374aac86 Bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0
Bumps [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml) from 0.4.1 to 1.0.0.
- [Release notes](https://github.com/BurntSushi/toml/releases)
- [Commits](https://github.com/BurntSushi/toml/compare/v0.4.1...v1.0.0)

---
updated-dependencies:
- dependency-name: github.com/BurntSushi/toml
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-12 12:09:14 +00:00
485305a5fc vendor latest c/common
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2022-01-12 12:43:21 +01:00
8365d49a05 Merge pull request #12819 from rhatdan/machine
add additional fields to podman machine ls --json
2022-01-12 05:39:27 -05:00
6945b37850 Merge pull request #12813 from rhatdan/secrets
Fix permission on secrets directory
2022-01-12 09:04:19 +01:00
827299099e Merge pull request #12818 from edsantiago/emergency_buildah_skips
buildah bud tests: skip failing tests
2022-01-12 00:16:07 +01:00
6e208c2226 add additional fields to podman machine ls --json
[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-11 16:42:56 -05:00
6fa077750a buildah bud tests: skip failing tests
Emergency workaround for github's deprecation of git://

   https://github.blog/2021-09-01-improving-git-protocol-security-github/

Two buildah tests rely on 'git://' URLs. These now fail. They
have been fixed in the buildah repo[1] but it will take time
to vendor that in. ITM, we need to get CI passing. Skip those
two failing tests.

 [1] https://github.com/containers/buildah/pull/3701

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-01-11 14:20:29 -07:00
83b0fb4696 Fix permission on secrets directory
This directory needs to be world searchable so users can access it from
different user namespaces.

Fixes: https://github.com/containers/podman/issues/12779

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-11 16:19:50 -05:00
3404ad042d Merge pull request #12694 from rhatdan/depend
Add podman rm --depend
2022-01-11 16:15:56 -05:00
8f2358eeaa Add podman rm --depend
This option causes Podman to not only remove the specified containers
but all of the containers that depend on the specified
containers.
Fixes: https://github.com/containers/podman/issues/10360

Also ran codespell on the code

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-11 14:33:54 -05:00
c4142ce0cf Merge pull request #12807 from Luap99/macvlan-hostip
fix host.containers.internal entry for macvlan networks
2022-01-11 14:21:58 -05:00
4db1affda6 Merge pull request #12748 from flouthoc/ign_add_proxy_vars
ignition: set `HTTP` proxy variable and `SSL_CERT_FILE` from `host` -> `machine`.
2022-01-11 16:30:10 +01:00
76212917c4 Merge pull request #12806 from rhatdan/machine1
It takes some time to start a VM
2022-01-11 10:22:27 -05:00
e4c613e420 Merge pull request #12805 from rhatdan/machine
Pretty Print output of podman machine ls --format json
2022-01-11 10:21:39 -05:00
f04465bfe6 fix host.containers.internal entry for macvlan networks
For ip/macvlan networks we cannot use the gateway as address for this
hostname. In this case the gateway is normally not on the host so we
just try to use a local ip instead.

[NO NEW TESTS NEEDED] We cannot run macvlan networks in CI.

Fixes #11351

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-01-11 16:10:01 +01:00
6d5ad9c110 It takes some time to start a VM
We are seeing some issues with users not understanding which VM they are
starting, and if the VM takes a long time to start, they do not know
where to look.

Moving the name to before the VM starts at least allows them to realize
they are starting the wrong VM.

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-11 08:52:27 -05:00
c085fb3c97 Pretty Print output of podman machine ls --format json
Make JSON more prominent in podman machine ls --help and man page.

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-11 06:36:45 -05:00
ed9ef59e7e Merge pull request #12780 from rhatdan/pod
Use the InfraImage defined in containers.conf
2022-01-11 00:25:09 +01:00
2790b5c69c Merge pull request #12793 from cevich/vmimg_update
Enable gitlab runner unit testing + Freshen VM images w/ crun-1.4-1
2022-01-10 23:13:09 +01:00
92cd152b53 Merge pull request #12792 from mheon/bump_400_rc1
Bump to v4.0.0-RC1
2022-01-10 22:15:10 +01:00
19a4759066 Use the InfraImage defined in containers.conf
Remove hard code use of the DefaultInfraImage and rely on
getting this from containers.conf.

Fixes: https://github.com/containers/podman/issues/12771

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-10 16:13:33 -05:00
f687f959e8 Merge pull request #12791 from edsantiago/bats
System tests: fix RHEL8 gating tests
2022-01-10 22:13:07 +01:00
799078216b Cirrus: Freshen VM images
Specifically, this brings in `crun 1.4-1` allowing removal of a
temporary workaround.  Ref:

https://github.com/containers/podman/pull/12759

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-01-10 14:50:17 -05:00
0e4e5cf990 Revert "Cirrus: Temp. ignore gitlab task failures"
Ref: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/28766

This reverts commit 8cb93ac1035b8966b03a87ea58366fe9f3fc7887.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-01-10 14:50:17 -05:00
a95c01e0e4 pkg: use PROXY_VARS from c/common
Signed-off-by: Aditya Rajan <arajan@redhat.com>
2022-01-11 00:46:10 +05:30
a8b02cf4bf ignition: add support from setting SSL_CERT_FILE
Podman often has to run behind an http/https proxy, often in corporate environments.
This proxy may or may not include SSL inspection capabilities, requiring a trusted SSL CA certificate to be added to a system's trust store.

Copy the file referred to by SSL_CERT_FILE on the host into the podman machine's OS trust store, overriding the built-in single-file trust store certificate.

Also set the `SSL_FILE_CERT` on remote machine

[NO NEW TESTS NEEDED]

Signed-off-by: Aditya Rajan <arajan@redhat.com>
2022-01-11 00:46:06 +05:30
5c363ff276 ignition: propogate HTTP proxy variables from host to remote
Podman often has to run behind an http/https proxy, often in corporate environments.
This proxy may or may not include SSL inspection capabilities, requiring a trusted SSL CA certificate to be added to a system's trust store.

Solve this by reading standard proxy variables (HTTP_PROXY HTTPS_PROXY NO_PROXY http_proxy https_proxy no_proxy) and injecting them into the machine at init.

[NO NEW TESTS NEEDED]

Signed-off-by: Aditya Rajan <arajan@redhat.com>
2022-01-11 00:45:54 +05:30
18785450ed Bump to v4.0.0-dev
Signed-off-by: Matthew Heon <mheon@redhat.com>
2022-01-10 14:15:38 -05:00
9d26c1abb5 Bump to v4.0.0-RC1
Signed-off-by: Matthew Heon <mheon@redhat.com>
v4.0.0-rc1
2022-01-10 14:15:09 -05:00
508f9b76ea System tests: fix RHEL8 gating tests
Add a fix for RHEL8 gating tests. This resolves yet another
journald/file events/logger mismatch bug.

Also, while I'm at it, more log cleanup: a recently-added test was
missing final rm/rmi, resulting in big red scary output in test logs.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-01-10 12:14:53 -07:00
87cd4b698c Merge pull request #12772 from rhatdan/pause
Remove dead RuntimeOption functions
2022-01-10 19:31:10 +01:00
8af574fdaa Merge pull request #12757 from umohnani8/cm
Don't add env if optional and not found
2022-01-10 18:53:08 +01:00
a957e8c5e2 Merge pull request #12786 from vrothberg/vendor-common
vendor c/common
2022-01-10 18:51:08 +01:00
b7380a7c36 vendor c/common
Also update the e2e pull test to account for the changes when pulling
from the dir transport.  Images pulled via the dir transport are not
tagged anymore; the path is not a reliable source.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2022-01-10 16:25:37 +01:00
7a839f7a74 Merge pull request #12787 from rhatdan/docker
Update docker cli message for case where user creates directory
2022-01-10 16:18:52 +01:00
01ba2531b3 Remove dead RuntimeOption functions
I don't see where these With Functions are used, so removing them to
clean up code.
WithDefaultInfra* functions screwed me up and confused me.

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-10 09:37:55 -05:00
0933f6c0bd Update docker cli message for case where user creates directory
Check for any existing system object in docker script to clear warning message (Resolving PR comments)

[NO NEW TESTS NEEDED]

Signed-off-by: Stephen Person <stephen.person.12@cnu.edu>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-10 08:51:26 -05:00
b5b932f7ab Merge pull request #12783 from n1hility/wxs-fix
[NO TESTS NEEDED] Fix type-o in podman.wxs
2022-01-10 14:46:51 +01:00
4dc5a5b15d Don't add env if optional and not found
If the pod yaml has env from secret and condifg map but they are optional
and the secret cannot be found, don't add the env key as well
as the env value will not be found. Matches behavior with k8s.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2022-01-10 05:51:19 -05:00
a8a3e8bc99 Fix type-o in podman.wxs
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2022-01-09 21:00:02 -06:00
6ed2c639ac Merge pull request #12773 from mhrivnak/fix-example-indentation
[CI:DOCS] fixes indentation of example pod yaml
2022-01-08 12:04:50 +01:00
37c0b27b6f [CI:DOCS] fixes indentation of example pod yaml
The example as previously shown would result in "Error: multi doc yaml
could not be split". The change here has been tested to work, and it
matches the example in the [kubernetes
docs](https://kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/#configure-all-key-value-pairs-in-a-configmap-as-container-environment-variables).

Signed-off-by: Michael Hrivnak <mhrivnak@hrivnak.org>
2022-01-07 19:54:25 -05:00
41934acc51 Merge pull request #12733 from rhatdan/copy
Set volume NeedsCopyUp to false iff data was copied up
2022-01-07 20:38:59 +01:00
0464011a8e Merge pull request #12767 from riyad/fix-storage-opt-double-decode
Prevent double decoding of storage options
2022-01-07 16:16:59 +01:00
7dada6d492 Prevent double decoding of storage options
[NO NEW TESTS NEEDED] see #11991

Signed-off-by: Riyad Preukschas <riyad@informatik.uni-bremen.de>
2022-01-07 14:48:29 +01:00
7dd7b983b6 Merge pull request #12764 from edsantiago/bats
Emergency system-test fixes
2022-01-07 13:19:51 +01:00
67dab9e360 Merge pull request #12726 from hikhvar/remove-superflous-pod-rename
Don't rename pod if container has the same name
2022-01-07 13:11:50 +01:00
f688908151 Emergency system-test fixes
Emergency fix to image-scp tests. DO NOT CREATE A USER!
These tests are run in all sorts of environments. We
do not have the right to vandalize a production system.

Also remove some misleading unneeded tests; and refactor a
little; and add a bunch of FIXMEs which will need to be
addressed later.

Also, super-low priority, add 'crun: ' to expected error
message in a run test (minor followup to #12758).

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-01-06 15:54:01 -07:00