6322 Commits

Author SHA1 Message Date
23f7957862 Merge pull request #5044 from jwhonce/issues/4335
Update XML to not embed quote in PATH on windows
2020-02-03 06:57:07 -08:00
5e7d6e52dd Merge pull request #5053 from containers/dependabot/go_modules/github.com/containers/storage-1.15.8
build(deps): bump github.com/containers/storage from 1.15.7 to 1.15.8
2020-02-03 09:27:58 -05:00
227d881580 Merge pull request #5054 from containers/dependabot/go_modules/github.com/onsi/gomega-1.9.0
build(deps): bump github.com/onsi/gomega from 1.8.1 to 1.9.0
2020-02-03 09:26:59 -05:00
94453c85c7 build(deps): bump github.com/containers/storage from 1.15.7 to 1.15.8
Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.15.7 to 1.15.8.
- [Release notes](https://github.com/containers/storage/releases)
- [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md)
- [Commits](https://github.com/containers/storage/compare/v1.15.7...v1.15.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-02-03 13:51:31 +01:00
fac6b784f8 build(deps): bump github.com/onsi/gomega from 1.8.1 to 1.9.0
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.8.1...v1.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-02-03 13:50:26 +01:00
b977048436 Update XML to not embed quote in PATH on windows
* Remove the unsupported commend in lua script

Fixes #4335

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-01-31 15:22:20 -07:00
4699d5e02d Merge pull request #5041 from mheon/bump-1.8.0-rc1
Bump to v1.8.0-rc1
2020-01-31 10:30:19 -08:00
a98c36df1a Bump to v1.8.0-dev
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-01-31 12:45:02 -05:00
5558c2620c Bump to v1.8.0-rc1
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
v1.8.0-rc1
2020-01-31 12:44:59 -05:00
dd6209e155 Merge pull request #5038 from mheon/fix_release_script
[CI:DOCS] Fix a syntax error in hack/release.sh
2020-01-31 09:17:11 -08:00
781fc827c6 Merge pull request #5036 from vrothberg/fix-5034
sigproxy: return after closing the channel
2020-01-31 08:32:26 -08:00
1cf4b72a6e Merge pull request #5030 from baude/apiv2longname
fix longname handling for bindings
2020-01-31 08:06:41 -08:00
662eab1672 Fix a syntax error in hack/release.sh
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-01-31 10:55:17 -05:00
c29273e84f Merge pull request #5037 from mheon/release_notes_1.8.0
[CI:DOCS] Minor update to release notes
2020-01-31 07:30:45 -08:00
68031f9391 Minor update to release notes
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-01-31 10:18:54 -05:00
868ee6db70 sigproxy: return after closing the channel
When stopping signal handling (e.g., to properly handle ^C) we are also
closing the signal channel.  We should really return from the go-routine
instead of continuing and risking double-closing the channel which leads
to a panic.

Fixes: #5034
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-31 16:13:00 +01:00
f1eaccedfa fix longname handling for bindings
the api needs to account for image input where the image is encoded as a fqd image name.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-01-31 08:38:25 -06:00
36af2833f9 Merge pull request #5032 from mheon/release_notes_1.8.0
Update release notes for v1.8.0
2020-01-30 17:25:18 -08:00
ba1d1304a6 Merge pull request #5028 from baude/commitimage
make image reference for commit optional
2020-01-30 17:10:20 -08:00
4f96b17ef5 Merge pull request #5020 from baude/bindingtestrootless
Bindingtestrootless
2020-01-30 15:24:51 -08:00
a3e14c87bb Merge pull request #5022 from ssbarnea/fix/validate
Assure validate includes lint
2020-01-30 15:02:18 -08:00
fad36345f5 Merge pull request #5024 from rpjday/markdown/asterisks
markdown: fix erroneous asterisk markup for options
2020-01-30 14:44:39 -08:00
ef965bc28d Merge pull request #5031 from baude/apiv2dockercontainerslash
compat container names begin with /
2020-01-30 14:30:37 -08:00
5de3f343c5 Update release notes for v1.8.0
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-01-30 17:07:01 -05:00
616acf181d compat container names begin with /
when using the apiv2, containers names are preceeded with a /.  fixing this for inspect and listcontainers.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-01-30 13:21:40 -06:00
5190407619 Assure validate includes lint
Fixed issue where lint was not run on CI, so we missed to prevent regressions.

Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
2020-01-30 18:39:56 +00:00
9bbf08de25 make image reference for commit optional
to match docker compat, the image tag should be optional.

Fixes: #5027

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-01-30 09:51:59 -06:00
ee0b328b72 Merge pull request #5025 from delight/feature/ubuntu_doc_adjustment
Feature/ubuntu doc adjustment
2020-01-30 06:53:58 -08:00
83044fe6c0 Merge pull request #5017 from vrothberg/fix-4829
Makefile cleanups
2020-01-30 06:40:22 -08:00
1729350f66 Merge pull request #4951 from rpjday/docs/unshare
markdown: fix grammar/formatting, standardize on markdown
2020-01-30 06:40:16 -08:00
e83e9f5d71 Merge pull request #5019 from cevich/fix_gate_epoch
Cirrus: Set EPOCH_TEST_COMMIT during gate task
2020-01-30 06:26:39 -08:00
8d765ac018 adjusts install.md (Ubuntu): replaces ${NAME} with hard-encoded Ubuntu to support all *buntu flavors
- combines downloading and registering of the apt-secure key into a piped oneliner
2020-01-30 13:33:05 +01:00
9066051d13 adjusts install.md (Ubuntu): registries.conf setup is now in containers-image package 2020-01-30 12:59:24 +01:00
0bc96b4829 markdown: fix erroneous asterisk markup for options
Fix option markup in a number of man pages so it renders
properly when viewing online.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-30 06:44:33 -05:00
4ec893a748 speed up Makefile
Speed up the Makefile by removing variable references from the release
targets.  Now, the variables will only be (lazily) evaluated when they
are actually needed and not for each invocation of the Makefile which
has it down considerably.

Fixes: #4829
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-30 08:44:34 +01:00
7b14c02d0d Makefile: systemd: echo instead of warn
Just echo the message instead of warning to not impact the exit code.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-30 08:44:34 +01:00
79ceb31edf Makefile: remove redundant BUILDFLAGS
We don't set it, so there's no need to keep it.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-30 08:44:34 +01:00
9fa8b723c8 Makefile: consistent PHONY use
Add a .PHONY line over each target instead of mixing this notation with
a separate but incomplete single list.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-30 08:44:26 +01:00
0428eb6111 Makefile: remove dead vagrant target
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-30 08:44:10 +01:00
5aadd45f7c Makefile: move systemd buildtag check
Move the systemd-buildtag check into the `bin/podman` target.
No need to execute the check for all invocations of the
Makefile.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-30 08:44:10 +01:00
1d9537e242 rootless: enable shortcut only for podman
disable joining automatically the user namespace if the process is not
podman.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-01-29 16:16:36 -06:00
f8067d70b0 test: honor TEMPDIR variable
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-01-29 16:16:23 -06:00
eb28365703 Merge pull request #5018 from mheon/new_anon_field
Deprecate & remove IsCtrSpecific in favor of IsAnon
2020-01-29 14:01:52 -08:00
12bd7e927c Cirrus: Set EPOCH_TEST_COMMIT during gate task
For whatever reason, this required variable is not set when `make` is
doing validation within automation.  Fix this by establishing the
value based on data provided from the CI system.  Since this data
is specific to automation executing against a PR, limit this specific
job to not run during testing of branches (post-merge).  This is safe
since we can assume the PR would not have been merged, if the basics
checked during gating did not pass.

Signed-off-by: Chris Evich <cevich@redhat.com>
2020-01-29 15:48:35 -05:00
0e21fc8860 Merge pull request #5015 from baude/bindingtestfixes
apiv2 binding test fixes
2020-01-29 12:30:46 -08:00
5d93c731af Deprecate & remove IsCtrSpecific in favor of IsAnon
In Podman 1.6.3, we added support for anonymous volumes - fixing
our old, broken support for named volumes that were created with
containers. Unfortunately, this reused the database field we used
for the old implementation, and toggled volume removal on for
`podman run --rm` - so now, we were removing *named* volumes
created with older versions of Podman.

We can't modify these old volumes in the DB, so the next-safest
thing to do is swap to a new field to indicate volumes should be
removed. Problem: Volumes created with 1.6.3 and up until this
lands, even anonymous volumes, will not be removed. However, this
is safer than removing too many volumes, as we were doing before.

Fixes #5009

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-01-29 14:04:51 -05:00
a8b4e986f7 apiv2 binding test fixes
a recent refactor in the bindings broke the tests.  quick fixes to get them working again.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-01-29 12:41:39 -06:00
955866c97d Merge pull request #5013 from vrothberg/fix-4916
history: fix size computing
2020-01-29 07:23:32 -08:00
c9fb6d1668 history: fix size computing
Get the layer's size whether it relates to the first history entry or
not.  This fixes issues where the first entry would always be shown
to be of size 0.

Fixes: #4916
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-29 14:54:24 +01:00
8241c1ae94 Merge pull request #5011 from vrothberg/fix-4814
run `varlink_generate` on Linux only
2020-01-29 05:49:47 -08:00