8011 Commits

Author SHA1 Message Date
22713d62e2 Merge pull request #6353 from lsm5/build-without-varlink
enable building without `varlink` tag
2020-06-01 14:48:35 +02:00
bb05337f0a Merge pull request #6441 from TomSweeneyRedHat/dev/tsweeney/fixtuthttpd
[CI:DOCS] update httpd location in tutorial
2020-05-31 05:57:57 -04:00
bc1f5ef36e [CI:DOCS] update httpd location in tutorial
Update the reference to the httpd in the Podman tutorial.
This just bumps it to F29 for now to get things working,
I'd prefer to get something set up in quay.io to make it
more resistant to Fedora version changes.

Fixes: #6439

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2020-05-30 13:51:44 -04:00
9037908b78 Merge pull request #5594 from edsantiago/bats
system tests: enable skopeo REGISTRY_AUTH_FILE
2020-05-30 05:17:18 -04:00
6d6a629db5 Merge pull request #6165 from containers/dependabot/go_modules/github.com/rootless-containers/rootlesskit-0.9.5
Bump github.com/rootless-containers/rootlesskit from 0.9.4 to 0.9.5
2020-05-30 05:09:30 -04:00
c479d63dd6 Merge pull request #6356 from baude/v2copyendpoints
v2 copy endpoints
2020-05-30 05:06:48 -04:00
8a914e8a0b default build without varlink tag
Issue gh#6286 was already fixed in a prior commit but the Makefile still
ran some varlink steps by default.

This commit makes any varlink build steps dependent on the varlink
build tag and also makes the contrib rpm spec file independent of
varlink.

Endpoint tests will be run only if BUILDTAGS contains varlink.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2020-05-29 14:38:33 -04:00
0eea051b92 Merge pull request #6432 from mheon/bump-2.0.0-rc3
Bump to v2.0.0-RC3
2020-05-29 11:27:34 -04:00
0c750a9672 Merge pull request #6207 from vrothberg/auth-header
add X-Registry-Auth header support
2020-05-29 10:37:59 -04:00
cbd4841f35 Bump to v2.0.0-dev
Signed-off-by: Matthew Heon <mheon@redhat.com>
2020-05-29 10:32:25 -04:00
d4a3c05c0f Bump to v2.0.0-rc3
Signed-off-by: Matthew Heon <mheon@redhat.com>
v2.0.0-rc3
2020-05-29 10:32:22 -04:00
dc80267b59 compat handlers: add X-Registry-Auth header support
* Support the `X-Registry-Auth` http-request header.

 * The content of the header is a base64 encoded JSON payload which can
   either be a single auth config or a map of auth configs (user+pw or
   token) with the corresponding registries being the keys.  Vanilla
   Docker, projectatomic Docker and the bindings are transparantly
   supported.

 * Add a hidden `--registries-conf` flag.  Buildah exposes the same
   flag, mostly for testing purposes.

 * Do all credential parsing in the client (i.e., `cmd/podman`) pass
   the username and password in the backend instead of unparsed
   credentials.

 * Add a `pkg/auth` which handles most of the heavy lifting.

 * Go through the authentication-handling code of most commands, bindings
   and endpoints.  Migrate them to the new code and fix issues as seen.
   A final evaluation and more tests is still required *after* this
   change.

 * The manifest-push endpoint is missing certain parameters and should
   use the ABI function instead.  Adding auth-support isn't really
   possible without these parts working.

 * The container commands and endpoints (i.e., create and run) have not
   been changed yet.  The APIs don't yet account for the authfile.

 * Add authentication tests to `pkg/bindings`.

Fixes: #6384
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-05-29 15:39:37 +02:00
78c38460eb Merge pull request #6380 from mheon/fix_mount_readonly
Add support for `readonly` option to --mount
2020-05-29 08:26:05 -04:00
8e048b23fe Merge pull request #6429 from containers/dependabot/go_modules/github.com/stretchr/testify-1.6.0
Bump github.com/stretchr/testify from 1.5.1 to 1.6.0
2020-05-29 08:23:17 -04:00
6e3aec3c6d Merge pull request #6419 from mheon/signal_parse_windows
Ensure that signal names can be parsed on Windows
2020-05-29 06:00:48 -04:00
f921793948 Merge pull request #6423 from rhatdan/VENDOR
Vendor in containers/common v0.12.0
2020-05-29 05:55:14 -04:00
ef807d0ac7 Bump github.com/stretchr/testify from 1.5.1 to 1.6.0
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.5.1 to 1.6.0.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.5.1...v1.6.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-05-29 05:49:55 -04:00
cd1e25f5d5 Merge pull request #6420 from jwhonce/wip/json
V2 verify JSON output is consistent and doesn't drift
2020-05-28 20:12:08 -04:00
5626c2163b V2 verify JSON output is consistent and doesn't drift
$ cd test/apiv2
$ python -m unittest -v test_rest_v1_0_0.TestApi

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-05-28 16:20:29 -07:00
911b6d8b48 Vendor in containers/common v0.12.0
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-05-28 16:58:53 -04:00
e8818ced80 Merge pull request #6416 from vrothberg/fix-ps-last
fix `ps --last=N`
2020-05-28 14:54:45 -04:00
e0eb6022b3 Ensure that signal names can be parsed on Windows
To ensure the Windows and OS X remote clients can properly parse
container stop signal (when given as a name e.g. SIGTERM) and
set it in SpecGen, we need access to a list of Linux signal names
and the numbers they map to that is available on non-Linux OSes.
Fortunately, these are ABI constants that are extremely unlikely
to change, so we can just take the existing constant definitions
from the library and use them.

The signal numbers used here are sourced from AMD64, but should
be the same for every architecture that is not Alpha, SPARC,
MIPS, and PA-RISC. So `podman run --stop-signal SIGTTOU` from a
Windows client to a Podman service on a SPARC host will set an
incorrect stop signal, but I don't think this is a large problem.

Signed-off-by: Matthew Heon <mheon@redhat.com>
2020-05-28 14:26:36 -04:00
4b2c980e0f Merge pull request #6391 from chuanchang/add_test_for_image_history_and_exporting
test.apiv2: add testing for displaying image history and exporting image
2020-05-28 12:55:25 -04:00
d6469c9c9b fix ps --last=N
Fix `ps --last=N` to also include non-running containers. Also add an
e2e test to prevent us from regressing in the future.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-05-28 14:24:01 +02:00
7e03d277f7 test.apiv2: add testing for image and deal with API returning binary
Add testing for displaying image history and exporting image

Deal with API returning binary (Content-Type =~ 'octet').
When so, set $output to the output of 'file'.

Bug fix: in 't' helper, declare loop var $i as local
to avoid contaminating caller

Signed-off-by: Ed Santiago <santiago@redhat.com>
Signed-off-by: Alex Jia <chuanchang.jia@gmail.com>
2020-05-28 10:00:13 +00:00
adca437d03 Merge pull request #6410 from haircommander/fix-segfault
specgen: fix segfault
2020-05-27 16:30:38 -04:00
c64abd0b03 Merge pull request #6407 from baude/v2eventsstream
Add streaming ability to endpoint
2020-05-27 15:07:32 -04:00
339ffd8ade specgen: fix segfault
we should not access the devices without checking if the resources are there

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2020-05-27 14:52:17 -04:00
8438fa4fec Add streaming ability to endpoint
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-05-27 12:16:39 -05:00
ab3a620f74 Merge pull request #6398 from rhatdan/32bit
Fix builds on 32 Arches.
2020-05-27 11:18:37 -04:00
2a988a4d82 Merge pull request #6403 from vrothberg/push-swagger
v2 libpod push: correct docs
2020-05-27 11:03:06 -04:00
89b4683cc4 Merge pull request #6372 from boaz0/gh_6283
Add --format to pod inspect
2020-05-27 09:59:25 -04:00
f8632bad82 Fix builds on 32 bit arches
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-05-27 09:52:36 -04:00
d6fd0952f8 v2 libpod push: correct docs
The swagger documentation for the libpod push endpoint were not in sync
with the implementation.  Correct these docs to reflect the parameters
that are actually supported.

Fixes: #6388
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-05-27 15:26:46 +02:00
9cb5c87284 Merge pull request #6406 from vrothberg/stats-race
container stats: fix --no-stream race
2020-05-27 09:26:39 -04:00
3cef598fc2 container stats: fix --no-stream race
Fix a race in `podman container stats` by waiting for the client to
consume the data in the channel.  This requires a `sync.WaitGroup` (or
semaphore) in the client and to also close the channel the backend.

Fixes: #6405
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-05-27 13:51:48 +02:00
1f8a78747a Add --format to pod inspect
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
2020-05-27 09:48:38 +03:00
119e13d4bc Merge pull request #6396 from damdo/docs-fix-typo
docs: fix typo
2020-05-26 17:08:33 -04:00
e26f9eda64 Add support for readonly option to --mount
This is just an alias to the `ro` option, but it's already in the
manpages (and Docker) so we might as well add support for it.

Fixes #6379

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-05-26 16:05:11 -04:00
e704da0c52 Merge pull request #6385 from containers/dependabot/go_modules/github.com/opencontainers/selinux-1.5.2
Bump github.com/opencontainers/selinux from 1.5.1 to 1.5.2
2020-05-26 15:59:46 -04:00
26c8a826a6 docs: fix typo
- Similar is misspelled
- a `to` is missing after Similar

Signed-off-by: Damiano Donati <damiano.donati@gmail.com>
2020-05-26 20:59:40 +01:00
d32d588504 Merge pull request #6363 from jwhonce/wip/attach
V2 Fix interface nil checks
2020-05-26 14:36:17 -04:00
d6a7096d61 Merge pull request #6393 from rhatdan/dockerfile
Fix Dockerfile
2020-05-26 14:11:55 -04:00
5dfddf04ee v2 copy endpoints
add copy endpoint inputs and outputs.  these endpoints are not implemented yet, nor are any bindings.  this allows us to update this later without having to change our api version.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-05-26 12:04:20 -05:00
1fb907198f V2 Fix interface nil checks
Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-05-26 10:00:15 -07:00
07ef44e2f3 Merge pull request #6390 from edsantiago/registry_show_errors
podman-registry: fix lost credentials
2020-05-26 11:28:07 -04:00
5c10533d49 Merge pull request #6394 from TomSweeneyRedHat/dev/tsweeney/uppercase
[CI:DOCS] Tweak casing in rootless doc
2020-05-26 11:25:22 -04:00
c79c69f275 [CI:DOCS] Tweak casing in rootless doc
I just noticed a few 'podman' references that should be
'Podman' in the rootless doc.  This fixes it.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2020-05-26 10:55:34 -04:00
b81b865b52 podman-registry: many unrelated fixes
1) fix lost credentials.

    must_pass(), added in #6375, eats the credentials
    generated via 'podman run --entrypoint htpasswd'.
    Run that podman instance directly, and add explicit
    error check.

    (The error and stdout/stderr handling here has gotten
    cumbersome. There must be something I'm missing that
    could make it all simpler.)

 2) fix default podman path.

    When setting $PODMAN, default to the locally built
    one -- there may not be one in $PATH (e.g. in
    Ubuntu, see #6366). This in turn requires us to:

 3) run registry test in integration, not unit test

    It looks like unit tests run before podman is built,
    causing a chicken-egg dilemma. Try to solve that by
    running the new hack/podman-registry-go test in
    integration tests, not unit tests.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-05-26 08:21:46 -06:00
154debb804 Fix Dockerfile
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-05-26 09:53:27 -04:00