Move the handling of userns keys from ConvertContainer to a separate method
Adjust the method according to the different supported values
Use the new method in both ConvertContainer and ConvertKube
Pass isUser to ConvertKube as well
Add tests
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
docker-compose sets the mac address in the container config and not the
network endpoint config. This is ugly when you have more than one
network, in this case docker just chooses the first network.
Fixes#16411
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The containers should be able to write to tmpfs mounted directories.
Also cleanup output of podman kube generate to not show default values.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
The passthrough_env function was unnecessarily complicated,
hence fragile. Clean it up, and add regression tests.
For future reference: CI broke horribly because of this.
Rootless tests all failed with missing CI_DESIRED_NETWORK.
Root cause was that CIRRUS_CHANGE_TITLE had a trailing
space which, because of shell indirection, passthrough_env()
wrote as trailing backslash (not backslash-space) in the
/etc/ci_environment file, which then caused the next line
in the file to get glommed onto CIRRUS_CHANGE_TITLE.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Mark the highest version release as the latest release so that
https://github.com/containers/podman/releases/latest will always
point to the highest version release.
Signed-off-by: Mohan Boddu <mboddu@redhat.com>
It's important to actually perform a windows build for a `[CI:DOCS]` PR
since it verifies and includes a copy of the docs. However, it's not
necessary to actually test if the installer functions or not. That task
should happen in other contexts.
Signed-off-by: Chris Evich <cevich@redhat.com>
This container hasn't been used/maintained in ages, remove the related
instructions from the contributions doc.
Fixes: #16415
Signed-off-by: Chris Evich <cevich@redhat.com>
Add @n1hility to the OWNERS file. They are maintaining various
subsystems of Podman including machine on Windows.
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Update the snoop script to also include the arguments to make the output
more useful.
```
$ sudo hack/podmansnoop
PCOMM PID PPID AGE(ms) ARGV
conmon 14964 14952 1.01 /usr/bin/conmon --version
podman 14952 14139 26.07 /usr/bin/podman ps
```
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
