Commit Graph

22229 Commits

Author SHA1 Message Date
Paul Holzinger
10995192f8 update github.com/rootless-containers/rootlesskit to v2
Contains a breaking change but also besides this renovate is not able to
update the import paths so this needs to be done by hand.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-05 12:25:02 +02:00
openshift-merge-bot[bot]
adbedb1464 Merge pull request #22257 from containers/renovate/github.com-shirou-gopsutil-v3-3.x
fix(deps): update module github.com/shirou/gopsutil/v3 to v3.24.3
2024-04-04 19:42:09 +00:00
openshift-merge-bot[bot]
036fb1849b Merge pull request #22259 from Luap99/rm-force
rm --force work for more than one arg
2024-04-04 18:41:34 +00:00
openshift-merge-bot[bot]
ef904c5b19 Merge pull request #22251 from umohnani8/kube-docs
[CI:DOCS] Update kube docs
2024-04-04 18:35:49 +00:00
openshift-merge-bot[bot]
c5426247d7 Merge pull request #22236 from edsantiago/golangci-lint-update-options
[CI:DOCS] golangci-lint: update deprecated flags
2024-04-04 17:54:34 +00:00
openshift-merge-bot[bot]
dda10fca30 Merge pull request #22254 from containers/renovate/golangci-golangci-lint-1.x
[CI:DOCS] Update dependency golangci/golangci-lint to v1.57.2
2024-04-04 16:59:36 +00:00
Paul Holzinger
f2c365c6f6 rm --force work for more than one arg
When we remove with --force we do not return a error if the input does
not exists, however if we get more than on input we must try to remove
all and not just NOP out and not remove anything just because one arg
did not exists.

Also make the code simpler for commands that do have the --ignore option
and just make --force imply --ignore which reduces the ugly error
handling.

Fixes #21529

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-04 17:47:28 +02:00
Urvashi Mohnani
71f6f50ee1 [CI:DOCS] Update kube docs
Update kube docs stating the support of moving to and from
k8s in podman and explicitly stating that we are not replicating
the kubectl cli.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2024-04-04 09:28:21 -04:00
openshift-merge-bot[bot]
394be0b448 Merge pull request #22253 from ashley-cui/sitevers
[CI:DOCS] Add GitHub action to update version on Podman.io
2024-04-04 11:43:18 +00:00
openshift-merge-bot[bot]
8ab4bc9250 Merge pull request #22243 from Luap99/rootless-netns
vendor latest c/common to fix rootless-netns issues
2024-04-04 11:40:35 +00:00
openshift-merge-bot[bot]
3c7147110e Merge pull request #22248 from edsantiago/windows-perl-is-in-vms
Windows: clean up temporary perl install
2024-04-04 09:14:48 +00:00
renovate[bot]
81d2ef889b fix(deps): update module github.com/shirou/gopsutil/v3 to v3.24.3
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-03 19:58:21 +00:00
Daniel J Walsh
ff7a3dc355 Merge pull request #22191 from containers/renovate/dawidd6-action-send-mail-3.x
[skip-ci] Update dawidd6/action-send-mail action to v3.12.0
2024-04-03 15:55:32 -04:00
openshift-merge-bot[bot]
1dcb3c7104 Merge pull request #22252 from Luap99/fix-walk-race
pkg/util: FindDeviceNodes() ignore ENOENT errors
2024-04-03 17:26:04 +00:00
Ashley Cui
0f949d884c [CI:DOCS] Add GitHub action to update version on Podman.io
Introduce a new GitHub action that will update Podman.io to the newest version of Podman. This action will run on a release being published to GitHub, or by clicking the run workflow button on GitHub. The action will check if the release version is higher than the current version on the website, and open a PR to update the version if a PR does not already exist. The commit will be signed off by the user who triggered the action, so whoever creates the release or presses the run workflow button. The PR will be opened by the podmanbot GitHub account.

Signed-off-by: Ashley Cui <acui@redhat.com>
2024-04-03 12:15:35 -04:00
renovate[bot]
ccb71f9ffa [CI:DOCS] Update dependency golangci/golangci-lint to v1.57.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-03 15:34:21 +00:00
openshift-merge-bot[bot]
0106e5929d Merge pull request #22245 from giuseppe/do-not-chown-again-with-U
container: do not chown to dest target with U
2024-04-03 15:33:34 +00:00
openshift-merge-bot[bot]
33b60f1e0a Merge pull request #22250 from edsantiago/validate-needs-docs
[CI:DOCS] build deps: make-validate needs docs
2024-04-03 15:27:50 +00:00
Ed Santiago
ff133a544d Windows: clean up temporary perl install
Followup to #21991. Strawberry Perl is now installed by default
in CI VMs[1], so we no longer need the temporary install-perl code.

 [1] https://github.com/containers/automation_images/pull/337

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 08:53:55 -06:00
Paul Holzinger
498445871c pkg/util: FindDeviceNodes() ignore ENOENT errors
This is racy by design, if you walk a tree and the directory was removed
between listing and then opening we get an ENOENT error. Simply ignore
that case and do not log it.

Fixes #21782

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-03 16:44:14 +02:00
Ed Santiago
549dbf8327 [CI:DOCS] build deps: make-validate needs docs
The man-page-check target requires up-to-date man pages.

Closes: #22025

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 08:26:17 -06:00
openshift-merge-bot[bot]
6b9b85e011 Merge pull request #22175 from edsantiago/skip_if_no_slirp
systests: conditionalize slirp4netns tests
2024-04-03 13:32:19 +00:00
Paul Holzinger
a61ae8c0a9 test/system: add rootless-netns test for setup errors
This is a test for #22168.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-03 15:01:51 +02:00
Paul Holzinger
ce04fbc16a vendor latest c/common main
Includes several rootless-netns fixes.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-04-03 15:01:21 +02:00
Giuseppe Scrivano
519a66c6a9 container: do not chown to dest target with U
if the 'U' option is provided, do not chown the destination target to
the existing target in the image.

Closes: https://github.com/containers/podman/issues/22224

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-04-03 14:41:33 +02:00
openshift-merge-bot[bot]
976640474b Merge pull request #22167 from edsantiago/systest_instrument
CI: systests: instrument flaky tests
2024-04-03 12:37:18 +00:00
Ed Santiago
fbd6df92d4 [CI:DOCS] golangci-lint: update deprecated flags
Per https://golangci-lint.run/product/changelog/#v1570
  - Replace run.skip-xxx options by issues.exclude-xxx options

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 05:57:41 -06:00
Ed Santiago
d27313ad10 systests: conditionalize slirp4netns tests
As of podman 5.0, slirp4netns is a soft dependency. It might
not be installed on a host (and, in gating tests, is not).
Deal with it.

Use podman itself, not 'which', to tell us if slirp4netns
is available. We don't want to duplicate podman's path-check
logic. Since this check is expensive, cache the result.

(Change the has_pasta check similarly)

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 05:49:21 -06:00
Ed Santiago
e697631af9 CI: systests: instrument flaky tests
Three infrequent flakes. Add debug code to help track
down if/when they happen again.

And, one of them, fix a logic bug that will save us 8-10s
on system tests runs.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-04-03 05:26:51 -06:00
openshift-merge-bot[bot]
d55ea0edfc Merge pull request #22153 from lsm5/packit-fedora-latest
[skip-ci] Packit: specify fedora-latest in propose-downstream
2024-04-03 11:20:19 +00:00
openshift-merge-bot[bot]
d2f639f61f Merge pull request #21620 from WesselAtWork/docs/s3fs
[CI:DOCS] s3fs volume mount docs
2024-04-03 11:14:48 +00:00
WesselAtWork
d2143fac59 s3fs docs
Signed-off-by: WesselAtWork <115667066+WesselAtWork@users.noreply.github.com>
2024-04-03 10:18:49 +00:00
openshift-merge-bot[bot]
d470e7ee7d Merge pull request #22178 from dcermak/makefile_extra_build_tags
Inject additional build tags from the environment
2024-04-03 09:30:19 +00:00
Giuseppe Scrivano
7d68362cf5 test: do not skip tests under rootless
there are no overlay mounts in the "podman run with --volume and U
flag" tests so no need to skip them.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-04-03 11:02:16 +02:00
openshift-merge-bot[bot]
3ab859be68 Merge pull request #22242 from ehelms/update-publishport-kube-doc
[CI:DOCS] Add note about host networking to Kube PublishPort option
2024-04-02 15:51:34 +00:00
Eric D. Helms
d3927f9076 Add note about host networking to Kube PublishPort option
Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
2024-04-02 10:44:45 -04:00
Dan Čermák
1a99d87746 Inject additional build tags from the environment
This allows distros to easily add buildtags without patching the Makefile or
duplicating it in their build recipes

[NO NEW TESTS NEEDED]

Signed-off-by: Dan Čermák <dcermak@suse.com>
2024-04-02 14:48:52 +02:00
openshift-merge-bot[bot]
e1f49529fa Merge pull request #22229 from giuseppe/fix-idmap-existing-volume
libpod: use original IDs if idmap is provided
2024-04-01 19:08:29 +00:00
Giuseppe Scrivano
d81319eb71 libpod: use original IDs if idmap is provided
if the volume is mounted with "idmap", there should not be any mapping
using the user namespace mappings since this is done at runtime using
the "idmap" kernel feature.

Closes: https://github.com/containers/podman/issues/22228

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-03-31 23:46:17 +02:00
openshift-merge-bot[bot]
45b809c063 Merge pull request #22201 from cgwalters/doc-man
docs/podman-login: Give an example of writing the persistent path
2024-03-29 11:16:19 +00:00
openshift-merge-bot[bot]
fb046fc24a Merge pull request #22202 from edsantiago/new-vms-pasta-0326
CI: Bump VMs to 2024-03-28
2024-03-28 21:01:04 +00:00
openshift-merge-bot[bot]
07a03c453b Merge pull request #22205 from n1hility/fix-action
[CI:DOCS] Switch back to checking out the same branch the action script runs in
2024-03-28 19:07:33 +00:00
Jason T. Greene
f3434298df Switch back to checking out the same branch the action script runs in
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2024-03-28 13:30:03 -05:00
Colin Walters
f7b9168649 docs/podman-login: Give an example of writing the persistent path
The way `podman login` works by default is fundamentally different
from `docker login` and this causes a lot of confusion, and I
have seen multiple bad suggestions for ways to address this
such as setting `XDG_RUNTIME_DIR`.

Let's document up front how to write to the persistent path.

Signed-off-by: Colin Walters <walters@verbum.org>
2024-03-28 13:04:47 -04:00
Ed Santiago
aab4674feb CI: Bump VMs to 2024-03-28
Emergency update to get pasta 03-26. Also gives us crun 1.14.4.

One unexplained difference: fc39 and rawhide now create:

    /run/log/journal/SOMETHING/system.journal

...and the SOMETHING is o-rwx. This triggers journalctl to spit out a warning:

    Hint: You are currently not seeing messages from the system.
          Users in groups 'adm', 'systemd-journal', 'wheel' can see all messages.
          Pass -q to turn off this notice.

...which in turn causes ExitCleanly() to fail.

It is not clear who/what is creating this journal directory, or
why it allofasudden started just now. Workaround is to add -q
to journalctl in one test.

One more difference, another test now requires SYSLOG capability.

VM package info:
    https://github.com/containers/automation_images/pull/342

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-03-28 08:35:29 -06:00
renovate[bot]
4c2a44ef9b [skip-ci] Update dawidd6/action-send-mail action to v3.12.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-27 23:22:18 +00:00
openshift-merge-bot[bot]
8ec8214525 Merge pull request #22189 from containers/renovate/github.com-openshift-imagebuilder-1.x
fix(deps): update module github.com/openshift/imagebuilder to v1.2.7
2024-03-27 23:21:23 +00:00
openshift-merge-bot[bot]
a1a5bd3bd5 Merge pull request #21493 from mporrato/fix-21211
kube play: always pull when both imagePullPolicy and tag are missing
2024-03-27 21:58:45 +00:00
renovate[bot]
fc18dbad70 fix(deps): update module github.com/openshift/imagebuilder to v1.2.7
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-27 21:17:03 +00:00
openshift-merge-bot[bot]
71eef631c8 Merge pull request #22163 from baude/docker26
Fix reference to deprecated types.Info
2024-03-27 21:14:29 +00:00