add unit tests for generate systemd

it looks like i forgot to add the unit tests for generate systemd Signed-off-by: baude <bbaude@redhat.com>
2025-08-02 17:22:30 +08:00 · 2019-05-06 09:14:10 -05:00
parent a9fc570dd8
commit faf499cf94
1 changed files with 120 additions and 0 deletions
--- a/pkg/systemdgen/systemdgen_test.go
+++ b/pkg/systemdgen/systemdgen_test.go
@ -0,0 +1,120 @@
+package systemdgen
+
+import (
+	"testing"
+)
+
+func TestValidateRestartPolicy(t *testing.T) {
+	type args struct {
+		restart string
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantErr bool
+	}{
+		{"good-on", args{restart: "no"}, false},
+		{"good-on-success", args{restart: "on-success"}, false},
+		{"good-on-failure", args{restart: "on-failure"}, false},
+		{"good-on-abnormal", args{restart: "on-abnormal"}, false},
+		{"good-on-watchdog", args{restart: "on-watchdog"}, false},
+		{"good-on-abort", args{restart: "on-abort"}, false},
+		{"good-always", args{restart: "always"}, false},
+		{"fail", args{restart: "foobar"}, true},
+		{"failblank", args{restart: ""}, true},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if err := ValidateRestartPolicy(tt.args.restart); (err != nil) != tt.wantErr {
+				t.Errorf("ValidateRestartPolicy() error = %v, wantErr %v", err, tt.wantErr)
+			}
+		})
+	}
+}
+
+func TestCreateSystemdUnitAsString(t *testing.T) {
+	goodID := `[Unit]
+Description=639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401 Podman Container
+[Service]
+Restart=always
+ExecStart=/usr/bin/podman start 639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401
+ExecStop=/usr/bin/podman stop -t 10 639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401
+KillMode=none
+Type=forking
+PIDFile=/var/lib/containers/storage/overlay-containers/639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401/userdata/639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401.pid
+[Install]
+WantedBy=multi-user.target`
+
+	goodName := `[Unit]
+Description=foobar Podman Container
+[Service]
+Restart=always
+ExecStart=/usr/bin/podman start foobar
+ExecStop=/usr/bin/podman stop -t 10 foobar
+KillMode=none
+Type=forking
+PIDFile=/var/lib/containers/storage/overlay-containers/639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401/userdata/639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401.pid
+[Install]
+WantedBy=multi-user.target`
+
+	type args struct {
+		name        string
+		cid         string
+		restart     string
+		pidPath     string
+		stopTimeout int
+	}
+	tests := []struct {
+		name    string
+		args    args
+		want    string
+		wantErr bool
+	}{
+
+		{"good with id",
+			args{
+				"639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401",
+				"639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401",
+				"always",
+				"/var/lib/containers/storage/overlay-containers/639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401/userdata/",
+				10,
+			},
+			goodID,
+			false,
+		},
+		{"good with name",
+			args{
+				"foobar",
+				"639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401",
+				"always",
+				"/var/lib/containers/storage/overlay-containers/639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401/userdata/",
+				10,
+			},
+			goodName,
+			false,
+		},
+		{"bad restart policy",
+			args{
+				"639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401",
+				"639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401",
+				"never",
+				"/var/lib/containers/storage/overlay-containers/639c53578af4d84b8800b4635fa4e680ee80fd67e0e6a2d4eea48d1e3230f401/userdata/",
+				10,
+			},
+			"",
+			true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := CreateSystemdUnitAsString(tt.args.name, tt.args.cid, tt.args.restart, tt.args.pidPath, tt.args.stopTimeout)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("CreateSystemdUnitAsString() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if got != tt.want {
+				t.Errorf("CreateSystemdUnitAsString() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}